Kaydet (Commit) 8f30da63 authored tarafından Stephan Bergmann's avatar Stephan Bergmann

Some clang-tidy misc-move-constructor-init

...by turning the relevant ctor parameters into "const &".

Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
üst 9e310a47
......@@ -115,7 +115,7 @@ struct SbiArgv { // Argv stack:
SbxArrayRef refArgv; // Argv
short nArgc; // Argc
SbiArgv(SbxArrayRef refArgv_, short nArgc_) :
SbiArgv(SbxArrayRef const & refArgv_, short nArgc_) :
refArgv(refArgv_),
nArgc(nArgc_) {}
};
......
......@@ -135,7 +135,7 @@ namespace dbtools
{
}
OCharsetMap::CharsetIterator::CharsetIterator(const OCharsetMap* _pContainer, OCharsetMap::TextEncBag::const_iterator _aPos )
OCharsetMap::CharsetIterator::CharsetIterator(const OCharsetMap* _pContainer, OCharsetMap::TextEncBag::const_iterator const & _aPos )
:m_pContainer( _pContainer )
,m_aPos( _aPos )
{
......
......@@ -144,7 +144,7 @@ namespace dbtools
const CharsetIterator& operator--();
protected:
CharsetIterator(const OCharsetMap* _pContainer, OCharsetMap::TextEncBag::const_iterator _aPos );
CharsetIterator(const OCharsetMap* _pContainer, OCharsetMap::TextEncBag::const_iterator const & _aPos );
};
......
......@@ -64,7 +64,7 @@ struct FragmentBaseData
explicit FragmentBaseData(
XmlFilterBase& rFilter,
const OUString& rFragmentPath,
RelationsRef xRelations );
RelationsRef const & xRelations );
};
......
......@@ -33,7 +33,7 @@ namespace oox { namespace drawingml {
class OOX_DLLPUBLIC ShapeContext : public ::oox::core::ContextHandler2
{
public:
ShapeContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr );
ShapeContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr const & pMasterShapePtr, ShapePtr const & pShapePtr );
virtual ~ShapeContext();
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
......
......@@ -33,7 +33,7 @@ namespace oox { namespace drawingml {
class OOX_DLLPUBLIC ShapeGroupContext : public ::oox::core::ContextHandler2
{
public:
ShapeGroupContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pGroupShapePtr );
ShapeGroupContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr const & pMasterShapePtr, ShapePtr const & pGroupShapePtr );
virtual ~ShapeGroupContext();
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
......
......@@ -105,7 +105,7 @@ class OOX_DLLPUBLIC VMLExport : public EscherEx
bool *m_pShapeTypeWritten;
public:
VMLExport( ::sax_fastparser::FSHelperPtr pSerializer, VMLTextExport* pTextExport = nullptr );
VMLExport( ::sax_fastparser::FSHelperPtr const & pSerializer, VMLTextExport* pTextExport = nullptr );
virtual ~VMLExport();
const ::sax_fastparser::FSHelperPtr&
......
......@@ -32,7 +32,7 @@ namespace oox { namespace ppt {
class SlideMasterTextStylesContext : public oox::core::FragmentHandler2
{
public:
SlideMasterTextStylesContext( ::oox::core::FragmentHandler2& rParent, SlidePersistPtr pSlidePersistPtr );
SlideMasterTextStylesContext( ::oox::core::FragmentHandler2& rParent, SlidePersistPtr const & pSlidePersistPtr );
virtual ~SlideMasterTextStylesContext();
virtual ::oox::core::ContextHandlerRef onCreateContext( sal_Int32 aElementToken, const AttributeList& rAttribs ) override;
......
......@@ -64,7 +64,7 @@ class SlidePersist : public std::enable_shared_from_this< SlidePersist >
public:
SlidePersist( oox::core::XmlFilterBase& rFilter, bool bMaster, bool bNotes,
const css::uno::Reference< css::drawing::XDrawPage >&,
oox::drawingml::ShapePtr pShapesPtr, const ::oox::drawingml::TextListStylePtr & );
oox::drawingml::ShapePtr const & pShapesPtr, const ::oox::drawingml::TextListStylePtr & );
~SlidePersist();
const css::uno::Reference< css::drawing::XDrawPage >& getPage() const { return mxPage; };
......
......@@ -34,7 +34,7 @@ namespace ucbhelper
{
public:
StdInputStream( boost::shared_ptr< std::istream > pStream );
StdInputStream( boost::shared_ptr< std::istream > const & pStream );
virtual ~StdInputStream();
......
......@@ -30,7 +30,7 @@ namespace ucbhelper
{
public:
StdOutputStream( boost::shared_ptr< std::ostream > pStream );
StdOutputStream( boost::shared_ptr< std::ostream > const & pStream );
virtual ~StdOutputStream( );
......
......@@ -144,7 +144,7 @@ private:
int findRangeIndex( sal_uInt32 ) const;
FontCharMap( ImplFontCharMapPtr pIFCMap );
FontCharMap( ImplFontCharMapPtr const & pIFCMap );
sal_uInt32 mnRefCount;
......
......@@ -43,7 +43,7 @@ protected:
class RegularTextRunContext : public ::oox::core::ContextHandler2
{
public:
RegularTextRunContext( ::oox::core::ContextHandler2Helper& rParent, TextRunPtr pRunPtr );
RegularTextRunContext( ::oox::core::ContextHandler2Helper& rParent, TextRunPtr const & pRunPtr );
virtual void onEndElement() override;
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
......
......@@ -28,7 +28,7 @@ using namespace ::com::sun::star::io;
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::xml::sax;
FragmentBaseData::FragmentBaseData( XmlFilterBase& rFilter, const OUString& rFragmentPath, RelationsRef xRelations ) :
FragmentBaseData::FragmentBaseData( XmlFilterBase& rFilter, const OUString& rFragmentPath, RelationsRef const & xRelations ) :
mrFilter( rFilter ),
maFragmentPath( rFragmentPath ),
mxRelations( xRelations )
......
......@@ -48,7 +48,7 @@ using namespace ::com::sun::star::xml::sax;
namespace oox { namespace drawingml {
// CT_Shape
ShapeContext::ShapeContext( ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr )
ShapeContext::ShapeContext( ContextHandler2Helper& rParent, ShapePtr const & pMasterShapePtr, ShapePtr const & pShapePtr )
: ContextHandler2( rParent )
, mpMasterShapePtr( pMasterShapePtr )
, mpShapePtr( pShapePtr )
......
......@@ -43,7 +43,7 @@ using namespace ::com::sun::star::xml::sax;
namespace oox { namespace drawingml {
ShapeGroupContext::ShapeGroupContext( ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pGroupShapePtr )
ShapeGroupContext::ShapeGroupContext( ContextHandler2Helper& rParent, ShapePtr const & pMasterShapePtr, ShapePtr const & pGroupShapePtr )
: ContextHandler2( rParent )
, mpGroupShapePtr( pGroupShapePtr )
, mpMasterShapePtr( pMasterShapePtr )
......
......@@ -104,7 +104,7 @@ ContextHandlerRef TextParagraphContext::onCreateContext( sal_Int32 aElementToken
return nullptr;
}
RegularTextRunContext::RegularTextRunContext( ContextHandler2Helper& rParent, TextRunPtr pRunPtr )
RegularTextRunContext::RegularTextRunContext( ContextHandler2Helper& rParent, TextRunPtr const & pRunPtr )
: ContextHandler2( rParent )
, mpRunPtr( pRunPtr )
, mbIsInText( false )
......
......@@ -51,7 +51,7 @@ using namespace com::sun::star;
static const sal_Int32 Tag_Container = 44444;
static const sal_Int32 Tag_Commit = 44445;
VMLExport::VMLExport( ::sax_fastparser::FSHelperPtr pSerializer, VMLTextExport* pTextExport )
VMLExport::VMLExport( ::sax_fastparser::FSHelperPtr const & pSerializer, VMLTextExport* pTextExport )
: EscherEx( std::make_shared<EscherExGlobal>(0), nullptr, /*bOOXML=*/true )
, m_pSerializer( pSerializer )
, m_pTextExport( pTextExport )
......
......@@ -22,8 +22,8 @@ ExtDrawingFragmentHandler::ExtDrawingFragmentHandler( XmlFilterBase& rFilter,
const OUString& rFragmentPath,
const oox::ppt::SlidePersistPtr& rSlidePersistPtr,
const oox::ppt::ShapeLocation eShapeLocation,
oox::drawingml::ShapePtr pGroupShapePtr,
oox::drawingml::ShapePtr pShapePtr)
oox::drawingml::ShapePtr const & pGroupShapePtr,
oox::drawingml::ShapePtr const & pShapePtr)
throw( )
: FragmentHandler2( rFilter, rFragmentPath ),
mpSlidePersistPtr (rSlidePersistPtr ),
......
......@@ -24,8 +24,8 @@ public:
ExtDrawingFragmentHandler( oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath,
const oox::ppt::SlidePersistPtr& rSlidePersistPtr,
const oox::ppt::ShapeLocation eShapeLocation,
oox::drawingml::ShapePtr pGroupShapePtr,
oox::drawingml::ShapePtr pShapePtr ) throw();
oox::drawingml::ShapePtr const & pGroupShapePtr,
oox::drawingml::ShapePtr const & pShapePtr ) throw();
virtual ~ExtDrawingFragmentHandler() throw();
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const AttributeList& rAttribs ) override;
......
......@@ -29,7 +29,7 @@ using namespace ::com::sun::star::xml::sax;
namespace oox { namespace ppt {
SlideMasterTextStylesContext::SlideMasterTextStylesContext( FragmentHandler2& rParent, SlidePersistPtr pSlidePersistPtr )
SlideMasterTextStylesContext::SlideMasterTextStylesContext( FragmentHandler2& rParent, SlidePersistPtr const & pSlidePersistPtr )
: FragmentHandler2( rParent )
, mpSlidePersistPtr( pSlidePersistPtr )
{
......
......@@ -52,7 +52,7 @@ namespace oox { namespace ppt {
SlidePersist::SlidePersist( XmlFilterBase& rFilter, bool bMaster, bool bNotes,
const css::uno::Reference< css::drawing::XDrawPage >& rxPage,
oox::drawingml::ShapePtr pShapesPtr, const drawingml::TextListStylePtr & pDefaultTextStyle )
oox::drawingml::ShapePtr const & pShapesPtr, const drawingml::TextListStylePtr & pDefaultTextStyle )
: mpDrawingPtr( new oox::vml::Drawing( rFilter, rxPage, oox::vml::VMLDRAWING_POWERPOINT ) )
, mxPage( rxPage )
, maShapesPtr( pShapesPtr )
......
......@@ -16,7 +16,7 @@ using namespace com::sun::star;
namespace oox { namespace shape {
ShapeDrawingFragmentHandler::ShapeDrawingFragmentHandler(oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, oox::drawingml::ShapePtr pGroupShapePtr ) throw()
ShapeDrawingFragmentHandler::ShapeDrawingFragmentHandler(oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, oox::drawingml::ShapePtr const & pGroupShapePtr ) throw()
: FragmentHandler2(rFilter, rFragmentPath),
mpGroupShapePtr(pGroupShapePtr)
{
......
......@@ -19,7 +19,7 @@ namespace oox { namespace shape {
class ShapeDrawingFragmentHandler : public oox::core::FragmentHandler2
{
public:
ShapeDrawingFragmentHandler( oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, oox::drawingml::ShapePtr pGroupShapePtr ) throw();
ShapeDrawingFragmentHandler( oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, oox::drawingml::ShapePtr const & pGroupShapePtr ) throw();
virtual ~ShapeDrawingFragmentHandler() throw();
virtual void SAL_CALL endDocument() throw (css::xml::sax::SAXException, css::uno::RuntimeException, std::exception) override;
virtual ::oox::core::ContextHandlerRef onCreateContext(sal_Int32 Element, const AttributeList& rAttribs ) override;
......
......@@ -56,7 +56,7 @@ namespace basprov
// BasicScriptImpl
BasicScriptImpl::BasicScriptImpl( const OUString& funcName, SbMethodRef xMethod )
BasicScriptImpl::BasicScriptImpl( const OUString& funcName, SbMethodRef const & xMethod )
: ::scripting_helper::OBroadcastHelperHolder( m_aMutex )
,OPropertyContainer( GetBroadcastHelper() )
,m_xMethod( xMethod )
......@@ -68,7 +68,7 @@ namespace basprov
}
BasicScriptImpl::BasicScriptImpl( const OUString& funcName, SbMethodRef xMethod,
BasicScriptImpl::BasicScriptImpl( const OUString& funcName, SbMethodRef const & xMethod,
BasicManager& documentBasicManager, const Reference< XScriptInvocationContext >& documentScriptContext ) : ::scripting_helper::OBroadcastHelperHolder( m_aMutex )
,OPropertyContainer( GetBroadcastHelper() )
,m_xMethod( xMethod )
......
......@@ -69,11 +69,11 @@ namespace basprov
public:
BasicScriptImpl(
const OUString& funcName,
SbMethodRef xMethod
SbMethodRef const & xMethod
);
BasicScriptImpl(
const OUString& funcName,
SbMethodRef xMethod,
SbMethodRef const & xMethod,
BasicManager& documentBasicManager,
const css::uno::Reference< css::document::XScriptInvocationContext >& documentScriptContext
);
......
......@@ -530,7 +530,7 @@ namespace sfx2
struct FindGroupEntry : public ::std::unary_function< MapGroupEntry2GroupEntry::value_type, sal_Bool >
{
FilterGroupEntryReferrer::mapped_type aLookingFor;
explicit FindGroupEntry( FilterGroupEntryReferrer::mapped_type _rLookingFor ) : aLookingFor( _rLookingFor ) { }
explicit FindGroupEntry( FilterGroupEntryReferrer::mapped_type const & _rLookingFor ) : aLookingFor( _rLookingFor ) { }
bool operator() ( const MapGroupEntry2GroupEntry::value_type& _rMapEntry )
{
......
......@@ -285,7 +285,7 @@ namespace cmis
{
Content::Content( const uno::Reference< uno::XComponentContext >& rxContext,
ContentProvider *pProvider, const uno::Reference< ucb::XContentIdentifier >& Identifier,
libcmis::ObjectPtr pObject )
libcmis::ObjectPtr const & pObject )
throw ( ucb::ContentCreationException )
: ContentImplHelper( rxContext, pProvider, Identifier ),
m_pProvider( pProvider ),
......
......@@ -128,7 +128,7 @@ public:
Content( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
ContentProvider *pProvider,
const css::uno::Reference< css::ucb::XContentIdentifier >& Identifier,
libcmis::ObjectPtr pObject = libcmis::ObjectPtr( ) )
libcmis::ObjectPtr const & pObject = libcmis::ObjectPtr( ) )
throw ( css::ucb::ContentCreationException );
Content( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
......
......@@ -49,7 +49,7 @@ namespace cmis
{
RepoContent::RepoContent( const uno::Reference< uno::XComponentContext >& rxContext,
ContentProvider *pProvider, const uno::Reference< ucb::XContentIdentifier >& Identifier,
vector< libcmis::RepositoryPtr > aRepos )
vector< libcmis::RepositoryPtr > const & aRepos )
throw ( ucb::ContentCreationException )
: ContentImplHelper( rxContext, pProvider, Identifier ),
m_pProvider( pProvider ),
......
......@@ -75,7 +75,7 @@ public:
RepoContent( const css::uno::Reference<
css::uno::XComponentContext >& rxContext, ContentProvider *pProvider,
const css::uno::Reference< css::ucb::XContentIdentifier >& Identifier,
std::vector< libcmis::RepositoryPtr > aRepos = std::vector< libcmis::RepositoryPtr > ( ) )
std::vector< libcmis::RepositoryPtr > const & aRepos = std::vector< libcmis::RepositoryPtr > ( ) )
throw ( css::ucb::ContentCreationException );
virtual ~RepoContent();
......
......@@ -18,7 +18,7 @@ using namespace com::sun::star;
namespace ucbhelper
{
StdInputStream::StdInputStream( boost::shared_ptr< istream > pStream ) :
StdInputStream::StdInputStream( boost::shared_ptr< istream > const & pStream ) :
m_pStream( pStream ),
m_nLength( 0 )
{
......
......@@ -18,7 +18,7 @@ using namespace com::sun::star;
namespace ucbhelper
{
StdOutputStream::StdOutputStream( boost::shared_ptr< ostream > pStream ) :
StdOutputStream::StdOutputStream( boost::shared_ptr< ostream > const & pStream ) :
m_pStream( pStream )
{
}
......
......@@ -149,7 +149,7 @@ class UcbPropertiesChangeListener_Impl : public ::cppu::WeakImplHelper< XPropert
public:
UcbLockBytesRef m_xLockBytes;
explicit UcbPropertiesChangeListener_Impl( UcbLockBytesRef rRef )
explicit UcbPropertiesChangeListener_Impl( UcbLockBytesRef const & rRef )
: m_xLockBytes( rRef )
{}
......
......@@ -31,7 +31,7 @@ using namespace ooo::vba;
ScVbaCommandBar::ScVbaCommandBar( const uno::Reference< ov::XHelperInterface >& xParent,
const uno::Reference< uno::XComponentContext >& xContext,
VbaCommandBarHelperRef pHelper,
VbaCommandBarHelperRef const & pHelper,
const uno::Reference< container::XIndexAccess >& xBarSettings,
const OUString& sResourceUrl, bool bIsMenu ) throw( uno::RuntimeException )
: CommandBar_BASE( xParent, xContext ), pCBarHelper( pHelper ), m_xBarSettings( xBarSettings ), m_sResourceUrl( sResourceUrl ), m_bIsMenu( bIsMenu )
......
......@@ -39,7 +39,7 @@ private:
bool m_bIsMenu;
public:
ScVbaCommandBar( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, VbaCommandBarHelperRef pHelper, const css::uno::Reference< css::container::XIndexAccess >& xBarSettings, const OUString& sResourceUrl, bool bIsMenu ) throw( css::uno::RuntimeException );
ScVbaCommandBar( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, VbaCommandBarHelperRef const & pHelper, const css::uno::Reference< css::container::XIndexAccess >& xBarSettings, const OUString& sResourceUrl, bool bIsMenu ) throw( css::uno::RuntimeException );
// Attributes
virtual OUString SAL_CALL getName() throw (css::uno::RuntimeException, std::exception) override;
......
......@@ -47,7 +47,7 @@ public:
}
};
ScVbaCommandBarControls::ScVbaCommandBarControls( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< container::XIndexAccess>& xIndexAccess, VbaCommandBarHelperRef pHelper, const uno::Reference< container::XIndexAccess>& xBarSettings, const OUString& sResourceUrl ) throw (uno::RuntimeException) : CommandBarControls_BASE( xParent, xContext, xIndexAccess ), pCBarHelper( pHelper ), m_xBarSettings( xBarSettings ), m_sResourceUrl( sResourceUrl )
ScVbaCommandBarControls::ScVbaCommandBarControls( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< container::XIndexAccess>& xIndexAccess, VbaCommandBarHelperRef const & pHelper, const uno::Reference< container::XIndexAccess>& xBarSettings, const OUString& sResourceUrl ) throw (uno::RuntimeException) : CommandBarControls_BASE( xParent, xContext, xIndexAccess ), pCBarHelper( pHelper ), m_xBarSettings( xBarSettings ), m_sResourceUrl( sResourceUrl )
{
m_bIsMenu = sResourceUrl == ITEM_MENUBAR_URL;
}
......
......@@ -45,7 +45,7 @@ private:
static css::uno::Sequence< css::beans::PropertyValue > CreateToolbarItemData( const OUString& sCommandURL, const OUString& sHelpURL, const OUString& sLabel, sal_uInt16 nType, const css::uno::Any& aSubMenu, bool isVisible, sal_Int32 nStyle );
public:
ScVbaCommandBarControls( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::container::XIndexAccess >& xIndexAccess, VbaCommandBarHelperRef pHelper, const css::uno::Reference< css::container::XIndexAccess >& xBarSettings, const OUString& sResourceUrl ) throw( css::uno::RuntimeException );
ScVbaCommandBarControls( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::container::XIndexAccess >& xIndexAccess, VbaCommandBarHelperRef const & pHelper, const css::uno::Reference< css::container::XIndexAccess >& xBarSettings, const OUString& sResourceUrl ) throw( css::uno::RuntimeException );
bool IsMenu(){ return m_bIsMenu; }
// XEnumerationAccess
......
......@@ -388,7 +388,7 @@ FontCharMap::FontCharMap()
, mnRefCount(0)
{}
FontCharMap::FontCharMap( ImplFontCharMapPtr pIFCMap )
FontCharMap::FontCharMap( ImplFontCharMapPtr const & pIFCMap )
: mpImplFontCharMap( pIFCMap )
, mnRefCount(0)
{}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment