loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)

Change-Id: Ia91f035c188fa99cdf0b9e80cb256e1b86f00551

extensions/qa/update/test_update.cxx

@@ -101,11 +101,11 @@ protected:
         rtl::Reference< UpdateCheck > aController( UpdateCheck::get() );
 
         if ( checkForUpdates( aInfo, m_xContext, aController->getInteractionHandler(), m_xProvider,
-                    OUString( "Linux" ),
-                    OUString( "x86" ),
+                    "Linux",
+                    "x86",
                     m_aRepositoryList,
-                    OUString( "111111-222222-333333-444444" ),
-                    OUString( "InstallSetID" ) ) )
+                    "111111-222222-333333-444444",
+                    "InstallSetID" ) )
         {
             CPPUNIT_ASSERT( aInfo.Sources.size() == 1 );
             CPPUNIT_ASSERT( aInfo.Sources[0].URL == "http://www.libreoffice.org/download/" );
@@ -121,11 +121,11 @@ protected:
         rtl::Reference< UpdateCheck > aController( UpdateCheck::get() );
 
         if ( checkForUpdates( aInfo, m_xContext, aController->getInteractionHandler(), m_xProvider,
-                    OUString( "Linux" ),
-                    OUString( "x86" ),
+                    "Linux",
+                    "x86",
                     m_aRepositoryList,
-                    OUString( "123456-abcdef-1a2b3c-4d5e6f" ),
-                    OUString( "InstallSetID" ) ) )
+                    "123456-abcdef-1a2b3c-4d5e6f",
+                    "InstallSetID" ) )
         {
             CPPUNIT_ASSERT( aInfo.Sources.empty() );
         }

extensions/source/abpilot/abpfinalpage.cxx

@@ -37,7 +37,7 @@ namespace abp
 
     const SfxFilter* lcl_getBaseFilter()
     {
-        const SfxFilter* pFilter = SfxFilter::GetFilterByName(OUString("StarOffice XML (Base)"));
+        const SfxFilter* pFilter = SfxFilter::GetFilterByName("StarOffice XML (Base)");
         OSL_ENSURE(pFilter,"Filter: StarOffice XML (Base) could not be found!");
         return pFilter;
     }

extensions/source/abpilot/unodialogabp.cxx

@@ -44,7 +44,7 @@ namespace abp
     OABSPilotUno::OABSPilotUno(const Reference< XComponentContext >& _rxORB)
         :OGenericUnoDialog(_rxORB)
     {
-        registerProperty( OUString("DataSourceName"), PROPERTY_ID_DATASOURCENAME, PropertyAttribute::READONLY ,
+        registerProperty( "DataSourceName", PROPERTY_ID_DATASOURCENAME, PropertyAttribute::READONLY ,
             &m_sDataSourceName, cppu::UnoType<decltype(m_sDataSourceName)>::get() );
     }
 

extensions/source/dbpilots/commonpagesdbp.cxx

@@ -199,7 +199,7 @@ namespace dbp
                 ui::dialogs::TemplateDescription::FILEOPEN_READONLY_VERSION, 0);
         aFileDlg.SetDisplayDirectory( SvtPathOptions().GetWorkPath() );
 
-        const SfxFilter* pFilter = SfxFilter::GetFilterByName(OUString("StarOffice XML (Base)"));
+        const SfxFilter* pFilter = SfxFilter::GetFilterByName("StarOffice XML (Base)");
         OSL_ENSURE(pFilter,"Filter: StarOffice XML (Base) could not be found!");
         if ( pFilter )
         {

extensions/source/logging/logger.cxx

@@ -313,7 +313,7 @@ namespace logging
 
     Reference< XLogger > SAL_CALL LoggerPool::getDefaultLogger(  ) throw (RuntimeException, std::exception)
     {
-        return getNamedLogger( OUString( "org.openoffice.logging.DefaultLogger" ) );
+        return getNamedLogger( "org.openoffice.logging.DefaultLogger" );
     }
 
     void createRegistryInfo_LoggerPool()

extensions/source/plugin/base/manager.cxx

@@ -176,8 +176,8 @@ Sequence<css::plugin::PluginDescription> XPluginManager_Impl::getPluginDescripti
     Sequence<css::plugin::PluginDescription> aRet;
 
     vcl::SettingsConfigItem* pCfg = vcl::SettingsConfigItem::get();
-    OUString aVal( pCfg->getValue( OUString(  "BrowserPlugins"  ),
-                                        OUString(  "Disabled"  ) ) );
+    OUString aVal( pCfg->getValue( "BrowserPlugins",
+                                        "Disabled" ) );
     if( ! aVal.toBoolean() )
     {
         aRet = impl_getPluginDescriptions();

extensions/source/propctrlr/browserline.cxx

@@ -379,7 +379,7 @@ namespace pcr
             rpButton = VclPtr<PushButton>::Create( m_pTheParent, WB_NOPOINTERFOCUS );
             rpButton->SetGetFocusHdl( LINK( this, OBrowserLine, OnButtonFocus ) );
             rpButton->SetClickHdl( LINK( this, OBrowserLine, OnButtonClicked ) );
-            rpButton->SetText(OUString("..."));
+            rpButton->SetText("...");
         }
 
         rpButton->Show();

extensions/source/propctrlr/formcomponenthandler.cxx

@@ -2903,7 +2903,7 @@ namespace pcr
             // is considered to be potentially expensive
             aFileDlg.SetDisplayDirectory( sDataSource );
 
-        const SfxFilter* pFilter = SfxFilter::GetFilterByName(OUString("StarOffice XML (Base)"));
+        const SfxFilter* pFilter = SfxFilter::GetFilterByName("StarOffice XML (Base)");
         OSL_ENSURE(pFilter,"Filter: StarOffice XML (Base) could not be found!");
         if ( pFilter )
         {

extensions/source/propctrlr/inspectormodelbase.cxx

@@ -99,25 +99,25 @@ namespace pcr
         ,m_bIsReadOnly( false )
     {
         registerProperty(
-            OUString( "HasHelpSection" ),
+            "HasHelpSection",
             MODEL_PROPERTY_ID_HAS_HELP_SECTION,
             PropertyAttribute::READONLY,
             &m_bHasHelpSection, cppu::UnoType<decltype(m_bHasHelpSection)>::get()
         );
         registerProperty(
-            OUString( "MinHelpTextLines" ),
+            "MinHelpTextLines",
             MODEL_PROPERTY_ID_MIN_HELP_TEXT_LINES,
             PropertyAttribute::READONLY,
             &m_nMinHelpTextLines, cppu::UnoType<decltype(m_nMinHelpTextLines)>::get()
         );
         registerProperty(
-            OUString( "MaxHelpTextLines" ),
+            "MaxHelpTextLines",
             MODEL_PROPERTY_ID_MAX_HELP_TEXT_LINES,
             PropertyAttribute::READONLY,
             &m_nMaxHelpTextLines, cppu::UnoType<decltype(m_nMaxHelpTextLines)>::get()
         );
         registerProperty(
-            OUString( "IsReadOnly" ),
+            "IsReadOnly",
             MODEL_PROPERTY_ID_IS_READ_ONLY,
             PropertyAttribute::BOUND,
             &m_bIsReadOnly, cppu::UnoType<decltype(m_bIsReadOnly)>::get()

extensions/source/propctrlr/usercontrol.cxx

@@ -312,7 +312,7 @@ namespace pcr
         :ONumericControl( pParent, nWinStyle )
     {
         getTypedControlWindow()->SetUnit( FUNIT_CUSTOM );
-        getTypedControlWindow()->SetCustomUnitText(OUString(" ms"));
+        getTypedControlWindow()->SetCustomUnitText(" ms");
         getTypedControlWindow()->SetCustomConvertHdl( LINK( this, OTimeDurationControl, OnCustomConvert ) );
     }
 

extensions/source/scanner/sanedlg.cxx

@@ -478,7 +478,7 @@ void SaneDlg::InitFields()
                 else // SANE_UNIT_PIXEL
                 {
                     pField->SetValue( (int)fValue, FUNIT_CUSTOM );
-                    pField->SetCustomUnitText(OUString("Pixel"));
+                    pField->SetCustomUnitText("Pixel");
                 }
                 switch( i ) {
                     case 0: aTopLeft.X() = (int)fValue;break;