Kaydet (Commit) 867ee21f authored tarafından Noel Grandin's avatar Noel Grandin

clang-tidy bugprone-unused-raii in RequestHandler

The message from clang-tidy is:
    warning: object destroyed immediately after creation; did you mean
to name the object?

The guard in
RequestHandler::ExecuteCmdLineRequests
comes from
commit cf333a87
Date:   Sun Jan 21 22:10:09 2018 +0300
tdf#38915: set cProcessed condition on any process outcome
and I'm sure it's intention was to set the flag on exit from the
function, not immediately.

Change-Id: Ibf874a5774770df00b9db7f673554e7ffda55072
Reviewed-on: https://gerrit.libreoffice.org/60183Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
üst ba5670b2
......@@ -1319,7 +1319,7 @@ bool RequestHandler::ExecuteCmdLineRequests(
osl::ClearableMutexGuard aGuard( GetMutex() );
// ensure that Processed flag (if exists) is signaled in any outcome
ConditionSetGuard(aRequest.pcProcessed);
ConditionSetGuard aSetGuard(aRequest.pcProcessed);
static std::vector<DispatchWatcher::DispatchRequest> aDispatchList;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment