loplugin:returnconstant in unoxml,uui

Change-Id: Iac240f59acf8404fe5439a7e450c048df0d7a54e
Reviewed-on: https://gerrit.libreoffice.org/58879
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

unoxml/inc/eventdispatcher.hxx

@@ -69,7 +69,7 @@ public:
         const OUString& aType,
         const css::uno::Reference< css::xml::dom::events::XEvent >& xEvent);
 
-    bool dispatchEvent(
+    void dispatchEvent(
         DOM::CDocument & rDocument,
         ::osl::Mutex & rMutex,
         xmlNodePtr const pNode,

unoxml/source/events/eventdispatcher.cxx

@@ -102,7 +102,7 @@ namespace DOM { namespace events {
         }
     }
 
-    bool CEventDispatcher::dispatchEvent(
+    void CEventDispatcher::dispatchEvent(
             DOM::CDocument & rDocument, ::osl::Mutex & rMutex,
             xmlNodePtr const pNode, Reference<XNode> const& xNode,
             Reference< XEvent > const& i_xEvent) const
@@ -117,7 +117,7 @@ namespace DOM { namespace events {
         }
 
         if (captureListeners.empty() && targetListeners.empty())
-            return true;
+            return;
 
         CEvent *pEvent = nullptr; // pointer to internal event representation
 
@@ -222,7 +222,7 @@ namespace DOM { namespace events {
             {
                 pEvent->m_currentTarget = rinode->first;
                 callListeners(captureListeners, rinode->second, aType, xEvent);
-                if  (pEvent->m_canceled) return true;
+                if  (pEvent->m_canceled) return;
                 ++rinode;
             }
 
@@ -232,7 +232,7 @@ namespace DOM { namespace events {
             pEvent->m_phase = PhaseType_AT_TARGET;
             pEvent->m_currentTarget = inode->first;
             callListeners(targetListeners, inode->second, aType, xEvent);
-            if  (pEvent->m_canceled) return true;
+            if  (pEvent->m_canceled) return;
             // bubbeling phase
             ++inode;
             if (i_xEvent->getBubbles()) {
@@ -242,12 +242,11 @@ namespace DOM { namespace events {
                     pEvent->m_currentTarget = inode->first;
                     callListeners(targetListeners,
                             inode->second, aType, xEvent);
-                    if  (pEvent->m_canceled) return true;
+                    if  (pEvent->m_canceled) return;
                     ++inode;
                 }
             }
         }
-        return true;
     }
 }}
 

uui/source/iahndl-authentication.cxx

@@ -724,7 +724,7 @@ UUIInteractionHelper::handlePasswordRequest(
     return false;
 }
 
-bool
+void
 UUIInteractionHelper::handleAuthFallbackRequest( OUString & instructions,
         OUString & url,
         uno::Sequence< uno::Reference< task::XInteractionContinuation > > const & rContinuations )
@@ -741,8 +741,6 @@ UUIInteractionHelper::handleAuthFallbackRequest( OUString & instructions,
         xAuthFallback->setCode(dlg.GetCode());
         xAuthFallback->select( );
     }
-
-    return true;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

uui/source/iahndl.hxx

@@ -235,7 +235,7 @@ private:
                 const OUString& i_rServiceName
             ) const;
 
-    bool
+    void
     handleAuthFallbackRequest(
             OUString & instructions,
             OUString & url,