Prefer prefix ++/-- operators for non-primitive types

+ replace "<" by "!=" for end iterator comparison with current it

Change-Id: I6e90caa8752c7057cca8c74fca12c0a050544dbb

oox/source/vml/vmlshape.cxx

@@ -667,8 +667,8 @@ Reference< XShape > BezierShape::implConvertAndInsert( const Reference< XShapes
             // Parse VML path string and convert to absolute coordinates
             ConversionHelper::decodeVmlPath( aCoordLists, aFlagLists, maShapeModel.maVmlPath );
 
-            for ( SubPathList::iterator aListIt = aCoordLists.begin(); aListIt != aCoordLists.end(); aListIt++ )
-                for ( ::std::vector< Point >::iterator aPointIt = (*aListIt).begin(); aPointIt != (*aListIt).end(); aPointIt++)
+            for ( SubPathList::iterator aListIt = aCoordLists.begin(); aListIt != aCoordLists.end(); ++aListIt )
+                for ( ::std::vector< Point >::iterator aPointIt = (*aListIt).begin(); aPointIt != (*aListIt).end(); ++aPointIt)
                 {
                     (*aPointIt) = lclGetAbsPoint( (*aPointIt), rShapeRect, aCoordSys );
                 }

sd/source/ui/remotecontrol/Server.cxx

@@ -186,7 +186,7 @@ void RemoteServer::presentationStarted( const css::uno::Reference<
         return;
     MutexGuard aGuard( spServer->mDataMutex );
     for ( vector<Communicator*>::const_iterator aIt = spServer->mCommunicators.begin();
-         aIt < spServer->mCommunicators.end(); aIt++ )
+         aIt != spServer->mCommunicators.end(); ++aIt )
     {
         (*aIt)->presentationStarted( rController );
     }
@@ -197,7 +197,7 @@ void RemoteServer::presentationStopped()
         return;
     MutexGuard aGuard( spServer->mDataMutex );
     for ( vector<Communicator*>::const_iterator aIt = spServer->mCommunicators.begin();
-         aIt < spServer->mCommunicators.end(); aIt++ )
+         aIt != spServer->mCommunicators.end(); ++aIt )
     {
         (*aIt)->disposeListener();
     }
@@ -209,7 +209,7 @@ void RemoteServer::removeCommunicator( Communicator* mCommunicator )
         return;
     MutexGuard aGuard( spServer->mDataMutex );
     for ( vector<Communicator*>::iterator aIt = spServer->mCommunicators.begin();
-         aIt < spServer->mCommunicators.end(); aIt++ )
+         aIt != spServer->mCommunicators.end(); ++aIt )
     {
         if ( mCommunicator == *aIt )
         {
@@ -275,7 +275,7 @@ sal_Bool RemoteServer::connectClient( ClientInfo* pClient, rtl::OUString aPin )
         spServer->mCommunicators.push_back( pCommunicator );
 
         for ( vector<ClientInfoInternal*>::iterator aIt = spServer->mAvailableClients.begin();
-            aIt < spServer->mAvailableClients.end(); aIt++ )
+            aIt != spServer->mAvailableClients.end(); ++aIt )
         {
             if ( pClient == *aIt )
             {

sot/source/sdstor/stgcache.cxx

@@ -135,7 +135,7 @@ void StgCache::Erase( const rtl::Reference< StgPage > &xElem )
 {
     OSL_ENSURE( xElem.is(), "The pointer should not be NULL!" );
     if ( xElem.is() ) {
-        for ( LRUList::iterator it = maLRUPages.begin(); it != maLRUPages.end(); it++ ) {
+        for ( LRUList::iterator it = maLRUPages.begin(); it != maLRUPages.end(); ++it ) {
             if ( it->is() && (*it)->GetPage() == xElem->GetPage() ) {
                 it->clear();
                 break;
@@ -149,7 +149,7 @@ void StgCache::Erase( const rtl::Reference< StgPage > &xElem )
 void StgCache::Clear()
 {
     maDirtyPages.clear();
-    for ( LRUList::iterator it = maLRUPages.begin(); it != maLRUPages.end(); it++ )
+    for ( LRUList::iterator it = maLRUPages.begin(); it != maLRUPages.end(); ++it )
         it->clear();
 }
 
@@ -157,7 +157,7 @@ void StgCache::Clear()
 
 rtl::Reference< StgPage > StgCache::Find( sal_Int32 nPage )
 {
-    for ( LRUList::iterator it = maLRUPages.begin(); it != maLRUPages.end(); it++ )
+    for ( LRUList::iterator it = maLRUPages.begin(); it != maLRUPages.end(); ++it )
         if ( it->is() && (*it)->GetPage() == nPage )
             return *it;
     IndexToStgPage::iterator it2 = maDirtyPages.find( nPage );
@@ -216,12 +216,12 @@ sal_Bool StgCache::Commit()
     {
         std::vector< StgPage * > aToWrite;
         for ( IndexToStgPage::iterator aIt = maDirtyPages.begin();
-              aIt != maDirtyPages.end(); aIt++ )
+              aIt != maDirtyPages.end(); ++aIt )
             aToWrite.push_back( aIt->second.get() );
 
         std::sort( aToWrite.begin(), aToWrite.end(), StgPage::IsPageGreater );
         for ( std::vector< StgPage * >::iterator aWr = aToWrite.begin();
-              aWr != aToWrite.end(); aWr++)
+              aWr != aToWrite.end(); ++aWr)
         {
             const rtl::Reference< StgPage > &pPage = *aWr;
             if ( !Write( pPage->GetPage(), pPage->GetData(), 1 ) )

ucb/source/ucp/webdav/DAVResourceAccess.cxx

@@ -1116,7 +1116,7 @@ sal_Bool DAVResourceAccess::detectRedirectCycle(
         if ( aUri == (*it) )
             return sal_True;
 
-        it++;
+        ++it;
     }
 
     return sal_False;

ucb/source/ucp/webdav/webdavcontentcaps.cxx

@@ -429,7 +429,7 @@ uno::Sequence< beans::Property > Content::getProperties(
             {
                 bHasCreatableInfos = sal_True;
             }
-            it++;
+            ++it;
         }
     }
 

ucb/source/ucp/webdav/webdavdatasupplier.cxx

@@ -105,7 +105,7 @@ DataSupplier_Impl::~DataSupplier_Impl()
     while ( it != end )
     {
         delete (*it);
-        it++;
+        ++it;
     }
 }
 
@@ -370,7 +370,7 @@ sal_Bool DataSupplier::getData()
             if ( (*it).equals( DAVProperties::RESOURCETYPE ) )
                 break;
 
-            it++;
+            ++it;
         }
 
         if ( it == end )