catch by constant reference

binaryurp/qa/test-unmarshal.cxx

@@ -108,7 +108,7 @@ void Test::testTypeOfVoidSequence() {
     try {
         m.readType();
         CPPUNIT_FAIL("exception expected");
-    } catch (css::io::IOException &) {}
+    } catch (const css::io::IOException &) {}
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);

binaryurp/source/bridge.cxx

@@ -259,7 +259,7 @@ void Bridge::terminate() {
     }
     try {
         connection_->close();
-    } catch (css::io::IOException & e) {
+    } catch (const css::io::IOException & e) {
         SAL_INFO("binaryurp", "caught IO exception '" << e.Message << '\'');
     }
     assert(w.is());
@@ -289,7 +289,7 @@ void Bridge::terminate() {
             (*i)->disposing(
                 css::lang::EventObject(
                     static_cast< cppu::OWeakObject * >(this)));
-        } catch (css::uno::RuntimeException & e) {
+        } catch (const css::uno::RuntimeException & e) {
             SAL_WARN(
                 "binaryurp", "caught runtime exception '" << e.Message << '\'');
         }
@@ -505,10 +505,10 @@ void Bridge::revokeProxy(Proxy & proxy) {
 void Bridge::freeProxy(Proxy & proxy) {
     try {
         makeReleaseCall(proxy.getOid(), proxy.getType());
-    } catch (css::uno::RuntimeException & e) {
+    } catch (const css::uno::RuntimeException & e) {
         SAL_INFO(
             "binaryurp", "caught runtime exception '" << e.Message << '\'');
-    } catch (std::exception & e) {
+    } catch (const std::exception & e) {
         SAL_WARN("binaryurp", "caught C++ exception '" << e.what() << '\'');
     }
     bool unused;
@@ -660,7 +660,7 @@ void Bridge::handleCommitChangeReply(
     bool ccMode = true;
     try {
         throwException(exception, returnValue);
-    } catch (css::bridge::InvalidProtocolChangeException &) {
+    } catch (const css::bridge::InvalidProtocolChangeException &) {
         ccMode = false;
     }
     if (ccMode) {

binaryurp/source/incomingrequest.cxx

@@ -87,7 +87,7 @@ void IncomingRequest::execute() const {
         try {
             try {
                 isExc = !execute_throw(&ret, &outArgs);
-            } catch (std::exception & e) {
+            } catch (const std::exception & e) {
                 throw css::uno::RuntimeException(
                     (rtl::OUString(
                         RTL_CONSTASCII_USTRINGPARAM("caught C++ exception: ")) +
@@ -96,7 +96,7 @@ void IncomingRequest::execute() const {
                     css::uno::Reference< css::uno::XInterface >());
                     // best-effort string conversion
             }
-        } catch (css::uno::RuntimeException &) {
+        } catch (const css::uno::RuntimeException &) {
             css::uno::Any exc(cppu::getCaughtException());
             ret = bridge_->mapCppToBinaryAny(exc);
             isExc = true;
@@ -104,7 +104,7 @@ void IncomingRequest::execute() const {
         if (resetCc) {
             current_context::set(oldCc);
         }
-    } catch (css::uno::RuntimeException &) {
+    } catch (const css::uno::RuntimeException &) {
         css::uno::Any exc(cppu::getCaughtException());
         ret = bridge_->mapCppToBinaryAny(exc);
         isExc = true;
@@ -115,12 +115,12 @@ void IncomingRequest::execute() const {
             bridge_->getWriter()->queueReply(
                 tid_, member_, setter_, isExc, ret, outArgs, false);
             return;
-        } catch (css::uno::RuntimeException & e) {
+        } catch (const css::uno::RuntimeException & e) {
             OSL_TRACE(
                 OSL_LOG_PREFIX "caught UNO runtime exception '%s'",
                 (rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8).
                  getStr()));
-        } catch (std::exception & e) {
+        } catch (const std::exception & e) {
             OSL_TRACE(OSL_LOG_PREFIX "caught C++ exception '%s'", e.what());
         }
         bridge_->terminate();
@@ -162,7 +162,7 @@ bool IncomingRequest::execute_throw(
             if (prov.is()) {
                 try {
                     ifc = prov->getInstance(oid_);
-                } catch (css::container::NoSuchElementException & e) {
+                } catch (const css::container::NoSuchElementException & e) {
                     OSL_TRACE(
                         (OSL_LOG_PREFIX "initial element '%s':"
                          " NoSuchElementException '%s'"),

binaryurp/source/proxy.cxx

@@ -116,7 +116,7 @@ void Proxy::do_dispatch(
     try {
         try {
             do_dispatch_throw(member, returnValue, arguments, exception);
-        } catch (std::exception & e) {
+        } catch (const std::exception & e) {
             throw css::uno::RuntimeException(
                 (rtl::OUString(
                     RTL_CONSTASCII_USTRINGPARAM("caught C++ exception: ")) +
@@ -125,7 +125,7 @@ void Proxy::do_dispatch(
                 css::uno::Reference< css::uno::XInterface >());
                 // best-effort string conversion
         }
-    } catch (css::uno::RuntimeException &) {
+    } catch (const css::uno::RuntimeException &) {
         css::uno::Any exc(cppu::getCaughtException());
         uno_copyAndConvertData(
             *exception, &exc,

binaryurp/source/reader.cxx

@@ -145,9 +145,9 @@ void Reader::run() {
             }
             block.done();
         }
-    } catch (css::uno::Exception & e) {
+    } catch (const css::uno::Exception & e) {
         SAL_WARN("binaryurp", "caught UNO exception '" << e.Message << '\'');
-    } catch (std::exception & e) {
+    } catch (const std::exception & e) {
         SAL_WARN("binaryurp", "caught C++ exception '" << e.what() << '\'');
     }
     bridge_->terminate();

binaryurp/source/writer.cxx

@@ -189,11 +189,11 @@ void Writer::run() {
                 }
             }
         }
-    } catch (css::uno::Exception & e) {
+    } catch (const css::uno::Exception & e) {
         OSL_TRACE(
             OSL_LOG_PREFIX "caught UNO exception '%s'",
             rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8).getStr());
-    } catch (std::exception & e) {
+    } catch (const std::exception & e) {
         OSL_TRACE(OSL_LOG_PREFIX "caught C++ exception '%s'", e.what());
     }
     bridge_->terminate();
@@ -447,7 +447,7 @@ void Writer::sendMessage(std::vector< unsigned char > const & buffer) {
         rtl_copyMemory(s.getArray() + s.getLength() - k, p, k);
         try {
             bridge_->getConnection()->write(s);
-        } catch (css::io::IOException & e) {
+        } catch (const css::io::IOException & e) {
             css::uno::Any exc(cppu::getCaughtException());
             throw css::lang::WrappedTargetRuntimeException(
                 (rtl::OUString(

bridges/inc/bridges/cpp_uno/bridge.hxx

@@ -464,9 +464,9 @@ inline void SAL_CALL cppu_cppenv_computeObjectIdentifier(
                 ::rtl_uString_acquire( *ppOId = aRet.pData );
             }
         }
-        catch (::com::sun::star::uno::RuntimeException &)
+        catch (const ::com::sun::star::uno::RuntimeException &)
         {
-            OSL_FAIL( "### RuntimeException occurred udring queryInterface()!" );
+            OSL_FAIL( "### RuntimeException occurred during queryInterface()!" );
         }
     }
 }

bridges/source/cpp_uno/cc5_solaris_sparc64/uno2cpp.cxx

@@ -332,7 +332,7 @@ void call(
         callVirtualMethod(
             (*thisPtr)[slot.index + 2], stack,
             std::max< sal_Int32 >(sp - 6, 0) * sizeof (long));
-    } catch (css::uno::Exception &) {
+    } catch (const css::uno::Exception &) {
         void * exc = __Crun::ex_get();
         char const * name = __Cimpl::ex_name();
         bridges::cpp_uno::cc5_solaris_sparc64::fillUnoException(

bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx

@@ -390,9 +390,9 @@ static void cpp_call(
                 pStackStart, ( pStack - pStackStart ),
                 pGPR, nGPR,
                 pFPR, nFPR );
-        } catch (Exception &) {
+        } catch (const Exception &) {
             throw;
-        } catch (std::exception & e) {
+        } catch (const std::exception & e) {
             OUStringBuffer buf;
             buf.appendAscii(RTL_CONSTASCII_STRINGPARAM("C++ code threw "));
             appendCString(buf, typeid(e).name());

bridges/source/cpp_uno/shared/component.cxx

@@ -144,10 +144,10 @@ static void s_stub_computeObjectIdentifier(va_list * pParam)
                 ::rtl_uString_acquire( *ppOId = aRet.pData );
             }
         }
-        catch (::com::sun::star::uno::RuntimeException &)
+        catch (const ::com::sun::star::uno::RuntimeException &)
         {
             OSL_FAIL(
-                "### RuntimeException occurred udring queryInterface()!" );
+                "### RuntimeException occurred during queryInterface()!" );
         }
     }
 }

bridges/source/jni_uno/jni_bridge.cxx

@@ -106,7 +106,7 @@ void SAL_CALL Mapping_map_to_uno(
             }
             *ppUnoI = pUnoI;
         }
-        catch (BridgeRuntimeError & err)
+        catch (const BridgeRuntimeError & err)
         {
 #if OSL_DEBUG_LEVEL > 0
             OString cstr_msg(
@@ -118,7 +118,7 @@ void SAL_CALL Mapping_map_to_uno(
             (void) err; // unused
 #endif
         }
-        catch (::jvmaccess::VirtualMachine::AttachGuard::CreationException &)
+        catch (const ::jvmaccess::VirtualMachine::AttachGuard::CreationException &)
         {
             OSL_FAIL(
                 "[jni_uno bridge error] attaching current thread "
@@ -175,7 +175,7 @@ void SAL_CALL Mapping_map_to_java(
             jni->DeleteLocalRef( jlocal );
         }
     }
-    catch (BridgeRuntimeError & err)
+    catch (const BridgeRuntimeError & err)
     {
 #if OSL_DEBUG_LEVEL > 0
         OString cstr_msg(
@@ -187,7 +187,7 @@ void SAL_CALL Mapping_map_to_java(
             (void) err; // unused
 #endif
     }
-    catch (::jvmaccess::VirtualMachine::AttachGuard::CreationException &)
+    catch (const ::jvmaccess::VirtualMachine::AttachGuard::CreationException &)
     {
         OSL_FAIL(
             "[jni_uno bridge error] attaching current thread to java failed!" );
@@ -537,7 +537,7 @@ void SAL_CALL uno_ext_getMapping(
                     (uno_Environment *)pFrom->pExtEnv, pTo, 0 );
             }
         }
-        catch (BridgeRuntimeError & err)
+        catch (const BridgeRuntimeError & err)
         {
 #if OSL_DEBUG_LEVEL > 0
             OString cstr_msg(
@@ -549,7 +549,7 @@ void SAL_CALL uno_ext_getMapping(
             (void) err; // unused
 #endif
         }
-        catch (::jvmaccess::VirtualMachine::AttachGuard::CreationException &)
+        catch (const ::jvmaccess::VirtualMachine::AttachGuard::CreationException &)
         {
             OSL_FAIL(
                 "[jni_uno bridge error] attaching current thread "

bridges/source/jni_uno/jni_java2uno.cxx

@@ -615,7 +615,7 @@ JNICALL Java_com_sun_star_bridges_jni_1uno_JNI_1proxy_dispatch_1call(
         buf.append( jni.get_stack_trace() );
         throw BridgeRuntimeError( buf.makeStringAndClear() );
     }
-    catch (BridgeRuntimeError & err)
+    catch (const BridgeRuntimeError & err)
     {
         OUStringBuffer buf( 128 );
         buf.appendAscii(
@@ -636,7 +636,7 @@ JNICALL Java_com_sun_star_bridges_jni_1uno_JNI_1proxy_dispatch_1call(
         }
         return 0;
     }
-    catch (::jvmaccess::VirtualMachine::AttachGuard::CreationException &)
+    catch (const ::jvmaccess::VirtualMachine::AttachGuard::CreationException &)
     {
         OString cstr_msg(
             OString( RTL_CONSTASCII_STRINGPARAM(

bridges/source/jni_uno/nativethreadpool.cxx

@@ -84,7 +84,7 @@ static void SAL_CALL executeRequest(void * data) {
         env->CallObjectMethod(job->job, job->pool->execute);
         env->DeleteGlobalRef(job->job);
         delete job;
-    } catch (jvmaccess::VirtualMachine::AttachGuard::CreationException &) {
+    } catch (const jvmaccess::VirtualMachine::AttachGuard::CreationException &) {
         //TODO: DeleteGlobalRef(job->job)
         delete job;
     }
@@ -141,7 +141,7 @@ Java_com_sun_star_lib_uno_environments_remote_NativeThreadPool_create(
         return reinterpret_cast< jlong >(new Pool(
             new jvmaccess::VirtualMachine(vm, env->GetVersion(), false, env),
             execute, uno_threadpool_create()));
-    } catch (std::bad_alloc) {
+    } catch (const std::bad_alloc &) {
         throwOutOfMemory(env);
         return 0;
     }

canvas/source/directx/dx_config.cxx

@@ -89,7 +89,7 @@ namespace dxcanvas
             else
                 maMaxTextureSize.reset();
         }
-        catch( uno::Exception& )
+        catch( const uno::Exception& )
         {
             OSL_FAIL( rtl::OUStringToOString(
                             comphelper::anyToString( cppu::getCaughtException() ),
@@ -130,7 +130,7 @@ namespace dxcanvas
             aValue[0] <<= aValues;
             PutProperties( aName, aValue );
         }
-        catch( uno::Exception& )
+        catch( const uno::Exception& )
         {
             OSL_FAIL( rtl::OUStringToOString(
                             comphelper::anyToString( cppu::getCaughtException() ),

canvas/source/factory/cf_service.cxx

@@ -203,11 +203,11 @@ CanvasFactory::CanvasFactory( Reference<XComponentContext> const & xContext ) :
             ++pCurr;
         }
     }
-    catch (RuntimeException &)
+    catch (const RuntimeException &)
     {
         throw;
     }
-    catch (Exception&)
+    catch (const Exception&)
     {
     }
 
@@ -290,11 +290,11 @@ Reference<XInterface> CanvasFactory::use(
         return m_xContext->getServiceManager()->createInstanceWithArgumentsAndContext(
             serviceName, args, xContext);
     }
-    catch (RuntimeException &)
+    catch (const RuntimeException &)
     {
         throw;
     }
-    catch (Exception &)
+    catch (const Exception &)
     {
         return Reference<XInterface>();
     }

canvas/source/tools/canvastools.cxx

@@ -916,7 +916,7 @@ namespace canvas
                     o_rxParams[ 1 ] = uno::makeAny( xPropSet->getPropertyValue(
                                                         ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM("DeviceHandle") ) ) );
                 }
-                catch( uno::Exception& )
+                catch( const uno::Exception& )
                 {
                     // ignore, but return empty sequence
                 }

canvas/workben/canvasdemo.cxx

@@ -678,7 +678,7 @@ void DemoApp::Main()
         if( xFactory.is() )
             ::comphelper::setProcessServiceFactory( xFactory );
     }
-    catch( uno::Exception& )
+    catch( const uno::Exception& )
     {
     }