Kaydet (Commit) 6084ca8a authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:finalclasses in mysqlc

Change-Id: I3f0ae04c30e863c123404c6e99f7ae27bc5715c7
Reviewed-on: https://gerrit.libreoffice.org/44134Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
Tested-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 7d8d7ebb
......@@ -82,20 +82,15 @@ namespace connectivity
typedef std::vector< css::uno::WeakReferenceHelper > OWeakRefArray;
class OConnection : public OBase_Mutex,
class OConnection final : public OBase_Mutex,
public OConnection_BASE,
public connectivity::mysqlc::OSubComponent<OConnection, OConnection_BASE>
{
friend class connectivity::mysqlc::OSubComponent<OConnection, OConnection_BASE>;
private:
ConnectionSettings m_settings;
private:
css::uno::Reference< css::container::XNameAccess > m_typeMap;
css::uno::Reference< css::util::XStringSubstitution > m_xParameterSubstitution;
protected:
// Data attributes
......
......@@ -39,15 +39,13 @@ namespace connectivity
typedef ::cppu::WeakImplHelper1< css::sdbc::XDatabaseMetaData> ODatabaseMetaData_BASE;
class ODatabaseMetaData : public ODatabaseMetaData_BASE
class ODatabaseMetaData final : public ODatabaseMetaData_BASE
{
OConnection& m_rConnection;
protected:
sql::DatabaseMetaData * meta;
rtl::OUString identifier_quote_string;
bool identifier_quote_string_set;
private:
rtl::OUString impl_getStringMetaData( const sal_Char* _methodName, const sql::SQLString& (sql::DatabaseMetaData::*Method)() );
rtl::OUString impl_getStringMetaData( const sal_Char* _methodName, sql::SQLString (sql::DatabaseMetaData::*Method)() );
sal_Int32 impl_getInt32MetaData( const sal_Char* _methodName, unsigned int (sql::DatabaseMetaData::*Method)() );
......
......@@ -47,16 +47,14 @@ namespace connectivity
css::sdbc::XResultSetMetaDataSupplier,
css::lang::XServiceInfo> OPreparedStatement_BASE;
class OPreparedStatement : public OCommonStatement,
class OPreparedStatement final : public OCommonStatement,
public OPreparedStatement_BASE
{
protected:
unsigned int m_paramCount; // number of placeholders
Reference< XResultSetMetaData > m_xMetaData;
void checkParameterIndex(sal_Int32 parameter);
protected:
void SAL_CALL setFastPropertyValue_NoBroadcast(sal_Int32 nHandle, const Any& rValue) SAL_OVERRIDE;
virtual ~OPreparedStatement();
public:
......
......@@ -63,12 +63,11 @@ namespace connectivity
css::sdbc::XColumnLocate,
css::lang::XServiceInfo> OResultSet_BASE;
class OResultSet : public OBase_Mutex,
class OResultSet final : public OBase_Mutex,
public OResultSet_BASE,
public ::cppu::OPropertySetHelper,
public OPropertyArrayUsageHelper<OResultSet>
{
protected:
css::uno::WeakReferenceHelper m_aStatement;
css::uno::Reference< css::sdbc::XResultSetMetaData> m_xMetaData;
sql::ResultSet *m_result;
......
......@@ -38,11 +38,11 @@ namespace connectivity
typedef ::cppu::WeakImplHelper1< css::sdbc::XResultSetMetaData> OResultSetMetaData_BASE;
class OResultSetMetaData : public OResultSetMetaData_BASE
class OResultSetMetaData final : public OResultSetMetaData_BASE
{
sql::ResultSetMetaData * meta;
rtl_TextEncoding m_encoding;
protected:
virtual ~OResultSetMetaData();
public:
OResultSetMetaData( sql::ResultSetMetaData * _meta, rtl_TextEncoding _encoding )
......
......@@ -150,12 +150,11 @@ namespace connectivity
};
class OStatement : public OCommonStatement,
class OStatement final : public OCommonStatement,
public css::sdbc::XBatchExecution,
public css::lang::XServiceInfo
{
protected:
virtual ~OStatement(){}
public:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment