convert LineType to scoped enum

and remove unused LINE_HORIZONTAL

Change-Id: I39ee05b444b4da46758ff30176e041a02bee54e8
Reviewed-on: https://gerrit.libreoffice.org/63740
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/unusedenumconstants.untouched.results

@@ -538,8 +538,6 @@ ucb/source/ucp/webdav-neon/DAVTypes.hxx:195
     enum webdav_ucp::Depth DAVINFINITY
 ucbhelper/source/client/proxydecider.cxx:119
     enum ucbhelper::proxydecider_impl::InternetProxyDecider_Impl::ProxyType Manual
-vcl/inc/regband.hxx:45
-    enum LineType LINE_HORIZONTAL
 vcl/inc/salptype.hxx:44
     enum SalPrinterError General
 vcl/inc/unx/saldisp.hxx:65

vcl/inc/regband.hxx

@@ -42,7 +42,7 @@ struct ImplRegionBandSep
     bool                        mbRemoved;
 };
 
-enum LineType { LINE_ASCENDING, LINE_DESCENDING, LINE_HORIZONTAL };
+enum class LineType { Ascending, Descending };
 
 // element for the list with x-separations
 struct ImplRegionBandPoint

vcl/source/gdi/region.cxx

@@ -128,7 +128,7 @@ namespace
                 // in other places (but seems to be the wrong way.)
                 const long nTop (::std::min(aStart.Y(), aEnd.Y()));
                 const long nBottom (::std::max(aStart.Y(), aEnd.Y()));
-                const LineType eLineType (aStart.Y() > aEnd.Y() ? LINE_DESCENDING : LINE_ASCENDING);
+                const LineType eLineType (aStart.Y() > aEnd.Y() ? LineType::Descending : LineType::Ascending);
 
                 // Make sure that the current line is covered by bands.
                 pRegionBand->ImplAddMissingBands(nTop,nBottom);

vcl/source/gdi/regionband.cxx

@@ -445,7 +445,7 @@ void RegionBand::InsertLine(const Point& rStartPt, const Point& rEndPt, long nLi
         return;
     }
 
-    LineType eLineType = (rStartPt.Y() > rEndPt.Y()) ? LINE_DESCENDING : LINE_ASCENDING;
+    LineType eLineType = (rStartPt.Y() > rEndPt.Y()) ? LineType::Descending : LineType::Ascending;
     if ( rStartPt.X() == rEndPt.X() )
     {
         // vertical line