Kaydet (Commit) 5262ec68 authored tarafından Caolán McNamara's avatar Caolán McNamara

set copy_paste_error to false rather than intentional

Change-Id: I152482ef594c286d3c2a94cab62feff49bbf79fa
Reviewed-on: https://gerrit.libreoffice.org/58884
Tested-by: Jenkins
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
üst 12ea892d
...@@ -461,7 +461,7 @@ namespace basegfx ...@@ -461,7 +461,7 @@ namespace basegfx
if(!fTools::equalZero(fShearY)) if(!fTools::equalZero(fShearY))
{ {
// coverity[copy_paste_error] - this is correct getZ, not getY // coverity[copy_paste_error : FALSE] - this is correct getZ, not getY
rShear.setY(rShear.getY() / rScale.getZ()); rShear.setY(rShear.getY() / rScale.getZ());
} }
......
...@@ -2115,7 +2115,7 @@ at_least_one_scoped_name : ...@@ -2115,7 +2115,7 @@ at_least_one_scoped_name :
} else } else
{ {
std::list< OString >* pScopedNames = new std::list< OString >; std::list< OString >* pScopedNames = new std::list< OString >;
// coverity[copy_paste_error] - this is not a cut and paste // coverity[copy_paste_error : FALSE] - this is not a cut and paste
pScopedNames->push_back(*$1); pScopedNames->push_back(*$1);
$$ = pScopedNames; $$ = pScopedNames;
} }
......
...@@ -2736,7 +2736,7 @@ bool ScDPGroupCompare::TestIncluded( const ScDPMember& rMember ) ...@@ -2736,7 +2736,7 @@ bool ScDPGroupCompare::TestIncluded( const ScDPMember& rMember )
{ {
if (pResultData->GetGroupBase(it->mnSrcIndex) == nGroupBase) if (pResultData->GetGroupBase(it->mnSrcIndex) == nGroupBase)
{ {
// coverity[copy_paste_error] - same base (hierarchy between // coverity[copy_paste_error : FALSE] - same base (hierarchy between
// the two groups is irrelevant) // the two groups is irrelevant)
bInclude = pResultData->HasCommonElement( bInclude = pResultData->HasCommonElement(
it->mnNameIndex, it->mnSrcIndex, aMemberData, nDimSource); it->mnNameIndex, it->mnSrcIndex, aMemberData, nDimSource);
......
...@@ -5702,7 +5702,7 @@ bool ScCompiler::HandleTableRef() ...@@ -5702,7 +5702,7 @@ bool ScCompiler::HandleTableRef()
default: default:
; // nothing ; // nothing
} }
// coverity[copy_paste_error] - this is correct, aStart in both aDBRange uses // coverity[copy_paste_error : FALSE] - this is correct, aStart in both aDBRange uses
if (aColRange.aStart.Row() != aDBRange.aStart.Row() || aColRange.aEnd.Row() != aDBRange.aStart.Row()) if (aColRange.aStart.Row() != aDBRange.aStart.Row() || aColRange.aEnd.Row() != aDBRange.aStart.Row())
aRange = ScRange( ScAddress::INITIALIZE_INVALID); aRange = ScRange( ScAddress::INITIALIZE_INVALID);
else else
......
...@@ -179,7 +179,7 @@ ScPositionHelper::getNearestByIndex(index_type nIndex) const ...@@ -179,7 +179,7 @@ ScPositionHelper::getNearestByIndex(index_type nIndex) const
} }
auto posLB = std::prev(posUB); auto posLB = std::prev(posUB);
// coverity[copy_paste_error] - posUB is correct // coverity[copy_paste_error : FALSE] - posUB is correct
if (posUB == mData.end()) if (posUB == mData.end())
{ {
return *posLB; return *posLB;
...@@ -210,7 +210,7 @@ ScPositionHelper::getNearestByPosition(long nPos) const ...@@ -210,7 +210,7 @@ ScPositionHelper::getNearestByPosition(long nPos) const
} }
auto posLB = std::prev(posUB); auto posLB = std::prev(posUB);
// coverity[copy_paste_error] - posUB is correct // coverity[copy_paste_error : FALSE] - posUB is correct
if (posUB == mData.end()) if (posUB == mData.end())
{ {
return *posLB; return *posLB;
......
...@@ -2343,7 +2343,7 @@ void CustomAnimationPane::moveSelection( bool bUp ) ...@@ -2343,7 +2343,7 @@ void CustomAnimationPane::moveSelection( bool bUp )
CustomAnimationEffectPtr pEffect = (*aIter++); CustomAnimationEffectPtr pEffect = (*aIter++);
EffectSequence::iterator aUpEffectPos( pSequence->find( pEffect ) ); EffectSequence::iterator aUpEffectPos( pSequence->find( pEffect ) );
// coverity[copy_paste_error] - this is correct, checking if it exists // coverity[copy_paste_error : FALSE] - this is correct, checking if it exists
if( aUpEffectPos != rEffectSequence.end() ) if( aUpEffectPos != rEffectSequence.end() )
{ {
EffectSequence::iterator aInsertPos( rEffectSequence.erase( aUpEffectPos ) ); EffectSequence::iterator aInsertPos( rEffectSequence.erase( aUpEffectPos ) );
...@@ -2374,7 +2374,7 @@ void CustomAnimationPane::moveSelection( bool bUp ) ...@@ -2374,7 +2374,7 @@ void CustomAnimationPane::moveSelection( bool bUp )
CustomAnimationEffectPtr pEffect = (*aIter++); CustomAnimationEffectPtr pEffect = (*aIter++);
EffectSequence::iterator aDownEffectPos( pSequence->find( pEffect ) ); EffectSequence::iterator aDownEffectPos( pSequence->find( pEffect ) );
// coverity[copy_paste_error] - this is correct, checking if it exists // coverity[copy_paste_error : FALSE] - this is correct, checking if it exists
if( aDownEffectPos != rEffectSequence.end() ) if( aDownEffectPos != rEffectSequence.end() )
{ {
EffectSequence::iterator aInsertPos( rEffectSequence.erase( aDownEffectPos ) ); EffectSequence::iterator aInsertPos( rEffectSequence.erase( aDownEffectPos ) );
......
...@@ -1601,10 +1601,12 @@ private: ...@@ -1601,10 +1601,12 @@ private:
Size aPaperSize( rInfo.mpPrinter->PixelToLogic( rInfo.mpPrinter->GetPaperSizePixel(), MapMode( MapUnit::Map100thMM ) ) ); Size aPaperSize( rInfo.mpPrinter->PixelToLogic( rInfo.mpPrinter->GetPaperSizePixel(), MapMode( MapUnit::Map100thMM ) ) );
maPrintSize.Width = aPaperSize.Height(); maPrintSize.Width = aPaperSize.Height();
maPrintSize.Height = aPaperSize.Width(); maPrintSize.Height = aPaperSize.Width();
const long nRotatedWidth = aOutRect.GetHeight(); const auto nRotatedWidth = aOutRect.GetHeight();
const long nRotatedHeight = aOutRect.GetWidth(); const auto nRotatedHeight = aOutRect.GetWidth();
aOutRect = ::tools::Rectangle( Point( aPageOfs.Y(), aPageOfs.X() ), const auto nRotatedX = aPageOfs.Y();
Size( nRotatedWidth, nRotatedHeight ) ); const auto nRotatedY = aPageOfs.X();
aOutRect = ::tools::Rectangle(Point( nRotatedX, nRotatedY),
Size(nRotatedWidth, nRotatedHeight));
} }
Outliner* pOutliner = mrBase.GetDocument()->GetInternalOutliner(); Outliner* pOutliner = mrBase.GetDocument()->GetInternalOutliner();
......
...@@ -572,7 +572,7 @@ tools::Polygon XOutBitmap::GetContour( const Bitmap& rBmp, const XOutFlags nFlag ...@@ -572,7 +572,7 @@ tools::Polygon XOutBitmap::GetContour( const Bitmap& rBmp, const XOutFlags nFlag
// this loop always breaks eventually as there is at least one pixel // this loop always breaks eventually as there is at least one pixel
while( true ) while( true )
{ {
// coverity[copy_paste_error] - this is correct nX, not nY // coverity[copy_paste_error : FALSE] - this is correct nX, not nY
if( aBlack == pAcc->GetPixelFromData( pScanline, nX ) ) if( aBlack == pAcc->GetPixelFromData( pScanline, nX ) )
{ {
pPoints2[ nPolyPos ] = Point( nX, nY ); pPoints2[ nPolyPos ] = Point( nX, nY );
......
...@@ -6288,7 +6288,7 @@ void PDFWriterImpl::drawRelief( SalLayout& rLayout, const OUString& rText, bool ...@@ -6288,7 +6288,7 @@ void PDFWriterImpl::drawRelief( SalLayout& rLayout, const OUString& rText, bool
aTextLineColor = COL_WHITE; aTextLineColor = COL_WHITE;
if( aOverlineColor == COL_BLACK ) if( aOverlineColor == COL_BLACK )
aOverlineColor = COL_WHITE; aOverlineColor = COL_WHITE;
// coverity[copy_paste_error] - aReliefColor depending on aTextColor is correct // coverity[copy_paste_error : FALSE] - aReliefColor depending on aTextColor is correct
if( aTextColor == COL_WHITE ) if( aTextColor == COL_WHITE )
aReliefColor = COL_BLACK; aReliefColor = COL_BLACK;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment