loplugin:constfields in svl

Change-Id: I18183c5c257cbe69bd067d4e74c50483ae683cf3
Reviewed-on: https://gerrit.libreoffice.org/61509
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

svl/qa/unit/svl.cxx

@@ -233,9 +233,9 @@ void Test::testNumberFormat()
     };
 
     struct {
-        NfIndexTableOffset eStart;
-        NfIndexTableOffset eEnd;
-        size_t nSize;
+        NfIndexTableOffset const eStart;
+        NfIndexTableOffset const eEnd;
+        size_t const nSize;
         const char** pCodes;
     } aTests[] = {
         { NF_NUMBER_START, NF_NUMBER_END, 6, pNumber },
@@ -1101,7 +1101,7 @@ void Test::testIsNumberFormat()
     struct NumberFormatData
     {
         const char* pFormat;
-        bool bIsNumber;
+        bool const bIsNumber;
     } aTests[] = {
         { "20.3", true },
         { "2", true },

svl/source/crypto/cryptosign.cxx

@@ -118,9 +118,9 @@ Extension  ::=  SEQUENCE  {
 */
 
 typedef struct {
-    SECItem extnID;
-    SECItem critical;
-    SECItem extnValue;
+    SECItem const extnID;
+    SECItem const critical;
+    SECItem const extnValue;
 } Extension;
 
 /*

svl/source/fsstor/fsstorage.cxx

@@ -67,10 +67,10 @@ using namespace ::com::sun::star;
 
 struct FSStorage_Impl
 {
-    OUString m_aURL;
+    OUString const m_aURL;
 
     ::ucbhelper::Content m_aContent;
-    sal_Int32 m_nMode;
+    sal_Int32 const m_nMode;
 
     std::unique_ptr<::comphelper::OInterfaceContainerHelper2> m_pListenersContainer; // list of listeners
     std::unique_ptr<::cppu::OTypeCollection> m_pTypeCollection;

svl/source/items/style.cxx

@@ -388,7 +388,7 @@ struct DoesStyleMatchStyleSheetPredicate final : public svl::StyleSheetPredicate
         return bMatches;
     }
 
-    SfxStyleSheetIterator *mIterator;
+    SfxStyleSheetIterator * const mIterator;
 };
 
 }

svl/source/misc/gridprinter.cxx

@@ -51,7 +51,7 @@ typedef mdds::multi_type_matrix<matrix_trait> MatrixImplType;
 struct GridPrinter::Impl
 {
     MatrixImplType maMatrix;
-    bool mbPrint;
+    bool const mbPrint;
 
     Impl( size_t nRows, size_t nCols, bool bPrint ) :
         maMatrix(nRows, nCols, OUString()), mbPrint(bPrint) {}

svl/source/undo/undo.cxx

@@ -1298,11 +1298,11 @@ void SfxUndoManager::EmptyActionsChanged()
 
 struct SfxListUndoAction::Impl
 {
-    sal_uInt16 mnId;
-    ViewShellId mnViewShellId;
+    sal_uInt16 const mnId;
+    ViewShellId const mnViewShellId;
 
     OUString maComment;
-    OUString maRepeatComment;
+    OUString const maRepeatComment;
 
     Impl( sal_uInt16 nId, ViewShellId nViewShellId, const OUString& rComment, const OUString& rRepeatComment ) :
         mnId(nId), mnViewShellId(nViewShellId), maComment(rComment), maRepeatComment(rRepeatComment) {}

svl/source/uno/pathservice.cxx

@@ -33,7 +33,7 @@ namespace com { namespace sun { namespace star { namespace uno {
 
 class PathService : public ::cppu::WeakImplHelper< css::frame::XConfigManager, css::lang::XServiceInfo >
 {
-    SvtPathOptions m_aOptions;
+    SvtPathOptions const m_aOptions;
 
 public:
     PathService()