loplugin:countusersofdefaultparams in sc(part1)

Change-Id: Ia2b0174654fad536ee23f6174a0b38b1843a4aa5
Reviewed-on: https://gerrit.libreoffice.org/30427Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

sc/qa/unit/helper/csv_handler.hxx

@@ -83,7 +83,7 @@ OString createErrorMessage(SCCOL nCol, SCROW nRow, SCTAB nTab, double aExpected,
 class csv_handler
 {
 public:
-    csv_handler(ScDocument* pDoc, SCTAB nTab, StringType eType = StringValue):
+    csv_handler(ScDocument* pDoc, SCTAB nTab, StringType eType):
             mpDoc(pDoc),
             mnCol(0),
             mnRow(0),

sc/source/core/inc/cellkeytranslator.hxx

@@ -63,7 +63,7 @@ typedef std::unordered_map< OUString, ::std::list<ScCellKeyword>, OUStringHash >
 class ScCellKeywordTranslator
 {
 public:
-    static void transKeyword(OUString& rName, const css::lang::Locale* pLocale, OpCode eOpCode = ocNone);
+    static void transKeyword(OUString& rName, const css::lang::Locale* pLocale, OpCode eOpCode);
     ~ScCellKeywordTranslator();
 
 private:

sc/source/core/tool/address.cxx

@@ -1446,9 +1446,9 @@ static ScRefFlags lcl_ScAddress_Parse_OOo( const sal_Unicode* p, ScDocument* pDo
 static ScRefFlags lcl_ScAddress_Parse ( const sal_Unicode* p, ScDocument* pDoc, ScAddress& rAddr,
                                         const ScAddress::Details& rDetails,
                                         ScAddress::ExternalInfo* pExtInfo,
-                                        const uno::Sequence<sheet::ExternalLinkInfo>* pExternalLinks = nullptr,
-                                        sal_Int32* pSheetEndPos = nullptr,
-                                        const OUString* pErrRef = nullptr )
+                                        const uno::Sequence<sheet::ExternalLinkInfo>* pExternalLinks,
+                                        sal_Int32* pSheetEndPos,
+                                        const OUString* pErrRef )
 {
     if( !*p )
         return ScRefFlags::ZERO;

sc/source/core/tool/cellkeytranslator.cxx

@@ -76,7 +76,7 @@ ScCellKeyword::ScCellKeyword(const sal_Char* pName, OpCode eOpCode, const lang::
 ::std::unique_ptr<ScCellKeywordTranslator> ScCellKeywordTranslator::spInstance;
 
 static void lclMatchKeyword(OUString& rName, const ScCellKeywordHashMap& aMap,
-                            OpCode eOpCode, const lang::Locale* pLocale = nullptr)
+                            OpCode eOpCode, const lang::Locale* pLocale)
 {
     ScCellKeywordHashMap::const_iterator itrEnd = aMap.end();
     ScCellKeywordHashMap::const_iterator itr = aMap.find(rName);

sc/source/core/tool/compiler.cxx

@@ -480,7 +480,7 @@ static bool lcl_parseExternalName(
         OUString& rName,
         const sal_Unicode cSep,
         const ScDocument* pDoc,
-        const uno::Sequence<sheet::ExternalLinkInfo>* pExternalLinks = nullptr )
+        const uno::Sequence<sheet::ExternalLinkInfo>* pExternalLinks )
 {
     /* TODO: future versions will have to support sheet-local names too, thus
      * return a possible sheet name as well. */

sc/source/filter/excel/xecontent.cxx

@@ -61,7 +61,7 @@ struct XclExpHashEntry
 {
     const XclExpString* mpString;       /// Pointer to the string (no ownership).
     sal_uInt32          mnSstIndex;     /// The SST index of this string.
-    inline explicit     XclExpHashEntry( const XclExpString* pString = nullptr, sal_uInt32 nSstIndex = 0 ) :
+    inline explicit     XclExpHashEntry( const XclExpString* pString, sal_uInt32 nSstIndex ) :
                             mpString( pString ), mnSstIndex( nSstIndex ) {}
 };
 
@@ -568,7 +568,7 @@ void XclExpLabelranges::Save( XclExpStream& rStrm )
 class XclExpCFImpl : protected XclExpRoot
 {
 public:
-    explicit            XclExpCFImpl( const XclExpRoot& rRoot, const ScCondFormatEntry& rFormatEntry, sal_Int32 nPriority = 0 );
+    explicit            XclExpCFImpl( const XclExpRoot& rRoot, const ScCondFormatEntry& rFormatEntry, sal_Int32 nPriority );
 
     /** Writes the body of the CF record. */
     void                WriteBody( XclExpStream& rStrm );

sc/source/filter/inc/drawingfragment.hxx

@@ -61,7 +61,7 @@ public:
     explicit            Shape(
                             const WorksheetHelper& rHelper,
                             const AttributeList& rAttribs,
-                            const sal_Char* pcServiceName = nullptr );
+                            const sal_Char* pcServiceName );
 
 protected:
     virtual void        finalizeXShape(

sc/source/filter/inc/stylesbuffer.hxx

@@ -864,12 +864,12 @@ public:
     /** Creates the style sheet described by the DXF with the passed identifier. */
     OUString     createDxfStyle( sal_Int32 nDxfId ) const;
 
-    void                writeFontToItemSet( SfxItemSet& rItemSet, sal_Int32 nFontId, bool bSkipPoolDefs = false ) const;
-    sal_uLong           writeNumFmtToItemSet( SfxItemSet& rItemSet, sal_Int32 nNumFmtId, bool bSkipPoolDefs = false ) const;
+    void                writeFontToItemSet( SfxItemSet& rItemSet, sal_Int32 nFontId, bool bSkipPoolDefs ) const;
+    sal_uLong           writeNumFmtToItemSet( SfxItemSet& rItemSet, sal_Int32 nNumFmtId, bool bSkipPoolDefs ) const;
     /** Writes the specified number format to the passed property map. */
-    void                writeBorderToItemSet( SfxItemSet& rItemSet, sal_Int32 nBorderId, bool bSkipPoolDefs = false ) const;
+    void                writeBorderToItemSet( SfxItemSet& rItemSet, sal_Int32 nBorderId, bool bSkipPoolDefs ) const;
     /** Writes the fill attributes of the specified fill data to the passed property map. */
-    void                writeFillToItemSet( SfxItemSet& rItemSet, sal_Int32 nFillId, bool bSkipPoolDefs = false ) const;
+    void                writeFillToItemSet( SfxItemSet& rItemSet, sal_Int32 nFillId, bool bSkipPoolDefs ) const;
 
     /** Writes the cell formatting attributes of the specified XF to the passed property set. */
     void                writeCellXfToDoc( ScDocumentImport& rDoc, const css::table::CellRangeAddress& rRange, sal_Int32 nXfId ) const;

sc/source/filter/inc/workbookhelper.hxx

@@ -180,7 +180,7 @@ public:
                             OUString& orName,
                             const css::uno::Sequence< css::sheet::FormulaToken>& rTokens,
                             sal_Int32 nIndex,
-                            sal_Int32 nNameFlags, sal_Int32 nTab = -1 ) const;
+                            sal_Int32 nNameFlags, sal_Int32 nTab ) const;
 
     /** Creates and returns a database range on-the-fly in the Calc document.
         The range will not be buffered in the global table buffer.

sc/source/filter/inc/xcl97rec.hxx

@@ -199,7 +199,7 @@ class SdrTextObj;
 class XclTxo : public ExcRecord
 {
 public:
-                                XclTxo( const OUString& rString, sal_uInt16 nFontIx = EXC_FONT_APP );
+                                XclTxo( const OUString& rString, sal_uInt16 nFontIx );
                                 XclTxo( const XclExpRoot& rRoot, const SdrTextObj& rEditObj );
                                 XclTxo( const XclExpRoot& rRoot, const EditTextObject& rEditObj, SdrObject* pCaption );
 

sc/source/filter/inc/xechart.hxx

@@ -190,7 +190,7 @@ class XclExpChFutureRecordBase : public XclExpFutureRecord, protected XclExpChRo
 {
 public:
     explicit            XclExpChFutureRecordBase( const XclExpChRoot& rRoot,
-                            XclFutureRecType eRecType, sal_uInt16 nRecId, std::size_t nRecSize = 0 );
+                            XclFutureRecType eRecType, sal_uInt16 nRecId, std::size_t nRecSize );
 
     /** Writes missing CHFRBLOCKBEGIN records and this record. */
     virtual void        Save( XclExpStream& rStrm ) override;

sc/source/filter/inc/xerecord.hxx

@@ -274,7 +274,7 @@ class XclExpFutureRecord : public XclExpRecord
 {
 public:
     explicit            XclExpFutureRecord( XclFutureRecType eRecType,
-                            sal_uInt16 nRecId, std::size_t nRecSize = 0 );
+                            sal_uInt16 nRecId, std::size_t nRecSize );
 
     /** Writes the extended record header and calls WriteBody(). */
     virtual void        Save( XclExpStream& rStrm ) override;

sc/source/filter/inc/xestyle.hxx

@@ -546,7 +546,7 @@ class XclExpStyle : public XclExpRecord
 {
 public:
     explicit            XclExpStyle( sal_uInt32 nXFId, const OUString& rStyleName );
-    explicit            XclExpStyle( sal_uInt32 nXFId, sal_uInt8 nStyleId, sal_uInt8 nLevel = EXC_STYLE_NOLEVEL );
+    explicit            XclExpStyle( sal_uInt32 nXFId, sal_uInt8 nStyleId, sal_uInt8 nLevel );
 
     /** Returns true, if this record represents an Excel built-in style. */
     inline bool         IsBuiltIn() const { return mnStyleId != EXC_STYLE_USERDEF; }

sc/source/filter/oox/stylesbuffer.cxx

@@ -2043,7 +2043,7 @@ void Xf::applyPatternToAttrList( AttrList& rAttrs, SCROW nRow1, SCROW nRow2, sal
     if ( nNumFmtId >= 0 )
     {
         ScPatternAttr aNumPat(rDoc.GetPool());
-        mnScNumFmt = getStyles().writeNumFmtToItemSet( aNumPat.GetItemSet(), nNumFmtId );
+        mnScNumFmt = getStyles().writeNumFmtToItemSet( aNumPat.GetItemSet(), nNumFmtId, false );
         rPat.GetItemSet().Put(aNumPat.GetItemSet());
     }
 

sc/source/filter/starcalc/collect.hxx

@@ -38,7 +38,7 @@ protected:
     sal_uInt16          nDelta;
     ScDataObject**     pItems;
 public:
-    ScCollection(sal_uInt16 nLim = 4, sal_uInt16 nDel = 4);
+    ScCollection(sal_uInt16 nLim, sal_uInt16 nDel);
     ScCollection(const ScCollection& rCollection);
     virtual                 ~ScCollection() override;
 

sc/source/filter/xml/xmlstyle.hxx

@@ -217,7 +217,7 @@ public:
     ScXMLStyleExport(
         SvXMLExport& rExp,
         const OUString& rPoolStyleName,
-        SvXMLAutoStylePoolP *pAutoStyleP=nullptr );
+        SvXMLAutoStylePoolP *pAutoStyleP );
     virtual ~ScXMLStyleExport() override;
 };
 

sc/source/ui/inc/anyrefdg.hxx

@@ -175,10 +175,10 @@ private:
         TParentWindow* pParent, const OUString& rID, const OUString& rUIXMLDescription );
 
     template<class TParentWindow, class TResId, class TArg>
-    ScRefHdlrImplBase( TParentWindow* pParent, TResId nResId, const TArg &rArg, SfxBindings *pB = nullptr );
+    ScRefHdlrImplBase( TParentWindow* pParent, TResId nResId, const TArg &rArg, SfxBindings *pB );
 
     template<class TParentWindow, class TArg>
-    ScRefHdlrImplBase( TParentWindow* pParent, const OUString& rID, const OUString& rUIXMLDescription, const TArg &rArg, SfxBindings *pB = nullptr );
+    ScRefHdlrImplBase( TParentWindow* pParent, const OUString& rID, const OUString& rUIXMLDescription, const TArg &rArg, SfxBindings *pB );
 
     virtual ~ScRefHdlrImplBase() override;
 

sc/source/ui/inc/corodlg.hxx

@@ -27,8 +27,8 @@ class ScColRowLabelDlg : public ModalDialog
 {
 public:
     ScColRowLabelDlg(vcl::Window* pParent,
-                     bool bCol = false,
-                     bool bRow = false)
+                     bool bCol,
+                     bool bRow)
         : ModalDialog(pParent, "ChangeSourceDialog",
         "modules/scalc/ui/changesourcedialog.ui")
     {

sc/source/ui/inc/delcldlg.hxx

@@ -35,7 +35,7 @@ private:
     VclPtr<RadioButton> m_pBtnDelCols;
 
 public:
-    ScDeleteCellDlg(vcl::Window* pParent, bool bDisallowCellMove = false);
+    ScDeleteCellDlg(vcl::Window* pParent, bool bDisallowCellMove);
     virtual ~ScDeleteCellDlg() override;
     virtual void dispose() override;
 

sc/source/ui/inc/delcodlg.hxx

@@ -47,7 +47,7 @@ private:
 
 public:
             ScDeleteContentsDlg( vcl::Window* pParent,
-                                 InsertDeleteFlags nCheckDefaults = InsertDeleteFlags::NONE );
+                                 InsertDeleteFlags nCheckDefaults );
             virtual ~ScDeleteContentsDlg() override;
     virtual void dispose() override;
     void    DisableObjects();

sc/source/ui/inc/groupdlg.hxx

@@ -27,7 +27,7 @@
 class ScGroupDlg : public ModalDialog
 {
 public:
-    ScGroupDlg(vcl::Window* pParent, bool bUnGroup = false, bool bRows = true);
+    ScGroupDlg(vcl::Window* pParent, bool bUnGroup, bool bRows);
     virtual ~ScGroupDlg() override;
     virtual void dispose() override;
     bool GetColsChecked() const;

sc/source/ui/inc/inscldlg.hxx

@@ -35,8 +35,8 @@ private:
     VclPtr<RadioButton> m_pBtnInsCol;
 
 public:
-            ScInsertCellDlg( vcl::Window* pParent,bool bDisallowCellMove = false );
-            virtual ~ScInsertCellDlg() override;
+            ScInsertCellDlg( vcl::Window* pParent, bool bDisallowCellMove );
+    virtual ~ScInsertCellDlg() override;
     virtual void dispose() override;
 
     InsCellCmd GetInsCellCmd() const;

sc/source/ui/inc/inscodlg.hxx

@@ -30,10 +30,10 @@
 class ScInsertContentsDlg : public ModalDialog
 {
 public:
-            ScInsertContentsDlg( vcl::Window*          pParent,
-                                 InsertDeleteFlags nCheckDefaults = InsertDeleteFlags::NONE,
-                                 const OUString*  pStrTitle = nullptr );
-            virtual ~ScInsertContentsDlg() override;
+            ScInsertContentsDlg( vcl::Window*      pParent,
+                                 InsertDeleteFlags nCheckDefaults,
+                                 const OUString*   pStrTitle );
+    virtual ~ScInsertContentsDlg() override;
     virtual void dispose() override;
 
     InsertDeleteFlags GetInsContentsCmdBits() const;

sc/source/ui/inc/mtrindlg.hxx

@@ -28,16 +28,16 @@
 class ScMetricInputDlg : public ModalDialog
 {
 public:
-    ScMetricInputDlg( vcl::Window*        pParent,
+    ScMetricInputDlg( vcl::Window*   pParent,
                       const OString& sDialogName,
                       long           nCurrent,
                       long           nDefault,
-                      FieldUnit      eFUnit    = FUNIT_MM,
-                      sal_uInt16     nDecimals = 2,
-                      long           nMaximum  = 1000,
-                      long           nMinimum  = 0,
-                      long           nFirst    = 1,
-                      long           nLast     = 100 );
+                      FieldUnit      eFUnit,
+                      sal_uInt16     nDecimals,
+                      long           nMaximum,
+                      long           nMinimum,
+                      long           nFirst,
+                      long           nLast );
     virtual ~ScMetricInputDlg() override;
     virtual void dispose() override;
 

sc/source/ui/inc/namepast.hxx

@@ -49,7 +49,7 @@ private:
     std::map<OUString, std::unique_ptr<ScRangeName>> m_RangeMap;
 
 public:
-    ScNamePasteDlg( vcl::Window * pParent, ScDocShell* pShell, bool bInsList=true );
+    ScNamePasteDlg( vcl::Window * pParent, ScDocShell* pShell, bool bInsList );
 
     virtual ~ScNamePasteDlg() override;
     virtual void dispose() override;

sc/source/ui/inc/redcom.hxx

@@ -48,7 +48,7 @@ protected:
 public:
 
     ScRedComDialog( vcl::Window* pParent, const SfxItemSet& rCoreSet,
-                    ScDocShell *pShell, ScChangeAction *pAction, bool bPrevNext = false);
+                    ScDocShell *pShell, ScChangeAction *pAction, bool bPrevNext);
     ~ScRedComDialog();
 
     void Execute();

sc/source/ui/inc/scendlg.hxx

@@ -32,7 +32,7 @@ enum class ScScenarioFlags;
 class ScNewScenarioDlg : public ModalDialog
 {
 public:
-    ScNewScenarioDlg(vcl::Window* pParent, const OUString& rName, bool bEdit = false, bool bSheetProtected = false);
+    ScNewScenarioDlg(vcl::Window* pParent, const OUString& rName, bool bEdit, bool bSheetProtected);
     virtual ~ScNewScenarioDlg() override;
     virtual void dispose() override;
     void SetScenarioData( const OUString& rName, const OUString& rComment,

sc/source/ui/inc/scuiimoptdlg.hxx

@@ -28,13 +28,13 @@ class ScDelimiterTable;
 class ScImportOptionsDlg : public ModalDialog
 {
 public:
-    ScImportOptionsDlg( vcl::Window*                 pParent,
-                        bool                    bAscii = true,
-                        const ScImportOptions*  pOptions = nullptr,
-                        const OUString*         pStrTitle = nullptr,
-                        bool                    bMultiByte = false,
-                        bool                    bOnlyDbtoolsEncodings = false,
-                        bool                    bImport = true );
+    ScImportOptionsDlg( vcl::Window*            pParent,
+                        bool                    bAscii,
+                        const ScImportOptions*  pOptions,
+                        const OUString*         pStrTitle,
+                        bool                    bMultiByte,
+                        bool                    bOnlyDbtoolsEncodings,
+                        bool                    bImport );
 
     virtual ~ScImportOptionsDlg() override;
     virtual void dispose() override;

sc/source/ui/inc/undocell.hxx

@@ -94,7 +94,7 @@ public:
 
     ScUndoEnterData(
         ScDocShell* pNewDocShell, const ScAddress& rPos,
-        ValuesType& rOldValues, const OUString& rNewStr, EditTextObject* pObj = nullptr );
+        ValuesType& rOldValues, const OUString& rNewStr, EditTextObject* pObj );
 
     virtual ~ScUndoEnterData() override;
 
@@ -331,7 +331,7 @@ class ScUndoRangeNames: public ScSimpleUndo
 public:
                     //use nTab = -1 for global range names
                     ScUndoRangeNames( ScDocShell* pNewDocShell,
-                                        ScRangeName* pOld, ScRangeName* pNew , SCTAB nTab = -1);
+                                      ScRangeName* pOld, ScRangeName* pNew , SCTAB nTab);
     virtual         ~ScUndoRangeNames() override;
 
     virtual void    Undo() override;

sc/source/ui/view/gridwin.cxx

@@ -326,7 +326,7 @@ void ScFilterListBox::SelectHdl()
 class ScFilterFloatingWindow : public FloatingWindow
 {
 public:
-    ScFilterFloatingWindow( vcl::Window* pParent, WinBits nStyle = WB_STDFLOATWIN );
+    ScFilterFloatingWindow( vcl::Window* pParent, WinBits nStyle );
     virtual ~ScFilterFloatingWindow() override;
     virtual void dispose() override;
 };

scripting/source/basprov/baslibnode.hxx

@@ -56,7 +56,7 @@ namespace basprov
         const OUString& sScriptingContext,
             BasicManager* pBasicManager,
             const css::uno::Reference< css::script::XLibraryContainer >& xLibContainer,
-            const OUString& sLibName, bool isAppScript=true );
+            const OUString& sLibName, bool isAppScript );
         virtual ~BasicLibraryNodeImpl() override;
 
         // XBrowseNode

scripting/source/basprov/basmethnode.hxx

@@ -71,7 +71,7 @@ namespace basprov
     public:
         BasicMethodNodeImpl( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
             const OUString& sScriptingContext,
-            SbMethod* pMethod, bool isAppScript = true );
+            SbMethod* pMethod, bool isAppScript );
         virtual ~BasicMethodNodeImpl() override;
 
         // XInterface

scripting/source/basprov/basmodnode.hxx

@@ -50,7 +50,7 @@ namespace basprov
     public:
         BasicModuleNodeImpl( const css::uno::Reference< css::uno::XComponentContext >& rxContext,
             const OUString& sScriptingContext,
-            SbModule* pModule, bool isAppScript = true );
+            SbModule* pModule, bool isAppScript );
         virtual ~BasicModuleNodeImpl() override;
 
         // XBrowseNode