loplugin:constparams in canvas

Change-Id: Id54bb9dca606dd91e2d3ad4b63b9af7593c601e0
Reviewed-on: https://gerrit.libreoffice.org/40202Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

canvas/source/cairo/cairo_canvashelper.cxx

@@ -344,7 +344,7 @@ namespace cairocanvas
         return nTemp;
     }
 
-    static bool readAlpha( BitmapReadAccess* pAlphaReadAcc, long nY, const long nWidth, unsigned char* data, long nOff )
+    static bool readAlpha( BitmapReadAccess const * pAlphaReadAcc, long nY, const long nWidth, unsigned char* data, long nOff )
     {
         bool bIsAlpha = false;
         long nX;
@@ -703,7 +703,7 @@ namespace cairocanvas
         return uno::Sequence<double>();
     }
 
-    static cairo_pattern_t* patternFromParametricPolyPolygon( ::canvas::ParametricPolyPolygon& rPolygon )
+    static cairo_pattern_t* patternFromParametricPolyPolygon( ::canvas::ParametricPolyPolygon const & rPolygon )
     {
         cairo_pattern_t* pPattern = nullptr;
         const ::canvas::ParametricPolyPolygon::Values aValues = rPolygon.getValues();

canvas/source/cairo/cairo_canvashelper.hxx

@@ -269,7 +269,7 @@ namespace cairocanvas
         ::cairo::SurfaceSharedPtr   mpSurface;
         ::basegfx::B2ISize maSize;
 
-        void clip_cairo_from_dev(::OutputDevice& rOutDev);
+        void clip_cairo_from_dev(::OutputDevice const & rOutDev);
 
     };
 

canvas/source/cairo/cairo_canvashelper_text.cxx

@@ -54,7 +54,7 @@ namespace cairocanvas
     }
 
     static bool
-    setupFontTransform( ::OutputDevice&                 rOutDev,
+    setupFontTransform( ::OutputDevice const &          rOutDev,
                         ::Point&                        o_rPoint,
                         vcl::Font&                      io_rVCLFont,
                         const rendering::ViewState&     rViewState,
@@ -202,7 +202,7 @@ namespace cairocanvas
     }
 
     //set the clip of the rOutDev to the cairo surface
-    void CanvasHelper::clip_cairo_from_dev(::OutputDevice& rOutDev)
+    void CanvasHelper::clip_cairo_from_dev(::OutputDevice const & rOutDev)
     {
         vcl::Region aRegion(rOutDev.GetClipRegion());
         if (!aRegion.IsEmpty() && !aRegion.IsNull())

canvas/source/cairo/cairo_devicehelper.cxx

@@ -258,7 +258,7 @@ namespace cairocanvas
         return SurfaceSharedPtr();
     }
 
-    SurfaceSharedPtr DeviceHelper::createSurface( BitmapSystemData& rData, const Size& rSize )
+    SurfaceSharedPtr DeviceHelper::createSurface( BitmapSystemData const & rData, const Size& rSize )
     {
         if (mpRefDevice)
             return mpRefDevice->CreateBitmapSurface(rData, rSize);

canvas/source/cairo/cairo_devicehelper.hxx

@@ -93,7 +93,7 @@ namespace cairocanvas
         OutputDevice* getOutputDevice() const { return mpRefDevice; }
         const ::cairo::SurfaceSharedPtr& getSurface() { return mpSurface; }
         ::cairo::SurfaceSharedPtr createSurface( const ::basegfx::B2ISize& rSize, int aContent );
-        ::cairo::SurfaceSharedPtr createSurface( BitmapSystemData& rData, const Size& rSize );
+        ::cairo::SurfaceSharedPtr createSurface( BitmapSystemData const & rData, const Size& rSize );
 
     protected:
         /** init helper

canvas/source/cairo/cairo_spritedevicehelper.cxx

@@ -137,7 +137,7 @@ namespace cairocanvas
         return SurfaceSharedPtr();
     }
 
-    SurfaceSharedPtr SpriteDeviceHelper::createSurface( BitmapSystemData& rData, const Size& rSize )
+    SurfaceSharedPtr SpriteDeviceHelper::createSurface( BitmapSystemData const & rData, const Size& rSize )
     {
         OutputDevice *pDevice = getOutputDevice();
         if (pDevice)

canvas/source/cairo/cairo_spritedevicehelper.hxx

@@ -63,7 +63,7 @@ namespace cairocanvas
         const ::cairo::SurfaceSharedPtr& getBufferSurface() { return mpBufferSurface; }
         ::cairo::SurfaceSharedPtr getWindowSurface();
         ::cairo::SurfaceSharedPtr createSurface( const ::basegfx::B2ISize& rSize, int aContent );
-        ::cairo::SurfaceSharedPtr createSurface( BitmapSystemData& rData, const Size& rSize );
+        ::cairo::SurfaceSharedPtr createSurface( BitmapSystemData const & rData, const Size& rSize );
         const ::basegfx::B2ISize& getSizePixel() { return maSize; }
         void flush();
 

canvas/source/cairo/cairo_textlayout.cxx

@@ -295,7 +295,7 @@ namespace cairocanvas
    *
    * @return true, if successful
    **/
-    bool TextLayout::draw( CairoSharedPtr&               pSCairo,
+    bool TextLayout::draw( CairoSharedPtr const &        pSCairo,
                            OutputDevice&                 rOutDev,
                            const Point&                  rOutpos,
                            const rendering::ViewState&   viewState,

canvas/source/cairo/cairo_textlayout.hxx

@@ -82,7 +82,7 @@ namespace cairocanvas
         virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName ) override;
         virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() override;
 
-        bool draw( ::cairo::CairoSharedPtr&                        pSCairo,
+        bool draw( ::cairo::CairoSharedPtr const &                 pSCairo,
                    OutputDevice&                                   rOutDev,
                    const Point&                                    rOutpos,
                    const css::rendering::ViewState&   viewState,

canvas/source/vcl/impltools.cxx

@@ -99,7 +99,7 @@ namespace vclcanvas
                                  vcl::Font&                    io_rVCLFont,
                                  const rendering::ViewState&    rViewState,
                                  const rendering::RenderState&  rRenderState,
-                                 ::OutputDevice&                rOutDev )
+                                 ::OutputDevice const &         rOutDev )
         {
             ::basegfx::B2DHomMatrix aMatrix;
 

canvas/source/vcl/impltools.hxx

@@ -89,7 +89,7 @@ namespace vclcanvas
                                  vcl::Font&                            io_rVCLFont,
                                  const css::rendering::ViewState&      viewState,
                                  const css::rendering::RenderState&    renderState,
-                                 ::OutputDevice&                       rOutDev );
+                                 ::OutputDevice const &                rOutDev );
 
         /** Predicate, to determine whether polygon is actually an axis-aligned rectangle
 

canvas/source/vcl/spritecanvashelper.cxx

@@ -66,7 +66,7 @@ namespace vclcanvas
         }
 
         void repaintBackground( OutputDevice&               rOutDev,
-                                OutputDevice&               rBackBuffer,
+                                OutputDevice const &        rBackBuffer,
                                 const ::basegfx::B2DRange&  rArea )
         {
             const ::Point& rPos( vcl::unotools::pointFromB2DPoint( rArea.getMinimum()) );