drop ModalDialog non .ui ctor

Change-Id: Ib26f0b4d76c530e0aa67f74f6a6920b1883eb8e4
Reviewed-on: https://gerrit.libreoffice.org/52766Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

include/svtools/roadmapwizard.hxx

@@ -66,10 +66,6 @@ namespace svt
         std::unique_ptr<RoadmapWizardImpl>  m_pImpl;
 
     public:
-        RoadmapWizard(
-            vcl::Window* _pParent,
-            const WinBits i_nStyle
-        );
         RoadmapWizard(
             vcl::Window* _pParent
         );

include/svtools/wizardmachine.hxx

@@ -169,7 +169,6 @@ namespace svt
         std::unique_ptr<WizardMachineImplData>  m_pImpl;
 
     public:
-        OWizardMachine(vcl::Window* _pParent, const WinBits i_nStyle, WizardButtonFlags _nButtonFlags );
         OWizardMachine(vcl::Window* _pParent, WizardButtonFlags _nButtonFlags );
         virtual ~OWizardMachine() override;
         virtual void dispose() override;

include/svtools/wizdlg.hxx

@@ -218,7 +218,6 @@ private:
     SVT_DLLPRIVATE TabPage*         ImplGetPage( sal_uInt16 nLevel ) const;
 
 public:
-    WizardDialog( vcl::Window* pParent, WinBits nStyle );
     WizardDialog( vcl::Window* pParent, const OUString& rID, const OUString& rUIXMLDescription );
     virtual ~WizardDialog() override;
     virtual void dispose() override;

include/vcl/dialog.hxx

@@ -195,7 +195,6 @@ public:
 class VCL_DLLPUBLIC ModalDialog : public Dialog
 {
 public:
-    explicit        ModalDialog( vcl::Window* pParent, WinBits nStyle = WB_STDMODAL );
     explicit        ModalDialog( vcl::Window* pParent, const OUString& rID, const OUString& rUIXMLDescription, bool bBorder = false );
 
 protected:

svtools/source/dialogs/roadmapwizard.cxx

@@ -115,13 +115,6 @@ namespace svt
     }
 
     //= RoadmapWizard
-    RoadmapWizard::RoadmapWizard( vcl::Window* _pParent, const WinBits i_nStyle )
-        :OWizardMachine( _pParent, i_nStyle, WizardButtonFlags::NEXT | WizardButtonFlags::PREVIOUS | WizardButtonFlags::FINISH | WizardButtonFlags::CANCEL | WizardButtonFlags::HELP )
-        ,m_pImpl( new RoadmapWizardImpl )
-    {
-        impl_construct();
-    }
-
     RoadmapWizard::RoadmapWizard( vcl::Window* _pParent )
         :OWizardMachine( _pParent, WizardButtonFlags::NEXT | WizardButtonFlags::PREVIOUS | WizardButtonFlags::FINISH | WizardButtonFlags::CANCEL | WizardButtonFlags::HELP )
         ,m_pImpl( new RoadmapWizardImpl )

svtools/source/dialogs/wizardmachine.cxx

@@ -90,18 +90,6 @@ namespace svt
         }
     };
 
-    OWizardMachine::OWizardMachine(vcl::Window* _pParent, const WinBits i_nStyle, WizardButtonFlags _nButtonFlags )
-        :WizardDialog( _pParent, i_nStyle )
-        ,m_pFinish(nullptr)
-        ,m_pCancel(nullptr)
-        ,m_pNextPage(nullptr)
-        ,m_pPrevPage(nullptr)
-        ,m_pHelp(nullptr)
-        ,m_pImpl( new WizardMachineImplData )
-    {
-        implConstruct( _nButtonFlags );
-    }
-
     OWizardMachine::OWizardMachine(vcl::Window* _pParent, WizardButtonFlags _nButtonFlags )
         :WizardDialog( _pParent, "WizardDialog", "svt/ui/wizarddialog.ui" )
         ,m_pFinish(nullptr)

svtools/source/dialogs/wizdlg.cxx

@@ -331,13 +331,6 @@ TabPage* WizardDialog::ImplGetPage( sal_uInt16 nLevel ) const
     return nullptr;
 }
 
-WizardDialog::WizardDialog( vcl::Window* pParent, WinBits nStyle ) :
-    ModalDialog( pParent, nStyle )
-{
-    ImplInitData();
-}
-
-
 WizardDialog::WizardDialog( vcl::Window* pParent, const OUString& rID, const OUString& rUIXMLDescription ) :
     ModalDialog( pParent, rID, rUIXMLDescription )
 {

svtools/source/uno/wizard/wizardshell.cxx

@@ -52,7 +52,7 @@ namespace svt { namespace uno
     //= WizardShell
     WizardShell::WizardShell( vcl::Window* i_pParent, const Reference< XWizardController >& i_rController,
             const Sequence< Sequence< sal_Int16 > >& i_rPaths )
-        :WizardShell_Base( i_pParent, WB_MOVEABLE | WB_CLOSEABLE )
+        :WizardShell_Base( i_pParent )
         ,m_xController( i_rController )
         ,m_nFirstPageID( lcl_determineFirstPageID( i_rPaths ) )
     {

vcl/qa/cppunit/lifecycle.cxx

@@ -299,10 +299,8 @@ void LifecycleTest::testLeakage()
         aObjects.push_back(LeakTestObject::Create<VclVButtonBox>(xVBox));
     }
 
-#if 0 // FIXME - would be good to get internal paths working.
     aObjects.push_back(LeakTestObject::Create<ModelessDialog>(xParent, "PrintProgressDialog", "vcl/ui/printprogressdialog.ui"));
-#endif
-    aObjects.push_back(LeakTestObject::Create<ModalDialog>(xParent));
+    aObjects.push_back(LeakTestObject::Create<ModalDialog>(xParent, "PrintProgressDialog", "vcl/ui/printprogressdialog.ui"));
     xParent.clear();
 
     for (auto i = aObjects.rbegin(); i != aObjects.rend(); ++i)

vcl/source/window/dialog.cxx

@@ -1446,12 +1446,6 @@ ModelessDialog::ModelessDialog(vcl::Window* pParent, const OUString& rID, const
 {
 }
 
-ModalDialog::ModalDialog( vcl::Window* pParent, WinBits nStyle ) :
-    Dialog( WindowType::MODALDIALOG )
-{
-    ImplInit( pParent, nStyle );
-}
-
 ModalDialog::ModalDialog( vcl::Window* pParent, const OUString& rID, const OUString& rUIXMLDescription, bool bBorder ) :
     Dialog(pParent, rID, rUIXMLDescription, WindowType::MODALDIALOG, InitFlag::Default, bBorder)
 {