Kaydet (Commit) 335f7fa8 authored tarafından Stephan Bergmann's avatar Stephan Bergmann

sb140: #i116786# use auto_ptr to track member lifetime

improves over similar 787b8654 "fix leak"
üst bb157a42
......@@ -71,8 +71,6 @@ ToolbarLayoutManager::ToolbarLayoutManager(
m_xUIElementFactoryManager( xUIElementFactory ),
m_pParentLayouter( pParentLayouter ),
m_eDockOperation( DOCKOP_ON_COLROW ),
m_pAddonOptions( 0 ),
m_pGlobalSettings( 0 ),
m_bComponentAttached( false ),
m_bMustLayout( false ),
m_bLayoutDirty( false ),
......@@ -97,8 +95,6 @@ ToolbarLayoutManager::ToolbarLayoutManager(
ToolbarLayoutManager::~ToolbarLayoutManager()
{
delete m_pGlobalSettings;
delete m_pAddonOptions;
}
//---------------------------------------------------------------------------------------------------------
......@@ -973,8 +969,8 @@ rtl::OUString ToolbarLayoutManager::implts_generateGenericAddonToolbarTitle( sal
void ToolbarLayoutManager::implts_createAddonsToolBars()
{
WriteGuard aWriteLock( m_aLock );
if ( !m_pAddonOptions )
m_pAddonOptions = new AddonsOptions;
if ( m_pAddonOptions.get() == 0 )
m_pAddonOptions.reset( new AddonsOptions );
uno::Reference< ui::XUIElementFactory > xUIElementFactory( m_xUIElementFactoryManager );
uno::Reference< frame::XFrame > xFrame( m_xFrame );
......@@ -1587,12 +1583,12 @@ sal_Bool ToolbarLayoutManager::implts_readWindowStateData( const rtl::OUString&
aWriteLock.lock();
bool bGlobalSettings( m_bGlobalSettings );
GlobalSettings* pGlobalSettings( 0 );
if ( m_pGlobalSettings == 0 )
if ( m_pGlobalSettings.get() == 0 )
{
m_pGlobalSettings = new GlobalSettings( m_xSMGR );
m_pGlobalSettings.reset( new GlobalSettings( m_xSMGR ) );
bGetSettingsState = true;
}
pGlobalSettings = m_pGlobalSettings;
pGlobalSettings = m_pGlobalSettings.get();
aWriteLock.unlock();
try
......
......@@ -35,6 +35,7 @@
/** Attention: stl headers must(!) be included at first. Otherwhise it can make trouble
with solaris headers ...
*/
#include <memory>
#include <vector>
//_________________________________________________________________________________________________________________
......@@ -319,8 +320,8 @@ class ToolbarLayoutManager : public ::cppu::WeakImplHelper3< ::com::sun::star::a
Rectangle m_aDockingAreaOffsets;
DockingOperation m_eDockOperation;
AddonsOptions* m_pAddonOptions;
GlobalSettings* m_pGlobalSettings;
std::auto_ptr< AddonsOptions > m_pAddonOptions;
std::auto_ptr< GlobalSettings > m_pGlobalSettings;
bool m_bComponentAttached;
bool m_bMustLayout;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment