loplugin:singlevalfields in unoxml

Change-Id: I340be161aeb343ccc01b86bcb807e4441025419e
Reviewed-on: https://gerrit.libreoffice.org/64595
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

unoxml/source/dom/documentbuilder.cxx

@@ -101,15 +101,15 @@ namespace DOM
         return static_cast< XDocumentBuilder* >(new CDocumentBuilder);
     }
 
-    const char* CDocumentBuilder::aImplementationName = "com.sun.star.comp.xml.dom.DocumentBuilder";
-    const char* CDocumentBuilder::aSupportedServiceNames[] = {
+    static const char aImplementationName[] = "com.sun.star.comp.xml.dom.DocumentBuilder";
+    static const char* aSupportedServiceNames[] = {
         "com.sun.star.xml.dom.DocumentBuilder",
         nullptr
     };
 
     OUString CDocumentBuilder::_getImplementationName()
     {
-        return OUString::createFromAscii(aImplementationName);
+        return OUString(aImplementationName);
     }
     Sequence<OUString> CDocumentBuilder::_getSupportedServiceNames()
     {

unoxml/source/dom/documentbuilder.hxx

@@ -60,8 +60,6 @@ namespace DOM
         explicit CDocumentBuilder();
 
         // static helpers for service info and component management
-        static const char* aImplementationName;
-        static const char* aSupportedServiceNames[];
         static OUString _getImplementationName();
         static css::uno::Sequence< OUString > _getSupportedServiceNames();
         static css::uno::Reference< XInterface > _getInstance(

unoxml/source/dom/saxbuilder.cxx

@@ -38,8 +38,8 @@ namespace DOM
         return static_cast< XSAXDocumentBuilder* >(new CSAXDocumentBuilder(rSMgr));
     }
 
-    const char* CSAXDocumentBuilder::aImplementationName = "com.sun.star.comp.xml.dom.SAXDocumentBuilder";
-    const char* CSAXDocumentBuilder::aSupportedServiceNames[] = {
+    static const char aImplementationName[] = "com.sun.star.comp.xml.dom.SAXDocumentBuilder";
+    static const char* aSupportedServiceNames[] = {
         "com.sun.star.xml.dom.SAXDocumentBuilder",
         nullptr
     };
@@ -51,7 +51,7 @@ namespace DOM
 
     OUString CSAXDocumentBuilder::_getImplementationName()
     {
-        return OUString::createFromAscii(aImplementationName);
+        return OUString(aImplementationName);
     }
     Sequence<OUString> CSAXDocumentBuilder::_getSupportedServiceNames()
     {

unoxml/source/dom/saxbuilder.hxx

@@ -61,8 +61,6 @@ namespace DOM
 
     public:
         // static helpers for service info and component management
-        static const char* aImplementationName;
-        static const char* aSupportedServiceNames[];
         static OUString _getImplementationName();
         static css::uno::Sequence< OUString > _getSupportedServiceNames();
         static css::uno::Reference< XInterface > _getInstance(const css::uno::Reference< css::lang::XMultiServiceFactory >& rSMgr);

unoxml/source/xpath/xpathapi.cxx

@@ -58,15 +58,15 @@ namespace XPath
     {
     }
 
-    const char* CXPathAPI::aImplementationName = "com.sun.star.comp.xml.xpath.XPathAPI";
-    const char* CXPathAPI::aSupportedServiceNames[] = {
+    static const char aImplementationName[] = "com.sun.star.comp.xml.xpath.XPathAPI";
+    static const char* aSupportedServiceNames[] = {
         "com.sun.star.xml.xpath.XPathAPI",
         nullptr
     };
 
     OUString CXPathAPI::_getImplementationName()
     {
-        return OUString::createFromAscii(aImplementationName);
+        return OUString(aImplementationName);
     }
 
     Sequence<OUString> CXPathAPI::_getSupportedServiceNames()

unoxml/source/xpath/xpathapi.hxx

@@ -70,8 +70,6 @@ namespace XPath
                 rSMgr);
 
         // static helpers for service info and component management
-        static const char* aImplementationName;
-        static const char* aSupportedServiceNames[];
         static OUString _getImplementationName();
         static css::uno::Sequence< OUString > _getSupportedServiceNames();
         static css::uno::Reference< XInterface > _getInstance(