Bin some leftover and actually unnecessary iOS crack in vcl

We don't need the '#define SvpSalGraphics AquaSalGraphics' in
vcl/inc/headless/svpgdi.hxx. The actual AquaSalGraphics we use for iOS
is in vcl/inc/quartz/salgdi.h. I don't remember the details of the
convoluted history behind this.

Change-Id: Ie56c3c93acf7ad89e10a05e75aa4ca7fd596ba98
Reviewed-on: https://gerrit.libreoffice.org/63098
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

vcl/headless/svpframe.cxx

@@ -25,7 +25,9 @@
 
 #include <headless/svpframe.hxx>
 #include <headless/svpinst.hxx>
+#ifndef IOS
 #include <headless/svpgdi.hxx>
+#endif
 
 #include <basegfx/vector/b2ivector.hxx>
 

vcl/headless/svpgdi.cxx

@@ -18,7 +18,9 @@
  */
 
 #include <memory>
+#ifndef IOS
 #include <headless/svpgdi.hxx>
+#endif
 #include <headless/svpbmp.hxx>
 #include <headless/svpframe.hxx>
 #include <headless/svpcairotextrender.hxx>

vcl/headless/svpinst.cxx

@@ -38,9 +38,10 @@
 #include <quartz/salbmp.h>
 #include <quartz/salgdi.h>
 #include <quartz/salvd.h>
+#else
+#include <headless/svpgdi.hxx>
 #endif
 #include <headless/svpbmp.hxx>
-#include <headless/svpgdi.hxx>
 
 #include <salframe.hxx>
 #include <svdata.hxx>

vcl/inc/headless/svpgdi.hxx

@@ -20,6 +20,10 @@
 #ifndef INCLUDED_VCL_INC_HEADLESS_SVPGDI_HXX
 #define INCLUDED_VCL_INC_HEADLESS_SVPGDI_HXX
 
+#ifdef IOS
+#error This file is not for iOS
+#endif
+
 #include <osl/endian.h>
 #include <vcl/sysdata.hxx>
 #include <vcl/metric.hxx>
@@ -27,15 +31,9 @@
 
 #include <salgdi.hxx>
 #include <sallayout.hxx>
-#ifndef IOS
 #include "svpcairotextrender.hxx"
-#endif
 #include <impfontmetricdata.hxx>
 
-#ifdef IOS
-#define SvpSalGraphics AquaSalGraphics
-#else
-
 #include <cairo.h>
 
 //Using formats that match cairo's formats. For android we patch cairo,
@@ -276,8 +274,6 @@ public:
     void                    clipRegion(cairo_t* cr);
 };
 
-#endif
-
 #endif // INCLUDED_VCL_INC_HEADLESS_SVPGDI_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

vcl/inc/quartz/ctfonts.hxx

@@ -21,9 +21,6 @@
 #define INCLUDED_VCL_INC_QUARTZ_CTFONTS_HXX
 
 #include <quartz/salgdi.h>
-#ifdef IOS
-#include "headless/svpgdi.hxx"
-#endif
 #include <sallayout.hxx>
 
 SystemFontList* GetCoretextFontList();

vcl/ios/dummies.cxx

@@ -18,7 +18,7 @@
  */
 #include <vcl/svapp.hxx>
 #include "salprn.hxx"
-#include "headless/svpgdi.hxx"
+#include "quartz/salgdi.h"
 #include "headless/svpinst.hxx"
 #include "unx/fontmanager.hxx"
 #include "unx/gendata.hxx"

vcl/quartz/salvd.cxx

@@ -29,7 +29,6 @@
 #include <osx/salframe.h>
 #else
 #include "headless/svpframe.hxx"
-#include "headless/svpgdi.hxx"
 #include "headless/svpinst.hxx"
 #include "headless/svpvd.hxx"
 #endif