a whole bunch of SAL_WARN_UNUSED

Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6
Reviewed-on: https://gerrit.libreoffice.org/33693Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

cppuhelper/qa/unourl/cppu_unourl.cxx

@@ -77,6 +77,7 @@ namespace cppu_unourl
                 {
                     cppu::UnoUrlDescriptor aDescriptor(rtl::OUString::createFromAscii(
                                                            aTests[i].pInput));
+                    (void)aDescriptor;
                     bValid = true;
                 }
                 catch (rtl::MalformedUriException &)
@@ -331,6 +332,7 @@ namespace cppu_unourl
                 try
                 {
                     cppu::UnoUrl aUrl(rtl::OUString::createFromAscii(aTests[i].pInput));
+                    (void)aUrl;
                     bValid = true;
                 }
                 catch (rtl::MalformedUriException &)

cppuhelper/source/defaultbootstrap.cxx

@@ -58,7 +58,6 @@ cppu::defaultBootstrap_InitialComponentContext(rtl::OUString const & iniUri)
     smgr->init(getBootstrapVariable(bs, "UNO_SERVICES"));
     rtl::Reference< cppuhelper::TypeManager > tmgr(new cppuhelper::TypeManager);
     tmgr->init(getBootstrapVariable(bs, "UNO_TYPES"));
-    cppu::ContextEntry_Init entry;
     std::vector< cppu::ContextEntry_Init > context_values;
     context_values.push_back(
         cppu::ContextEntry_Init(

desktop/source/app/app.cxx

@@ -1474,7 +1474,6 @@ int Desktop::Main()
         SetSplashScreenProgress(30);
 
         // create title string
-        LanguageTag aLocale( LANGUAGE_SYSTEM);
         ResMgr* pLabelResMgr = GetDesktopResManager();
         OUString aTitle = pLabelResMgr ? ResId(RID_APPTITLE, *pLabelResMgr).toString() : OUString();
 

include/cppuhelper/access_control.hxx

@@ -27,9 +27,9 @@
 namespace cppu
 {
 
-/** Helper class retriving access controller singleton from component context.
+/** Helper class for retrieving access controller singleton from component context.
 */
-class CPPUHELPER_DLLPUBLIC AccessControl
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC AccessControl
 {
     css::uno::Reference< css::security::XAccessController > m_xController;
 

include/cppuhelper/basemutex.hxx

@@ -32,7 +32,7 @@ namespace cppu
      initialized when the mutex is used to intialize the
      cppu::WeakComponentImplHelperXX
     */
-    class BaseMutex
+    class SAL_WARN_UNUSED BaseMutex
     {
     protected:
         mutable ::osl::Mutex m_aMutex;

include/cppuhelper/component_context.hxx

@@ -32,7 +32,7 @@ namespace cppu
 
 /** Context entries init struct calling createComponentContext().
 */
-struct ContextEntry_Init
+struct SAL_WARN_UNUSED ContextEntry_Init
 {
     /** late init denotes a object that will be raised when first get() is calling for it
 

include/cppuhelper/implbase1.hxx

@@ -35,7 +35,7 @@ namespace cppu
         type_entry m_typeEntries[ 1 + 1 ];
     };
 
-    template< typename Ifc1, typename Impl > struct ImplClassData1
+    template< typename Ifc1, typename Impl > struct SAL_WARN_UNUSED ImplClassData1
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase10.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Ifc6, typename Ifc7, typename Ifc8, typename Ifc9, typename Ifc10, typename Impl >
-    struct ImplClassData10
+    struct SAL_WARN_UNUSED ImplClassData10
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase11.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Ifc6, typename Ifc7, typename Ifc8, typename Ifc9, typename Ifc10, typename Ifc11, typename Impl >
-    struct ImplClassData11
+    struct SAL_WARN_UNUSED ImplClassData11
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase12.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Ifc6, typename Ifc7, typename Ifc8, typename Ifc9, typename Ifc10, typename Ifc11, typename Ifc12, typename Impl >
-    struct ImplClassData12
+    struct SAL_WARN_UNUSED ImplClassData12
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase13.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Ifc6, typename Ifc7, typename Ifc8, typename Ifc9, typename Ifc10, typename Ifc11, typename Ifc12, typename Ifc13, typename Impl >
-    struct ImplClassData13
+    struct SAL_WARN_UNUSED ImplClassData13
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase2.hxx

@@ -35,7 +35,7 @@ namespace cppu
         type_entry m_typeEntries[ 2 + 1 ];
     };
 
-    template< typename Ifc1, typename Ifc2, typename Impl > struct ImplClassData2
+    template< typename Ifc1, typename Ifc2, typename Impl > struct SAL_WARN_UNUSED ImplClassData2
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase3.hxx

@@ -35,7 +35,7 @@ namespace cppu
         type_entry m_typeEntries[ 3 + 1 ];
     };
 
-    template< typename Ifc1, typename Ifc2, typename Ifc3, typename Impl > struct ImplClassData3
+    template< typename Ifc1, typename Ifc2, typename Ifc3, typename Impl > struct SAL_WARN_UNUSED ImplClassData3
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase4.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Impl >
-        struct ImplClassData4
+        struct SAL_WARN_UNUSED ImplClassData4
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase5.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Impl >
-        struct ImplClassData5
+        struct SAL_WARN_UNUSED ImplClassData5
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase6.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Ifc6, typename Impl >
-        struct ImplClassData6
+        struct SAL_WARN_UNUSED ImplClassData6
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase7.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Ifc6, typename Ifc7, typename Impl >
-        struct ImplClassData7
+        struct SAL_WARN_UNUSED ImplClassData7
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase8.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Ifc6, typename Ifc7, typename Ifc8, typename Impl >
-    struct ImplClassData8
+    struct SAL_WARN_UNUSED ImplClassData8
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase9.hxx

@@ -36,7 +36,7 @@ namespace cppu
     };
 
     template< typename Ifc1, typename Ifc2, typename Ifc3, typename Ifc4, typename Ifc5, typename Ifc6, typename Ifc7, typename Ifc8, typename Ifc9, typename Impl >
-    struct ImplClassData9
+    struct SAL_WARN_UNUSED ImplClassData9
     {
         class_data* operator ()()
         {

include/cppuhelper/implbase_ex.hxx

@@ -46,7 +46,7 @@ typedef css::uno::Type const & (SAL_CALL * fptr_getCppuType)( void * );
 
 /** single type + object offset
 */
-struct type_entry
+struct SAL_WARN_UNUSED type_entry
 {
     /** the type_entry is initialized with function pointer to ::getCppuType() function first,
         but holds an unacquired typelib_TypeDescriptionReference * after initialization,
@@ -69,7 +69,7 @@ struct type_entry
 
 /** identical dummy struct for casting class_dataN to class_data
 */
-struct class_data
+struct SAL_WARN_UNUSED class_data
 {
     /** number of supported types in m_typeEntries
     */

include/cppuhelper/implementationentry.hxx

@@ -37,7 +37,7 @@ namespace cppu
 /** One struct instance represents all data necessary for registering one service implementation.
 
  */
-struct ImplementationEntry
+struct SAL_WARN_UNUSED ImplementationEntry
 {
     /** Function that creates an instance of the implementation
      */

include/cppuhelper/interfacecontainer.h

@@ -124,7 +124,7 @@ private:
 
   @see OInterfaceIteratorHelper
  */
-class CPPUHELPER_DLLPUBLIC OInterfaceContainerHelper
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC OInterfaceContainerHelper
 {
 public:
     // these are here to force memory de/allocation to sal lib.
@@ -432,7 +432,7 @@ private:
   can't compile addListener( const container::keyType &key ).
  */
 template < class container , class keyType >
-struct OBroadcastHelperVar
+struct SAL_WARN_UNUSED OBroadcastHelperVar
 {
     /** The shared mutex. */
     ::osl::Mutex &                      rMutex;

include/cppuhelper/propshlp.hxx

@@ -43,7 +43,7 @@ namespace cppu
 /**
    This interface is used by the OPropertyHelper, to access the property description.
  */
-class CPPUHELPER_DLLPUBLIC IPropertyArrayHelper
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC IPropertyArrayHelper
 {
 public:
     // these are here to force memory de/allocation to sal lib.
@@ -109,7 +109,7 @@ public:
    You can use this helper class to map a XPropertySet-Interface to a XFast-
    or a XMultiPropertySet interface.
  */
-class CPPUHELPER_DLLPUBLIC OPropertyArrayHelper : public IPropertyArrayHelper
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC OPropertyArrayHelper : public IPropertyArrayHelper
 {
 public:
      /**
@@ -215,10 +215,11 @@ struct hashInt32_Impl
     size_t operator()(const sal_Int32 & i) const
         { return i; }
 };
+
 /** Specialized class for key type sal_Int32,
     without explicit usage of STL symbols.
 */
-class CPPUHELPER_DLLPUBLIC OMultiTypeInterfaceContainerHelperInt32
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC OMultiTypeInterfaceContainerHelperInt32
 {
 public:
     // these are here to force memory de/allocation to sal lib.

include/cppuhelper/typeprovider.hxx

@@ -34,7 +34,7 @@ namespace cppu
 /** Helper class to implement css::lang::XTypeProvider.  Construct a static object
     of this class with your UNO object's supported types.
 */
-class CPPUHELPER_DLLPUBLIC OTypeCollection
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC OTypeCollection
 {
     css::uno::Sequence< css::uno::Type > _aTypes;
 
@@ -168,7 +168,7 @@ public:
 /** Helper class to implement IDs for XUnoTunnel.  Construct a static object
     of this class for your UNO object's implementation id.
 */
-class CPPUHELPER_DLLPUBLIC OImplementationId
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC OImplementationId
 {
     mutable css::uno::Sequence< sal_Int8 > * _pSeq;
     sal_Bool _bUseEthernetAddress;

include/cppuhelper/unourl.hxx

@@ -35,7 +35,7 @@ namespace cppu {
     For example, some functions take a string representing a connection or
     protocol descriptor as input, and can use this class to parse the string.
  */
-class CPPUHELPER_DLLPUBLIC UnoUrlDescriptor
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC UnoUrlDescriptor
 {
 public:
     class Impl;
@@ -126,7 +126,7 @@ private:
     invalid UTF-16 entities in the resulting output (e.g., a high surrogate not
     followed by a low surrogate) are not detected.
  */
-class CPPUHELPER_DLLPUBLIC UnoUrl
+class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC UnoUrl
 {
 public:
     /** Construct a UNO URL from a string representation.

include/i18nlangtag/languagetag.hxx

@@ -49,7 +49,7 @@ class LanguageTagImpl;
     For standalone conversions if no LanguageTag instance is at hand, static
     convertTo...() methods exist.
  */
-class I18NLANGTAG_DLLPUBLIC LanguageTag
+class SAL_WARN_UNUSED I18NLANGTAG_DLLPUBLIC LanguageTag
 {
     friend class LanguageTagImpl;
 

include/i18nlangtag/languagetagicu.hxx

@@ -24,7 +24,7 @@ class LanguageTag;
     makefiles) with ICU header file inclusion, only the few code actually using
     this needs to know about ICU, which it did anyway.
 */
-class I18NLANGTAG_DLLPUBLIC LanguageTagIcu
+class SAL_WARN_UNUSED I18NLANGTAG_DLLPUBLIC LanguageTagIcu
 {
 public:
 

include/i18nlangtag/mslangid.hxx

@@ -32,7 +32,7 @@ struct IsoLanguageScriptCountryEntry;
 
 /** Methods related to Microsoft language IDs. For details about MS-LANGIDs
     please see lang.h */
-class I18NLANGTAG_DLLPUBLIC MsLangId
+class SAL_WARN_UNUSED I18NLANGTAG_DLLPUBLIC MsLangId
 {
 public:
 

include/salhelper/linkhelper.hxx

@@ -15,7 +15,7 @@
 
 namespace salhelper
 {
-    class LinkResolver
+    class SAL_WARN_UNUSED LinkResolver
     {
     public:
         osl::FileStatus m_aStatus;

include/salhelper/timer.hxx

@@ -32,7 +32,7 @@ namespace salhelper
  *
  *  Times are seconds in UTC since 01.01.1970
  */
-struct TTimeValue : public TimeValue
+struct SAL_WARN_UNUSED TTimeValue : public TimeValue
 {
     TTimeValue()
     {

include/tools/b3dtrans.hxx

@@ -30,7 +30,7 @@
 #include <tools/toolsdllapi.h>
 
 /// Transformation sets for 3D output
-class TOOLS_DLLPUBLIC B3dTransformationSet
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC B3dTransformationSet
 {
 private:
     // Object Matrix Object -> World
@@ -147,7 +147,7 @@ protected:
     Uses a simplified model, in which a point is described using a View
     Reference Point (VRP).
 */
-class TOOLS_DLLPUBLIC B3dViewport : public B3dTransformationSet
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC B3dViewport : public B3dTransformationSet
 {
 private:
     basegfx::B3DPoint           aVRP;   // View Reference Point
@@ -174,7 +174,7 @@ protected:
 
 // B3D camera
 
-class TOOLS_DLLPUBLIC B3dCamera : public B3dViewport
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC B3dCamera : public B3dViewport
 {
 private:
     basegfx::B3DPoint       aPosition;

include/tools/config.hxx

@@ -25,7 +25,7 @@
 struct ImplConfigData;
 struct ImplGroupData;
 
-class TOOLS_DLLPUBLIC Config
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC Config
 {
 private:
     OUString            maFileName;

include/tools/errinf.hxx

@@ -34,7 +34,7 @@ namespace vcl { class Window; }
 class DynamicErrorInfo_Impl;
 class ErrorHandler_Impl;
 
-class TOOLS_DLLPUBLIC ErrorInfo
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC ErrorInfo
 {
 private:
     sal_uIntPtr             lUserId;
@@ -50,7 +50,7 @@ public:
     static ErrorInfo*       GetErrorInfo(sal_uIntPtr);
 };
 
-class TOOLS_DLLPUBLIC DynamicErrorInfo : public ErrorInfo
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC DynamicErrorInfo : public ErrorInfo
 {
     friend class DynamicErrorInfo_Impl;
 
@@ -66,7 +66,7 @@ public:
     sal_uInt16              GetDialogMask() const;
 };
 
-class TOOLS_DLLPUBLIC StringErrorInfo : public DynamicErrorInfo
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC StringErrorInfo : public DynamicErrorInfo
 {
 private:
     OUString                aString;
@@ -79,7 +79,7 @@ public:
     const OUString&         GetErrorString() const { return aString; }
 };
 
-class TOOLS_DLLPUBLIC TwoStringErrorInfo: public DynamicErrorInfo
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC TwoStringErrorInfo: public DynamicErrorInfo
 {
 private:
     OUString aArg1;
@@ -96,7 +96,7 @@ public:
 };
 
 struct ErrorContextImpl;
-class TOOLS_DLLPUBLIC ErrorContext
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC ErrorContext
 {
     friend class ErrorHandler;
 
@@ -119,7 +119,7 @@ typedef sal_uInt16 WindowDisplayErrorFunc(
 typedef void BasicDisplayErrorFunc(
     const OUString &rErr, const OUString &rAction);
 
-class TOOLS_DLLPUBLIC ErrorHandler
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC ErrorHandler
 {
     friend class ErrorHandler_Impl;
 

include/tools/globname.hxx

@@ -25,7 +25,7 @@
 #include <com/sun/star/uno/Sequence.hxx>
 #include <o3tl/cow_wrapper.hxx>
 
-struct SvGUID
+struct SAL_WARN_UNUSED SvGUID
 {
     sal_uInt32 Data1;
     sal_uInt16 Data2;
@@ -33,7 +33,7 @@ struct SvGUID
     sal_uInt8  Data4[8];
 };
 
-struct ImpSvGlobalName
+struct SAL_WARN_UNUSED ImpSvGlobalName
 {
     struct SvGUID   szData;
 
@@ -52,7 +52,7 @@ struct ImpSvGlobalName
 
 class SvStream;
 
-class TOOLS_DLLPUBLIC SvGlobalName
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC SvGlobalName
 {
     ::o3tl::cow_wrapper< ImpSvGlobalName > pImp;
 

include/tools/inetmime.hxx

@@ -59,7 +59,7 @@ typedef std::unordered_map<OString, INetContentTypeParameter, OStringHash>
     INetContentTypeParameterList;
 
 
-class TOOLS_DLLPUBLIC INetMIME
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC INetMIME
 {
 public:
     /** Check for US-ASCII visible character.

include/tools/inetmsg.hxx

@@ -31,7 +31,7 @@
 
 class DateTime;
 
-class INetMessageHeader
+class SAL_WARN_UNUSED INetMessageHeader
 {
     OString m_aName;
     OString m_aValue;
@@ -70,7 +70,7 @@ enum class InetMessageMime
     NUMHDR                     = 4,
 };
 
-class TOOLS_DLLPUBLIC INetMIMEMessage
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC INetMIMEMessage
 {
     ::std::vector< INetMessageHeader* >
                     m_aHeaderList;

include/tools/line.hxx

@@ -25,7 +25,7 @@
 namespace tools
 {
 
-class TOOLS_DLLPUBLIC Line
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC Line
 {
 private:
     Point           maStart;

include/tools/mempool.hxx

@@ -26,7 +26,7 @@
 
 struct FixedMemPool_Impl;
 
-class TOOLS_DLLPUBLIC FixedMemPool
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC FixedMemPool
 {
     FixedMemPool_Impl * m_pImpl;
     char const *        m_pTypeName;

include/tools/multisel.hxx

@@ -30,7 +30,7 @@ typedef ::std::vector< Range* > ImpSelList;
 
 #define SFX_ENDOFSELECTION      ULONG_MAX
 
-class TOOLS_DLLPUBLIC MultiSelection
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC MultiSelection
 {
 private:
     ImpSelList      aSels;      // array of SV-selections
@@ -77,7 +77,7 @@ public:
     const Range&    GetRange( size_t nRange ) const { return *aSels[nRange]; }
 };
 
-class TOOLS_DLLPUBLIC StringRangeEnumerator
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC StringRangeEnumerator
 {
     struct Range
     {

include/tools/rc.hxx

@@ -22,7 +22,7 @@
 #include <tools/toolsdllapi.h>
 #include <tools/resmgr.hxx>
 
-class TOOLS_DLLPUBLIC Resource
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC Resource
 {
 protected:
     ResMgr* m_pResMgr;

include/tools/resary.hxx

@@ -27,7 +27,7 @@
 
 class ResId;
 
-class TOOLS_DLLPUBLIC ResStringArray
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC ResStringArray
 {
     struct Impl;
     std::unique_ptr<Impl> mpImpl;

include/tools/resid.hxx

@@ -32,7 +32,7 @@ typedef sal_uInt32 RESOURCE_TYPE;
 
 class ResMgr;
 
-class ResId
+class SAL_WARN_UNUSED ResId
 {
     /*
     Consider two cases:

include/tools/resmgr.hxx

@@ -80,7 +80,7 @@ struct ImpRCStack
     void            Init( ResMgr * pMgr, const Resource * pObj, sal_uInt32 nId );
 };
 
-class TOOLS_DLLPUBLIC ResMgr
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC ResMgr
 {
 private:
     InternalResMgr* pImpRes;

include/tools/simplerm.hxx

@@ -31,7 +31,7 @@
 
 class InternalResMgr;
 
-class TOOLS_DLLPUBLIC SimpleResMgr final
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC SimpleResMgr final
 {
     osl::Mutex              m_aAccessSafety;
     std::unique_ptr<InternalResMgr>

include/tools/svborder.hxx

@@ -23,7 +23,7 @@
 #include <tools/toolsdllapi.h>
 #include <tools/gen.hxx>
 
-class TOOLS_DLLPUBLIC SvBorder
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC SvBorder
 {
     long nTop, nRight, nBottom, nLeft;
 

include/tools/unqidx.hxx

@@ -49,7 +49,7 @@ public:
 };
 
 template<typename T>
-class UniqueIndex : private UniqueIndexImpl
+class SAL_WARN_UNUSED UniqueIndex : private UniqueIndexImpl
 {
 public:
     using UniqueIndexImpl::Index;

include/tools/wldcrd.hxx

@@ -23,7 +23,7 @@
 #include <osl/thread.h>
 #include <rtl/ustring.hxx>
 
-class TOOLS_DLLPUBLIC WildCard
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC WildCard
 {
 private:
     OString aWildString;

include/tools/zcodec.hxx

@@ -33,7 +33,7 @@ class SvStream;
 // * BeginCompression, Write*, EndCompression
 // * BeginCompression, Read*, EndCompression
 // * BeginCompression, ReadAsynchron*, EndCompression
-class TOOLS_DLLPUBLIC ZCodec
+class SAL_WARN_UNUSED TOOLS_DLLPUBLIC ZCodec
 {
     enum State { STATE_INIT, STATE_DECOMPRESS, STATE_COMPRESS };
     State           meState;

include/unoidl/unoidl.hxx

@@ -77,7 +77,7 @@ struct AnnotatedReference {
     std::vector< rtl::OUString > annotations;
 };
 
-class LO_DLLPUBLIC_UNOIDL Entity: public salhelper::SimpleReferenceObject {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL Entity: public salhelper::SimpleReferenceObject {
 public:
     enum Sort {
         SORT_MODULE, SORT_ENUM_TYPE, SORT_PLAIN_STRUCT_TYPE,
@@ -98,7 +98,7 @@ private:
     Sort sort_;
 };
 
-class LO_DLLPUBLIC_UNOIDL MapCursor: public salhelper::SimpleReferenceObject {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL MapCursor: public salhelper::SimpleReferenceObject {
 public:
     // throws FileFormatException:
     virtual rtl::Reference< Entity > getNext(rtl::OUString * name) = 0;
@@ -109,7 +109,7 @@ protected:
     virtual SAL_DLLPRIVATE ~MapCursor() throw() override;
 };
 
-class LO_DLLPUBLIC_UNOIDL ModuleEntity: public Entity {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL ModuleEntity: public Entity {
 public:
     // throws FileFormatException:
     virtual std::vector< rtl::OUString > getMemberNames() const = 0;
@@ -123,7 +123,7 @@ protected:
     virtual SAL_DLLPRIVATE ~ModuleEntity() throw () override;
 };
 
-class LO_DLLPUBLIC_UNOIDL PublishableEntity: public Entity {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL PublishableEntity: public Entity {
 public:
     bool isPublished() const { return published_; }
 
@@ -145,7 +145,7 @@ private:
     std::vector< rtl::OUString > annotations_;
 };
 
-class LO_DLLPUBLIC_UNOIDL EnumTypeEntity: public PublishableEntity {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL EnumTypeEntity: public PublishableEntity {
 public:
     struct Member {
         Member(
@@ -176,7 +176,7 @@ private:
     std::vector< Member > members_;
 };
 
-class LO_DLLPUBLIC_UNOIDL PlainStructTypeEntity: public PublishableEntity {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL PlainStructTypeEntity: public PublishableEntity {
 public:
     struct Member {
         Member(rtl::OUString const & theName, rtl::OUString const & theType,
@@ -211,7 +211,7 @@ private:
     std::vector< Member > directMembers_;
 };
 
-class LO_DLLPUBLIC_UNOIDL PolymorphicStructTypeTemplateEntity:
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL PolymorphicStructTypeTemplateEntity:
     public PublishableEntity
 {
 public:
@@ -254,7 +254,7 @@ private:
     std::vector< Member > members_;
 };
 
-class LO_DLLPUBLIC_UNOIDL ExceptionTypeEntity: public PublishableEntity {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL ExceptionTypeEntity: public PublishableEntity {
 public:
     struct Member {
         Member(
@@ -290,7 +290,7 @@ private:
     std::vector< Member > directMembers_;
 };
 
-class LO_DLLPUBLIC_UNOIDL InterfaceTypeEntity: public PublishableEntity {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL InterfaceTypeEntity: public PublishableEntity {
 public:
     struct Attribute {
         Attribute(
@@ -390,7 +390,7 @@ private:
     std::vector< Method > directMethods_;
 };
 
-class LO_DLLPUBLIC_UNOIDL TypedefEntity: public PublishableEntity {
+class SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL TypedefEntity: public PublishableEntity {
 public:
     SAL_DLLPRIVATE TypedefEntity(
         bool published, rtl::OUString const & type,
@@ -406,7 +406,7 @@ private:
     rtl::OUString type_;
 };
 
-struct LO_DLLPUBLIC_UNOIDL ConstantValue {
+struct SAL_WARN_UNUSED LO_DLLPUBLIC_UNOIDL ConstantValue {
     enum Type {
         TYPE_BOOLEAN, TYPE_BYTE, TYPE_SHORT, TYPE_UNSIGNED_SHORT, TYPE_LONG,
         TYPE_UNSIGNED_LONG, TYPE_HYPER, TYPE_UNSIGNED_HYPER, TYPE_FLOAT,
@@ -454,7 +454,7 @@ struct LO_DLLPUBLIC_UNOIDL ConstantValue {
     };