loplugin: unnecessary destructor sfx2..store

Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf
Reviewed-on: https://gerrit.libreoffice.org/33514Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/sfx2/Metadatable.hxx

@@ -141,8 +141,6 @@ class SFX2_DLLPUBLIC MetadatableMixin :
 public:
     MetadatableMixin() {};
 
-    virtual ~MetadatableMixin() override {}
-
     // css::rdf::XNode:
     virtual OUString SAL_CALL getStringValue()
         throw (css::uno::RuntimeException, std::exception) override;

include/sfx2/emojiview.hxx

@@ -42,8 +42,6 @@ public:
         : mCategory(rCategory)
     {}
 
-    ~ViewFilter_Category () {}
-
     bool operator () (const ThumbnailViewItem *pItem);
 
     static bool isFilteredCategory(FILTER_CATEGORY filter, const OUString &rCategory);

include/sfx2/itemwrapper.hxx

@@ -134,8 +134,6 @@ public:
     inline explicit     ValueItemWrapper( sal_uInt16 nSlot ) :
                             SingleItemWrapper< ItemT, ValueT >( nSlot ) {}
 
-    virtual             ~ValueItemWrapper() {}
-
     virtual ValueT      GetItemValue( const ItemT& rItem ) const SAL_OVERRIDE
                             { return static_cast< ValueT >( rItem.GetValue() ); }
     virtual void        SetItemValue( ItemT& rItem, ValueT aValue ) const SAL_OVERRIDE
@@ -156,8 +154,6 @@ public:
     inline explicit     IdentItemWrapper( sal_uInt16 nSlot ) :
                             SingleItemWrapper< ItemT, const ItemT& >( nSlot ) {}
 
-    virtual             ~IdentItemWrapper() {}
-
     virtual const ItemT& GetItemValue( const ItemT& rItem ) const SAL_OVERRIDE
                             { return rItem; }
     virtual void        SetItemValue( ItemT& rItem, const ItemT& rValue ) const SAL_OVERRIDE

include/sfx2/sidebar/UnoDeck.hxx

@@ -29,7 +29,6 @@ class SfxUnoDeck : public cppu::WeakImplHelper<css::ui::XDeck>
 public:
 
     SfxUnoDeck(const css::uno::Reference<css::frame::XFrame>& , const OUString&);
-    virtual ~SfxUnoDeck() override {};
 
     virtual OUString SAL_CALL getId()
                                 throw(css::uno::RuntimeException, std::exception) override;

include/sfx2/sidebar/UnoDecks.hxx

@@ -31,7 +31,6 @@ class SfxUnoDecks : public cppu::WeakImplHelper<css::ui::XDecks>
 public:
 
     SfxUnoDecks(const css::uno::Reference<css::frame::XFrame>&);
-    virtual ~SfxUnoDecks() override {};
 
 // XNameAccess
 
@@ -71,4 +70,4 @@ private:
 
 #endif
 
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

include/sfx2/sidebar/UnoPanel.hxx

@@ -32,7 +32,6 @@ class SfxUnoPanel : public cppu::WeakImplHelper<css::ui::XPanel>
 public:
 
     SfxUnoPanel(const css::uno::Reference<css::frame::XFrame>& , const OUString&, const OUString&);
-    virtual ~SfxUnoPanel() override {};
 
     virtual OUString SAL_CALL getId()
                                 throw(css::uno::RuntimeException, std::exception) override;

include/sfx2/sidebar/UnoPanels.hxx

@@ -29,7 +29,6 @@ class SfxUnoPanels : public cppu::WeakImplHelper<css::ui::XPanels>
 public:
 
     SfxUnoPanels(const css::uno::Reference<css::frame::XFrame>& , const OUString&);
-    virtual ~SfxUnoPanels() override {};
 
 // XPanels
     virtual OUString SAL_CALL getDeckId()

include/sfx2/templatelocalview.hxx

@@ -59,8 +59,6 @@ public:
         : mApp(App)
     {}
 
-    ~ViewFilter_Application () {}
-
     bool operator () (const ThumbnailViewItem *pItem);
 
     static bool isFilteredExtension(FILTER_APPLICATION filter, const OUString &rExt);

sfx2/source/appl/linksrc.cxx

@@ -81,14 +81,8 @@ struct SvLinkSource_Entry_Impl
     explicit SvLinkSource_Entry_Impl( SvBaseLink* pLink )
         : xSink( pLink ), nAdviseModes( 0 ), bIsDataSink( false )
     {}
-
-    ~SvLinkSource_Entry_Impl();
 };
 
-SvLinkSource_Entry_Impl::~SvLinkSource_Entry_Impl()
-{
-}
-
 class SvLinkSource_Array_Impl
 {
 private:
@@ -195,13 +189,8 @@ struct SvLinkSource_Impl
         , m_bIsReadOnly(false)
     {
     }
-    ~SvLinkSource_Impl();
 };
 
-SvLinkSource_Impl::~SvLinkSource_Impl()
-{
-}
-
 SvLinkSource::SvLinkSource()
      : pImpl( new SvLinkSource_Impl )
 {

sfx2/source/appl/lnkbase2.cxx

@@ -56,9 +56,6 @@ struct BaseLink_Impl
         , m_pFileDlg( nullptr )
         , m_bIsConnect( false )
         {}
-
-    ~BaseLink_Impl()
-        {}
 };
 
 // only for internal management

sfx2/source/dialog/backingwindow.cxx

@@ -741,7 +741,6 @@ struct ImplDelayedDispatch
       aArgs( i_rArgs )
     {
     }
-    ~ImplDelayedDispatch() {}
 };
 
 static void implDispatchDelayed( void*, void* pArg )

sfx2/source/dialog/securitypage.cxx

@@ -151,7 +151,6 @@ struct SfxSecurityPage_Impl
     DECL_LINK( ChangeProtectionPBHdl, Button*, void );
 
     SfxSecurityPage_Impl( SfxSecurityPage &rDlg, const SfxItemSet &rItemSet );
-    ~SfxSecurityPage_Impl();
 
     bool    FillItemSet_Impl( SfxItemSet & );
     void    Reset_Impl( const SfxItemSet & );
@@ -181,11 +180,6 @@ SfxSecurityPage_Impl::SfxSecurityPage_Impl( SfxSecurityPage &rTabPage, const Sfx
 }
 
 
-SfxSecurityPage_Impl::~SfxSecurityPage_Impl()
-{
-}
-
-
 bool SfxSecurityPage_Impl::FillItemSet_Impl( SfxItemSet & )
 {
     bool bModified = false;

sfx2/source/dialog/tabdlg.cxx

@@ -124,9 +124,6 @@ struct TabDlg_Impl
     {
         aData.reserve( nCnt );
     }
-    ~TabDlg_Impl()
-    {
-    }
 };
 
 

sfx2/source/inc/docundomanager.hxx

@@ -82,9 +82,6 @@ public:
     {
         i_rSubComponent.MethodEntryCheck();
     }
-    ~SfxModelGuard()
-    {
-    }
 
     void clear()
     {

sfx2/source/inc/templatesearchviewitem.hxx

@@ -19,9 +19,6 @@ struct TemplateSearchViewItem : public TemplateViewItem
         , mnAssocId(0)
     {}
 
-    virtual ~TemplateSearchViewItem () override
-    {}
-
     sal_uInt16 mnAssocId;    //Associated item id to the TemplateViews
 };
 

sfx2/source/view/impframe.hxx

@@ -71,8 +71,6 @@ public:
         ,bMenuBarOn( true )
     {
     }
-
-    virtual ~SfxFrame_Impl() override { }
 };
 
 #endif

sfx2/source/view/impviewframe.hxx

@@ -66,10 +66,6 @@ struct SfxViewFrame_Impl
         , bActive(false)
     {
     }
-
-    ~SfxViewFrame_Impl()
-    {
-    }
 };
 
 class SfxFrameViewWindow_Impl : public vcl::Window

sfx2/source/view/printer.cxx

@@ -47,7 +47,6 @@ struct SfxPrinter_Impl
         mbSelection ( true ),
         mbFromTo    ( true ),
         mbRange     ( true ) {}
-    ~SfxPrinter_Impl() {}
 };
 
 struct SfxPrintOptDlg_Impl

sfx2/source/view/viewprn.cxx

@@ -411,7 +411,6 @@ private:
 
 public:
             SfxDialogExecutor_Impl( SfxViewShell* pViewSh, PrinterSetupDialog* pParent );
-            ~SfxDialogExecutor_Impl() {}
 
     Link<Button*, void> GetLink() const { return LINK(const_cast<SfxDialogExecutor_Impl*>(this), SfxDialogExecutor_Impl, Execute); }
     const SfxItemSet*   GetOptions() const { return _pOptions.get(); }

slideshow/source/engine/opengl/Operation.hxx

@@ -104,7 +104,6 @@ public:
     */
     SRotate(const glm::vec3& Axis, const glm::vec3& Origin, double Angle,
             bool bInter, double T0, double T1);
-    virtual ~SRotate() override {}
 private:
     /** axis to rotate CCW about
     */
@@ -149,7 +148,6 @@ public:
 
     */
     SScale(const glm::vec3& Scale, const glm::vec3& Origin,bool bInter, double T0, double T1);
-    virtual ~SScale() override {}
 private:
     glm::vec3 scale;
     glm::vec3 origin;
@@ -181,7 +179,6 @@ public:
 
     */
     STranslate(const glm::vec3& Vector,bool bInter, double T0, double T1);
-    virtual ~STranslate() override {}
 private:
     /** vector to translate by
     */
@@ -214,7 +211,6 @@ public:
 
     */
     SEllipseTranslate(double dWidth, double dHeight, double dStartPosition, double dEndPosition, bool bInter, double T0, double T1);
-    virtual ~SEllipseTranslate() override {}
 private:
     /** width and length of the ellipse
      */
@@ -237,7 +233,6 @@ public:
     virtual void interpolate(glm::mat4& matrix, double t, double SlideWidthScale, double SlideHeightScale) const override;
 
     RotateAndScaleDepthByWidth(const glm::vec3& Axis,const glm::vec3& Origin,double Angle, bool bScale, bool bInter, double T0, double T1);
-    virtual ~RotateAndScaleDepthByWidth() override {}
 private:
     glm::vec3 axis;
     glm::vec3 origin;
@@ -256,7 +251,6 @@ public:
     virtual void interpolate(glm::mat4& matrix, double t, double SlideWidthScale, double SlideHeightScale) const override;
 
     RotateAndScaleDepthByHeight(const glm::vec3& Axis,const glm::vec3& Origin,double Angle, bool bScale, bool bInter, double T0, double T1);
-    virtual ~RotateAndScaleDepthByHeight() override {}
 private:
     glm::vec3 axis;
     glm::vec3 origin;

slideshow/source/inc/animation.hxx

@@ -47,8 +47,6 @@ namespace slideshow
         class Animation : public virtual SharedPtrAble
         {
         public:
-            virtual ~Animation() override {}
-
             /** Notify that the animation going active soon.
 
                 Implementers should preload any buffers, and create

slideshow/source/inc/shapeattributelayer.hxx

@@ -50,7 +50,6 @@ namespace slideshow
         class State final
         {
         public:
-            ~State() {}
 
             /// Abstract, numerically encoded state ID
             typedef ::std::size_t StateId;

slideshow/source/inc/vieweventhandler.hxx

@@ -42,8 +42,6 @@ namespace slideshow
         class ViewEventHandler : public virtual SharedPtrAble
         {
         public:
-            virtual ~ViewEventHandler() override {}
-
             /** Notify new view.
 
                 @param rView

sot/source/sdstor/stgstrms.hxx

@@ -100,7 +100,6 @@ class StgFATStrm : public StgStrm {     // the master FAT stream
     bool  SetPage( short, sal_Int32 );
 public:
     explicit StgFATStrm( StgIo& );
-    virtual ~StgFATStrm() override {}
     using StgStrm::GetPage;
     sal_Int32 GetPage( short, bool, sal_uInt16 *pnMasterAlloc = nullptr);
     virtual bool SetSize( sal_Int32 ) override;

starmath/inc/cursor.hxx

@@ -93,10 +93,6 @@ public:
         BuildGraph();
     }
 
-    ~SmCursor()
-    {
-    }
-
     /** Get position */
     const SmCaretPos& GetPosition() const { return mpPosition->CaretPos; }
 

starmath/source/mathmlexport.hxx

@@ -97,7 +97,6 @@ public:
     SmXMLExport(
         const css::uno::Reference< css::uno::XComponentContext >& rContext,
         OUString const & implementationName, SvXMLExportFlags nExportFlags);
-    virtual ~SmXMLExport() override {};
 
     // XUnoTunnel
     sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& rId ) throw(css::uno::RuntimeException, std::exception) override;

store/source/storcach.cxx

@@ -54,9 +54,6 @@ struct Entry
     explicit Entry (std::shared_ptr<PageData> const & rxPage, sal_uInt32 nOffset)
         : m_xPage(rxPage), m_nOffset(nOffset), m_pNext(nullptr)
     {}
-
-    // Destruction
-    ~Entry() {}
 };
 };