Kaydet (Commit) 2228203a authored tarafından Stephan Bergmann's avatar Stephan Bergmann

Don't run CompilerTest_compilerplugins_clang with COMPILER_PLUGIN_TOOL=...

When COMPILER_PLUGIN_TOOL is set, solenv/gbuild/LinkTarget.mk uses the (plaform-
generic) gb_*__tool_command which don't know about the COMPILER_TEST flag (as
gb_CObject__command_pattern in solenv/gbuild/platform/com_GCC_class.mk does), so
a top-level Clang

  make COMPILER_PLUGIN_TOOL=...

will generate spurious warnings from CompilerTest_compilerplugins_clang's
compilations done without the -Xclang -verify switch.  This solution is a bit
hacky (e.g., it would be better to handle this more centrally in
solenv/gbuild/CompilerTest.mk), but effective.

Change-Id: I58e9a76207065d9f6050a1ace6fc85c5a26882f8
üst 2fec2ab3
...@@ -36,9 +36,11 @@ endif ...@@ -36,9 +36,11 @@ endif
endif endif
ifneq ($(COMPILER_PLUGINS),) ifneq ($(COMPILER_PLUGINS),)
ifeq ($(COMPILER_EXTERNAL_TOOL)$(COMPILER_PLUGIN_TOOL),)
$(eval $(call gb_Module_add_check_targets,solenv, \ $(eval $(call gb_Module_add_check_targets,solenv, \
CompilerTest_compilerplugins_clang \ CompilerTest_compilerplugins_clang \
)) ))
endif endif
endif
# vim: set shiftwidth=4 tabstop=4 noexpandtab: # vim: set shiftwidth=4 tabstop=4 noexpandtab:
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment