extract the common updater code to an own static library

We again need to use a static lib to prevent the file is in use problem
during the update.

Change-Id: I22d00ea2ab46949d32cdaae85c799896d6e0468f

onlineupdate/Executable_updater.mk

@@ -18,6 +18,7 @@ $(eval $(call gb_Executable_set_include,updater,\
 
 $(eval $(call gb_Executable_use_static_libraries,updater,\
     libmar \
+    updatehelper \
 	$(if $(filter WNT,$(OS)), \
 		winhelper )\
 ))
@@ -51,6 +52,7 @@ $(eval $(call gb_Executable_use_externals,updater,\
 $(eval $(call gb_Executable_add_defs,updater,\
 	-DVERIFY_MAR_SIGNATURE \
 	-DNSS3 \
+	-DUNICODE \
 ))
 
 $(eval $(call gb_Executable_add_exception_objects,updater,\
@@ -60,11 +62,6 @@ $(eval $(call gb_Executable_add_exception_objects,updater,\
 	onlineupdate/source/update/updater/progressui_gtk \
 	onlineupdate/source/update/updater/progressui_null \
 	onlineupdate/source/update/updater/updater \
-	onlineupdate/source/update/common/pathhash \
-	onlineupdate/source/update/common/readstrings \
-	onlineupdate/source/update/common/uachelper \
-	onlineupdate/source/update/common/updatehelper \
-	onlineupdate/source/update/common/updatelogging \
 	$(if $(filter WNT,$(OS)),\
 		onlineupdate/source/update/updater/loaddlls \
 		onlineupdate/source/update/updater/progressui_win \

onlineupdate/Module_onlineupdate.mk

@@ -13,6 +13,7 @@ $(eval $(call gb_Module_Module,onlineupdate))
 ifneq ($(ENABLE_ONLINE_UPDATE_MAR),)
 $(eval $(call gb_Module_add_targets,onlineupdate,\
 	StaticLibrary_libmar \
+	StaticLibrary_updatehelper \
 	$(if $(filter WNT,$(OS)),\
 		StaticLibrary_winhelper )\
 	Executable_mar \

onlineupdate/StaticLibrary_updatehelper.mk

+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_StaticLibrary_StaticLibrary,updatehelper))
+
+$(eval $(call gb_StaticLibrary_set_include,updatehelper,\
+	-I$(SRCDIR)/onlineupdate/inc/ \
+	-I$(SRCDIR)/onlineupdate/source/update/common \
+	$$(INCLUDE) \
+))
+
+$(eval $(call gb_StaticLibrary_add_defs,updatehelper,\
+	-DUNICODE \
+	-DNSS3 \
+	-DVERIFY_MAR_SIGNATURE \
+))
+
+$(eval $(call gb_StaticLibrary_add_exception_objects,updatehelper,\
+	onlineupdate/source/update/common/pathhash \
+	onlineupdate/source/update/common/readstrings \
+	onlineupdate/source/update/common/uachelper \
+	onlineupdate/source/update/common/updatehelper \
+	onlineupdate/source/update/common/updatelogging \
+))
+
+# vim:set shiftwidth=4 tabstop=4 noexpandtab: */

onlineupdate/source/update/common/readstrings.h

@@ -10,7 +10,6 @@
 #define MAX_TEXT_LEN 600
 
 #ifdef _WIN32
-# define UNICODE
 # include <windows.h>
   typedef WCHAR NS_tchar;
 #else