clang-tidy performance-unnecessary-value-param

Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

UnoControls/source/controls/OConnectionPointHelper.cxx

@@ -38,7 +38,7 @@ namespace unocontrols{
 OConnectionPointHelper::OConnectionPointHelper(
     Mutex&                              aMutex                      ,
     OConnectionPointContainerHelper*    pContainerImplementation    ,
-    Type                                aType
+    Type const &                        aType
 )   : m_aSharedMutex                ( aMutex                    )
     , m_oContainerWeakReference     ( pContainerImplementation  )
     , m_pContainerImplementation    ( pContainerImplementation  )

UnoControls/source/inc/OConnectionPointHelper.hxx

@@ -42,7 +42,7 @@ public:
 
     OConnectionPointHelper( ::osl::Mutex&                       aMutex                      ,
                             OConnectionPointContainerHelper*    pContainerImplementation    ,
-                            css::uno::Type                       aType                       );
+                            css::uno::Type const &              aType                       );
 
     virtual ~OConnectionPointHelper() override;
 

avmedia/inc/mediacontrol.hxx

@@ -51,7 +51,7 @@ public:
     const Size&         getMinSizePixel() const;
 
     void                setState( const MediaItem& rItem );
-    void                UpdateURLField(MediaItem maItem);
+    void                UpdateURLField( MediaItem const & maItem );
 
 protected:
 

avmedia/source/framework/MediaControlBase.cxx

@@ -39,7 +39,7 @@ MediaControlBase::MediaControlBase()
 {
 }
 
-void MediaControlBase::UpdateTimeField( MediaItem aMediaItem, double fTime )
+void MediaControlBase::UpdateTimeField( MediaItem const & aMediaItem, double fTime )
 {
     if( !aMediaItem.getURL().isEmpty())
     {
@@ -57,7 +57,7 @@ void MediaControlBase::UpdateTimeField( MediaItem aMediaItem, double fTime )
     }
 }
 
-void MediaControlBase::UpdateVolumeSlider( MediaItem aMediaItem )
+void MediaControlBase::UpdateVolumeSlider( MediaItem const & aMediaItem )
 {
     if( aMediaItem.getURL().isEmpty() )
         mpVolumeSlider->Disable();
@@ -70,7 +70,7 @@ void MediaControlBase::UpdateVolumeSlider( MediaItem aMediaItem )
     }
 }
 
-void MediaControlBase::UpdateTimeSlider( MediaItem aMediaItem )
+void MediaControlBase::UpdateTimeSlider( MediaItem const & aMediaItem )
 {
     if( aMediaItem.getURL().isEmpty() )
         mpTimeSlider->Disable();
@@ -211,7 +211,7 @@ void MediaControlBase::UpdateToolBoxes(MediaItem aMediaItem)
     }
 }
 
-void MediaControlBase::SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem aItem, sal_uInt16 nId)
+void MediaControlBase::SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem const & aItem, sal_uInt16 nId)
 {
     switch( nId )
     {

avmedia/source/framework/mediacontrol.cxx

@@ -168,7 +168,7 @@ const Size& MediaControl::getMinSizePixel() const
     return maMinSize;
 }
 
-void MediaControl::UpdateURLField(MediaItem tempItem)
+void MediaControl::UpdateURLField(MediaItem const & tempItem)
 {
     const OUString aURL( AvmResId(AVMEDIA_MEDIA_PATH) + ":  " + tempItem.getURL() ) ;
     mpMediaPath->SetText(aURL);

basic/source/classes/sbunoobj.cxx

@@ -4219,7 +4219,7 @@ class ModuleInvocationProxy : public WeakImplHelper< XInvocation, XComponent >
     ::comphelper::OInterfaceContainerHelper2 m_aListeners;
 
 public:
-    ModuleInvocationProxy( const OUString& aPrefix, SbxObjectRef xScopeObj );
+    ModuleInvocationProxy( OUString const & aPrefix, SbxObjectRef const & xScopeObj );
 
     // XInvocation
     virtual Reference< XIntrospectionAccess > SAL_CALL getIntrospection() override;
@@ -4239,7 +4239,7 @@ public:
     virtual void SAL_CALL removeEventListener( const Reference< XEventListener >& aListener ) override;
 };
 
-ModuleInvocationProxy::ModuleInvocationProxy( const OUString& aPrefix, SbxObjectRef xScopeObj )
+ModuleInvocationProxy::ModuleInvocationProxy( OUString const & aPrefix, SbxObjectRef const & xScopeObj )
     : m_aMutex()
     , m_aPrefix( aPrefix + "_" )
     , m_xScopeObj( xScopeObj )

chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx

@@ -34,6 +34,7 @@
 #include <com/sun/star/chart/ChartRegressionCurveType.hpp>
 #include <com/sun/star/chart2/data/XDataProvider.hpp>
 #include <com/sun/star/chart2/data/XRangeXMLConversion.hpp>
+#include <utility>
 
 using namespace ::com::sun::star;
 using ::com::sun::star::uno::Any;
@@ -216,7 +217,7 @@ WrappedConstantErrorLowProperty::WrappedConstantErrorLowProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< double >( "ConstantErrorLow"
-            , uno::Any( 0.0 ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( 0.0 ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -266,7 +267,7 @@ WrappedConstantErrorHighProperty::WrappedConstantErrorHighProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< double >( "ConstantErrorHigh"
-            , uno::Any( 0.0 ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( 0.0 ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -312,7 +313,7 @@ public:
 WrappedMeanValueProperty::WrappedMeanValueProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
-        : WrappedStatisticProperty< bool >( "MeanValue", uno::Any( false ), spChart2ModelContact, ePropertyType  )
+        : WrappedStatisticProperty< bool >( "MeanValue", uno::Any( false ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -353,7 +354,7 @@ WrappedErrorCategoryProperty::WrappedErrorCategoryProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< css::chart::ChartErrorCategory >( "ErrorCategory"
-            , uno::Any( css::chart::ChartErrorCategory_NONE ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( css::chart::ChartErrorCategory_NONE ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -450,7 +451,7 @@ WrappedPercentageErrorProperty::WrappedPercentageErrorProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< double >( "PercentageError"
-            , uno::Any( 0.0 ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( 0.0 ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -500,7 +501,7 @@ WrappedErrorMarginProperty::WrappedErrorMarginProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< double >( "ErrorMargin"
-            , uno::Any( 0.0 ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( 0.0 ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -547,7 +548,7 @@ WrappedErrorIndicatorProperty::WrappedErrorIndicatorProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< css::chart::ChartErrorIndicatorType >( "ErrorIndicator"
-            , uno::Any( css::chart::ChartErrorIndicatorType_NONE ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( css::chart::ChartErrorIndicatorType_NONE ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -616,7 +617,7 @@ WrappedErrorBarStyleProperty::WrappedErrorBarStyleProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< sal_Int32 >( "ErrorBarStyle"
-            , uno::Any( css::chart::ErrorBarStyle::NONE ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( css::chart::ErrorBarStyle::NONE ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -661,7 +662,7 @@ WrappedErrorBarRangePositiveProperty::WrappedErrorBarRangePositiveProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< OUString >( "ErrorBarRangePositive"
-            , uno::Any( OUString() ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( OUString() ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -724,7 +725,7 @@ WrappedErrorBarRangeNegativeProperty::WrappedErrorBarRangeNegativeProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< OUString >( "ErrorBarRangeNegative"
-            , uno::Any( OUString() ), spChart2ModelContact, ePropertyType  )
+            , uno::Any( OUString() ), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -784,7 +785,7 @@ WrappedRegressionCurvesProperty::WrappedRegressionCurvesProperty(
     std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
     tSeriesOrDiagramPropertyType ePropertyType )
         : WrappedStatisticProperty< css::chart::ChartRegressionCurveType >( "RegressionCurves"
-        , lcl_getRegressionDefault(), spChart2ModelContact, ePropertyType  )
+        , lcl_getRegressionDefault(), std::move(spChart2ModelContact), ePropertyType  )
 {
 }
 
@@ -852,7 +853,7 @@ WrappedStatisticPropertySetProperty::WrappedStatisticPropertySetProperty(
             : (ePropertySetType == PROPERTY_SET_TYPE_ERROR_BAR)
               ? OUString("DataErrorProperties")
               : OUString("DataMeanValueProperties")
-            , uno::Any(), spChart2ModelContact, ePropertyType  )
+            , uno::Any(), std::move(spChart2ModelContact), ePropertyType  )
         , m_eType( ePropertySetType )
 {
 }

chart2/source/controller/inc/uiobject.hxx

@@ -19,7 +19,7 @@ class ChartUIObject : public UIObject
 {
 public:
 
-    ChartUIObject(VclPtr<chart::ChartWindow> xChartWindow,
+    ChartUIObject(const VclPtr<chart::ChartWindow>& xChartWindow,
             const OUString& rCID);
 
     StringMap get_state() override;
@@ -48,7 +48,7 @@ class ChartWindowUIObject : public WindowUIObject
 
 public:
 
-    ChartWindowUIObject(VclPtr<chart::ChartWindow> xChartWindow);
+    ChartWindowUIObject(const VclPtr<chart::ChartWindow>& xChartWindow);
 
     virtual StringMap get_state() override;
 

chart2/source/controller/uitest/uiobject.cxx

@@ -20,7 +20,7 @@
 #include <algorithm>
 #include <iterator>
 
-ChartUIObject::ChartUIObject(VclPtr<chart::ChartWindow> xChartWindow,
+ChartUIObject::ChartUIObject(const VclPtr<chart::ChartWindow>& xChartWindow,
         const OUString& rCID):
     maCID(rCID),
     mxChartWindow(xChartWindow)
@@ -92,7 +92,7 @@ OUString ChartUIObject::get_type() const
     return OUString("ChartUIObject for type: ");
 }
 
-ChartWindowUIObject::ChartWindowUIObject(VclPtr<chart::ChartWindow> xChartWindow):
+ChartWindowUIObject::ChartWindowUIObject(const VclPtr<chart::ChartWindow>& xChartWindow):
     WindowUIObject(xChartWindow),
     mxChartWindow(xChartWindow)
 {

chart2/source/view/inc/3DChartObjects.hxx

@@ -105,7 +105,7 @@ class ScreenText : public Renderable3DObject
 {
 public:
     ScreenText(OpenGL3DRenderer* pRenderer, TextCache& rTextCache,
-        const OUString& rStr, glm::vec4 rColor, sal_uInt32 nId, bool bIs3dText = false);
+        const OUString& rStr, const glm::vec4& rColor, sal_uInt32 nId, bool bIs3dText = false);
 
     virtual void render() override;
     void setPosition(const glm::vec2& rTopLeft, const glm::vec2& rBottomRight,

chart2/source/view/main/3DChartObjects.cxx

@@ -127,7 +127,7 @@ void Text::setPosition(const glm::vec3& rTopLeft, const glm::vec3& rTopRight, co
 }
 
 ScreenText::ScreenText(OpenGL3DRenderer* pRenderer, TextCache& rTextCache,
-        const OUString& rStr, glm::vec4 rColor, sal_uInt32 nId, bool bIs3dText):
+        const OUString& rStr, const glm::vec4& rColor, sal_uInt32 nId, bool bIs3dText):
     Renderable3DObject(pRenderer, nId),
     maText(rTextCache.getText(rStr,bIs3dText)),
     maColor(rColor)

comphelper/source/container/namecontainer.cxx

@@ -34,7 +34,7 @@ namespace comphelper
     class NameContainer : public ::cppu::WeakImplHelper< css::container::XNameContainer >
     {
     public:
-        explicit NameContainer( css::uno::Type aType );
+        explicit NameContainer( const css::uno::Type& aType );
 
         // XNameContainer
         virtual void SAL_CALL insertByName( const OUString& aName, const css::uno::Any& aElement ) override;
@@ -66,7 +66,7 @@ using namespace ::com::sun::star::container;
 using namespace ::com::sun::star::lang;
 
 
-NameContainer::NameContainer( css::uno::Type aType )
+NameContainer::NameContainer( const css::uno::Type& aType )
 : maType( aType )
 {
 }

cui/source/dialogs/scriptdlg.cxx

@@ -1405,7 +1405,7 @@ OUString GetErrorMessage( const css::uno::Any& aException )
 
 }
 
-SvxScriptErrorDialog::SvxScriptErrorDialog( css::uno::Any aException )
+SvxScriptErrorDialog::SvxScriptErrorDialog( css::uno::Any const & aException )
     : m_sMessage()
 {
     SolarMutexGuard aGuard;

cui/source/inc/scriptdlg.hxx

@@ -188,7 +188,7 @@ private:
 
 public:
 
-    SvxScriptErrorDialog( css::uno::Any aException );
+    SvxScriptErrorDialog( css::uno::Any const & aException );
 
     virtual ~SvxScriptErrorDialog() override;
 

editeng/source/editeng/eertfpar.cxx

@@ -18,6 +18,7 @@
  */
 
 #include <comphelper/string.hxx>
+#include <utility>
 #include <vcl/wrkwin.hxx>
 #include <vcl/dialog.hxx>
 #include <vcl/msgbox.hxx>
@@ -68,7 +69,7 @@ RtfImportInfo::~RtfImportInfo()
 EditRTFParser::EditRTFParser(
     SvStream& rIn, EditSelection aSel, SfxItemPool& rAttrPool, EditEngine* pEditEngine) :
     SvxRTFParser(rAttrPool, rIn, nullptr),
-    aCurSel(aSel),
+    aCurSel(std::move(aSel)),
     mpEditEngine(pEditEngine),
     aRTFMapMode(MapUnit::MapTwip),
     nDefFont(0),

formula/source/core/api/FormulaCompiler.cxx

@@ -145,7 +145,7 @@ class OpCodeList
 {
 public:
 
-    OpCodeList( sal_uInt16, FormulaCompiler::NonConstOpCodeMapPtr,
+    OpCodeList( sal_uInt16, const FormulaCompiler::NonConstOpCodeMapPtr&,
             FormulaCompiler::SeparatorType = FormulaCompiler::SeparatorType::SEMICOLON_BASE );
 
 private:
@@ -157,7 +157,7 @@ private:
     ResStringArray maStringList;
 };
 
-OpCodeList::OpCodeList( sal_uInt16 nRID, FormulaCompiler::NonConstOpCodeMapPtr xMap,
+OpCodeList::OpCodeList( sal_uInt16 nRID, const FormulaCompiler::NonConstOpCodeMapPtr& xMap,
         FormulaCompiler::SeparatorType eSepType )
     : meSepType(eSepType)
     , maStringList(ResId(nRID, *ResourceManager::getResManager()))

include/avmedia/MediaControlBase.hxx

@@ -72,10 +72,10 @@ protected:
     static Image GetImage(sal_Int32 nImageId);
     virtual void InitializeWidgets();
     virtual void UpdateToolBoxes( MediaItem aMediaItem );
-    void UpdateVolumeSlider( MediaItem aMediaItem );
-    void UpdateTimeSlider( MediaItem aMediaItem );
-    void UpdateTimeField( MediaItem aMediaItem, double fTime );
-    void SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem aItem, sal_uInt16 nId);
+    void UpdateVolumeSlider( MediaItem const & aMediaItem );
+    void UpdateTimeSlider( MediaItem const & aMediaItem );
+    void UpdateTimeField( MediaItem const & aMediaItem, double fTime );
+    void SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem const & aItem, sal_uInt16 nId);
 };
 
 }

include/oox/core/relationshandler.hxx

@@ -44,7 +44,7 @@ class RelationsFragment : public FragmentHandler
 public:
     explicit            RelationsFragment(
                             XmlFilterBase& rFilter,
-                            RelationsRef xRelations );
+                            const RelationsRef& xRelations );
 
     virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
                         createFastChildContext(

include/oox/drawingml/connectorshapecontext.hxx

@@ -34,7 +34,7 @@ namespace oox { namespace drawingml {
 class OOX_DLLPUBLIC ConnectorShapeContext : public ShapeContext
 {
 public:
-    ConnectorShapeContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pGroupShapePtr );
+    ConnectorShapeContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pGroupShapePtr );
     virtual ~ConnectorShapeContext() override;
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 };

include/oox/drawingml/graphicshapecontext.hxx

@@ -36,7 +36,7 @@ namespace oox { namespace drawingml {
 class OOX_DLLPUBLIC GraphicShapeContext : public ShapeContext
 {
 public:
-    GraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr );
+    GraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr );
 
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 };
@@ -45,7 +45,7 @@ public:
 class OOX_DLLPUBLIC GraphicalObjectFrameContext : public ShapeContext
 {
 public:
-    GraphicalObjectFrameContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr, bool bEmbedShapesInChart );
+    GraphicalObjectFrameContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr, bool bEmbedShapesInChart );
 
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
     virtual void onEndElement() override;
@@ -59,7 +59,7 @@ private:
 class OleObjectGraphicDataContext : public ShapeContext
 {
 public:
-    OleObjectGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pShapePtr );
+    OleObjectGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pShapePtr );
     virtual ~OleObjectGraphicDataContext() override;
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 
@@ -72,7 +72,7 @@ class DiagramGraphicDataContext
     : public ShapeContext
 {
 public:
-    DiagramGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pShapePtr );
+    DiagramGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pShapePtr );
     virtual ~DiagramGraphicDataContext() override;
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 

include/oox/ppt/pptgraphicshapecontext.hxx

@@ -36,7 +36,7 @@ class PPTGraphicShapeContext : public ::oox::drawingml::GraphicShapeContext
     SlidePersistPtr     mpSlidePersistPtr;
 
 public:
-    PPTGraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, oox::drawingml::ShapePtr pMasterShapePtr, oox::drawingml::ShapePtr pShapePtr );
+    PPTGraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, const oox::drawingml::ShapePtr& pMasterShapePtr, const oox::drawingml::ShapePtr& pShapePtr );
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 };
 

include/oox/ppt/pptshapecontext.hxx

@@ -36,7 +36,7 @@ class PPTShapeContext : public ::oox::drawingml::ShapeContext
     SlidePersistPtr     mpSlidePersistPtr;
 
 public:
-    PPTShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, oox::drawingml::ShapePtr pMasterShapePtr, oox::drawingml::ShapePtr pShapePtr );
+    PPTShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, const oox::drawingml::ShapePtr& pMasterShapePtr, const oox::drawingml::ShapePtr& pShapePtr );
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
 };
 

include/oox/ppt/pptshapegroupcontext.hxx

@@ -47,8 +47,8 @@ public:
         ::oox::core::ContextHandler2Helper& rParent,
         const oox::ppt::SlidePersistPtr& rSlidePersistPtr,
         const oox::ppt::ShapeLocation eShapeLocation,
-        oox::drawingml::ShapePtr pMasterShapePtr,
-        oox::drawingml::ShapePtr pGroupShapePtr );
+        const oox::drawingml::ShapePtr& pMasterShapePtr,
+        const oox::drawingml::ShapePtr& pGroupShapePtr );
 
     virtual ::oox::core::ContextHandlerRef
         onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;

include/oox/ppt/slidefragmenthandler.hxx

@@ -37,7 +37,7 @@ namespace oox { namespace ppt {
 class SlideFragmentHandler : public ::oox::core::FragmentHandler2
 {
 public:
-    SlideFragmentHandler( ::oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, SlidePersistPtr pPersistPtr, const ShapeLocation eShapeLocation );
+    SlideFragmentHandler( ::oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, const SlidePersistPtr& pPersistPtr, const ShapeLocation eShapeLocation );
     virtual ~SlideFragmentHandler() override;
 
     virtual void finalizeImport() override;

include/svtools/svlbitm.hxx

@@ -229,8 +229,8 @@ class SVT_DLLPUBLIC SvLBoxContextBmp : public SvLBoxItem
 {
     std::unique_ptr<SvLBoxContextBmp_Impl>  m_pImpl;
 public:
-    SvLBoxContextBmp(Image aBmp1,
-                     Image aBmp2,
+    SvLBoxContextBmp(const Image& aBmp1,
+                     const Image& aBmp2,
                      bool bExpanded);
     SvLBoxContextBmp();
     virtual ~SvLBoxContextBmp() override;

include/svx/cube3d.hxx

@@ -77,7 +77,7 @@ protected:
     virtual sdr::contact::ViewContact* CreateObjectSpecificViewContact() override;
 
 public:
-    E3dCubeObj(E3dDefaultAttributes& rDefault, basegfx::B3DPoint aPos, const basegfx::B3DVector& r3DSize);
+    E3dCubeObj(E3dDefaultAttributes& rDefault, const basegfx::B3DPoint& aPos, const basegfx::B3DVector& r3DSize);
     E3dCubeObj();
 
     virtual sal_uInt16 GetObjIdentifier() const override;

include/vcl/uitest/uiobject.hxx

@@ -105,7 +105,7 @@ class UITEST_DLLPUBLIC WindowUIObject : public UIObject
 
 public:
 
-    WindowUIObject(VclPtr<vcl::Window> xWindow);
+    WindowUIObject(const VclPtr<vcl::Window>& xWindow);
 
     virtual StringMap get_state() override;
 
@@ -138,7 +138,7 @@ class UITEST_DLLPUBLIC ButtonUIObject : public WindowUIObject
     VclPtr<Button> mxButton;
 public:
 
-    ButtonUIObject(VclPtr<Button> xButton);
+    ButtonUIObject(const VclPtr<Button>& xButton);
     virtual ~ButtonUIObject() override;
 
     virtual StringMap get_state() override;
@@ -159,7 +159,7 @@ class UITEST_DLLPUBLIC DialogUIObject : public WindowUIObject
 
 public:
 
-    DialogUIObject(VclPtr<Dialog> xDialog);
+    DialogUIObject(const VclPtr<Dialog>& xDialog);
     virtual ~DialogUIObject() override;
 
     virtual StringMap get_state() override;
@@ -177,7 +177,7 @@ class UITEST_DLLPUBLIC EditUIObject : public WindowUIObject
 
 public:
 
-    EditUIObject(VclPtr<Edit> xEdit);
+    EditUIObject(const VclPtr<Edit>& xEdit);
     virtual ~EditUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -199,7 +199,7 @@ private:
     VclPtr<CheckBox> mxCheckBox;
 
 public:
-    CheckBoxUIObject(VclPtr<CheckBox> xCheckbox);
+    CheckBoxUIObject(const VclPtr<CheckBox>& xCheckbox);
     virtual ~CheckBoxUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -220,7 +220,7 @@ private:
     VclPtr<RadioButton> mxRadioButton;
 
 public:
-    RadioButtonUIObject(VclPtr<RadioButton> xCheckbox);
+    RadioButtonUIObject(const VclPtr<RadioButton>& xCheckbox);
     virtual ~RadioButtonUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -240,7 +240,7 @@ class UITEST_DLLPUBLIC TabPageUIObject : public WindowUIObject
 private:
     VclPtr<TabPage> mxTabPage;
 public:
-    TabPageUIObject(VclPtr<TabPage> xTabPage);
+    TabPageUIObject(const VclPtr<TabPage>& xTabPage);
     virtual ~TabPageUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -262,7 +262,7 @@ private:
 
 public:
 
-    ListBoxUIObject(VclPtr<ListBox> xListBox);
+    ListBoxUIObject(const VclPtr<ListBox>& xListBox);
     virtual ~ListBoxUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -287,7 +287,7 @@ private:
 
 public:
 
-    ComboBoxUIObject(VclPtr<ComboBox> xListBox);
+    ComboBoxUIObject(const VclPtr<ComboBox>& xListBox);
     virtual ~ComboBoxUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -309,7 +309,7 @@ private:
 
 public:
 
-    SpinUIObject(VclPtr<SpinButton> xSpinButton);
+    SpinUIObject(const VclPtr<SpinButton>& xSpinButton);
     virtual ~SpinUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -330,7 +330,7 @@ class UITEST_DLLPUBLIC SpinFieldUIObject : public EditUIObject
 
 public:
 
-    SpinFieldUIObject(VclPtr<SpinField> xEdit);
+    SpinFieldUIObject(const VclPtr<SpinField>& xEdit);
     virtual ~SpinFieldUIObject() override;
 
     virtual void execute(const OUString& rAction,
@@ -352,7 +352,7 @@ private:
 
 public:
 
-    TabControlUIObject(VclPtr<TabControl> mxTabControl);
+    TabControlUIObject(const VclPtr<TabControl>& mxTabControl);
     virtual ~TabControlUIObject() override;
 
     virtual void execute(const OUString& rAction,

oox/inc/drawingml/table/tablecontext.hxx

@@ -29,7 +29,7 @@ class TableProperties;
 class TableContext : public ShapeContext
 {
 public:
-    TableContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pShapePtr );
+    TableContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pShapePtr );
     virtual ~TableContext() override;
 
     virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;

oox/inc/drawingml/textbody.hxx

@@ -40,7 +40,7 @@ class TextBody
 {
 public:
     TextBody();
-    TextBody( TextBodyPtr pBody );
+    TextBody( const TextBodyPtr& pBody );
     ~TextBody();
 
     const TextParagraphVector&          getParagraphs() const { return maParagraphs; }

oox/source/core/relationshandler.cxx

@@ -50,7 +50,7 @@ OUString lclGetRelationsPath( const OUString& rFragmentPath )
 
 } // namespace
 
-RelationsFragment::RelationsFragment( XmlFilterBase& rFilter, RelationsRef xRelations ) :
+RelationsFragment::RelationsFragment( XmlFilterBase& rFilter, const RelationsRef& xRelations ) :
     FragmentHandler( rFilter, lclGetRelationsPath( xRelations->getFragmentPath() ), xRelations ),
     mxRelations( xRelations )
 {

oox/source/drawingml/connectorshapecontext.cxx

@@ -42,7 +42,7 @@ using namespace ::com::sun::star::xml::sax;
 namespace oox { namespace drawingml {
 
 ConnectorShapeContext::ConnectorShapeContext( ContextHandler2Helper& rParent,
-        ShapePtr pMasterShapePtr, ShapePtr pGroupShapePtr )
+        const ShapePtr& pMasterShapePtr, const ShapePtr& pGroupShapePtr )
 : ShapeContext( rParent, pMasterShapePtr, pGroupShapePtr )
 {
 }

oox/source/drawingml/graphicshapecontext.cxx

@@ -71,7 +71,7 @@ namespace drawingml {
 
 // CT_Picture
 
-GraphicShapeContext::GraphicShapeContext( ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr )
+GraphicShapeContext::GraphicShapeContext( ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr )
 : ShapeContext( rParent, pMasterShapePtr, pShapePtr )
 {
 }
@@ -121,7 +121,7 @@ ContextHandlerRef GraphicShapeContext::onCreateContext( sal_Int32 aElementToken,
 
 // CT_GraphicalObjectFrameContext
 
-GraphicalObjectFrameContext::GraphicalObjectFrameContext( ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr, bool bEmbedShapesInChart ) :
+GraphicalObjectFrameContext::GraphicalObjectFrameContext( ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr, bool bEmbedShapesInChart ) :
     ShapeContext( rParent, pMasterShapePtr, pShapePtr ),
     mbEmbedShapesInChart( bEmbedShapesInChart ),
     mpParent(&rParent)
@@ -177,7 +177,7 @@ void GraphicalObjectFrameContext::onEndElement()
     }
 }
 
-OleObjectGraphicDataContext::OleObjectGraphicDataContext( ContextHandler2Helper& rParent, ShapePtr xShape ) :
+OleObjectGraphicDataContext::OleObjectGraphicDataContext( ContextHandler2Helper& rParent, const ShapePtr& xShape ) :
     ShapeContext( rParent, ShapePtr(), xShape ),
     mrOleObjectInfo( xShape->setOleObjectType() )
 {
@@ -237,7 +237,7 @@ ContextHandlerRef OleObjectGraphicDataContext::onCreateContext( sal_Int32 nEleme
     return nullptr;
 }