cppcheck: silence warnings in compilerplugins

mostly missing explicit before ctors and
uninitialized member vars

one odd use of std::find
> compilerplugins/clang/implicitboolconversion.cxx
> 800 stlIfFind warning	Suspicious condition.
> The result of find() is an iterator, but it is not properly checked.

Change-Id: Iade53494cd7fe8ddb0e110e431449ae5a517fe3b
Reviewed-on: https://gerrit.libreoffice.org/24398Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

compilerplugins/clang/implicitboolconversion.cxx

@@ -797,7 +797,7 @@ bool ImplicitBoolConversion::TraverseCXXStdInitializerListExpr(
     bool ret = RecursiveASTVisitor::TraverseCXXStdInitializerListExpr(expr);
     assert(!nested.empty());
     for (auto i: nested.top()) {
-        if (!std::find(e->begin(), e->end(), i)) {
+        if (std::find(e->begin(), e->end(), i) == e->end()) {
             reportWarning(i);
         }
     }

compilerplugins/clang/memoryvar.cxx

@@ -25,7 +25,7 @@ class MemoryVar:
     public RecursiveASTVisitor<MemoryVar>, public loplugin::Plugin
 {
 public:
-    explicit MemoryVar(InstantiationData const & data): Plugin(data) {}
+    explicit MemoryVar(InstantiationData const & data): Plugin(data), mbChecking(false) {}
 
     virtual void run() override {
         TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());

compilerplugins/clang/oncevar.cxx

@@ -28,7 +28,7 @@ class OnceVar:
     public RecursiveASTVisitor<OnceVar>, public loplugin::Plugin
 {
 public:
-    explicit OnceVar(InstantiationData const & data): Plugin(data) {}
+    explicit OnceVar(InstantiationData const & data): Plugin(data), mbChecking(false) {}
 
     virtual void run() override {
         TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());

compilerplugins/clang/passstuffbyref.cxx

@@ -31,7 +31,7 @@ class PassStuffByRef:
     public RecursiveASTVisitor<PassStuffByRef>, public loplugin::Plugin
 {
 public:
-    explicit PassStuffByRef(InstantiationData const & data): Plugin(data) {}
+    explicit PassStuffByRef(InstantiationData const & data): Plugin(data), mbInsideFunctionDecl(false), mbFoundDisqualifier(false) {}
 
     virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
 

compilerplugins/clang/plugin.hxx

@@ -112,7 +112,7 @@ class RewritePlugin
             : public Rewriter::RewriteOptions
             {
             RewriteOptions();
-            RewriteOptions( RewriteOption option );
+            explicit RewriteOptions( RewriteOption option );
             const int flags;
             };
         // syntactic sugar to be able to write 'RemoveLineIfEmpty | RemoveWholeStatement'

compilerplugins/clang/sallogareas.cxx

@@ -27,7 +27,7 @@ if appropriate.
 */
 
 SalLogAreas::SalLogAreas( const InstantiationData& data )
-    : Plugin( data )
+    : Plugin(data), inFunction(nullptr)
     {
     }
 

compilerplugins/clang/staticanonymous.cxx

@@ -21,7 +21,7 @@ class StaticAnonymous
     , public Plugin
     {
     public:
-        StaticAnonymous( const InstantiationData& data );
+        explicit StaticAnonymous( const InstantiationData& data );
         virtual void run() override;
         bool VisitFunctionDecl( FunctionDecl* func );