loplugin:unnecessaryvirtual

Change-Id: I3e6424e10eade04951f8ab24bb61af4ce19d1204
Reviewed-on: https://gerrit.libreoffice.org/64113
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/unnecessaryvirtual-dead.results

@@ -16,13 +16,15 @@ vcl/inc/salmenu.hxx:80
     void SalMenu::RemoveMenuBarButton(unsigned short,)
 vcl/inc/salobj.hxx:48
     void SalObject::Enable(_Bool,)
+vcl/inc/unx/saldata.hxx:68
+    void X11SalData::initNWF()
 vcl/inc/unx/saldata.hxx:69
     void X11SalData::deInitNWF()
-writerfilter/source/ooxml/OOXMLFactory.hxx:71
-    void writerfilter::ooxml::OOXMLFactory_ns::startAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
 writerfilter/source/ooxml/OOXMLFactory.hxx:72
-    void writerfilter::ooxml::OOXMLFactory_ns::charactersAction(class writerfilter::ooxml::OOXMLFastContextHandler *,const class rtl::OUString &,)
+    void writerfilter::ooxml::OOXMLFactory_ns::startAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
 writerfilter/source/ooxml/OOXMLFactory.hxx:73
-    void writerfilter::ooxml::OOXMLFactory_ns::endAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
+    void writerfilter::ooxml::OOXMLFactory_ns::charactersAction(class writerfilter::ooxml::OOXMLFastContextHandler *,const class rtl::OUString &,)
 writerfilter/source/ooxml/OOXMLFactory.hxx:74
+    void writerfilter::ooxml::OOXMLFactory_ns::endAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
+writerfilter/source/ooxml/OOXMLFactory.hxx:75
     void writerfilter::ooxml::OOXMLFactory_ns::attributeAction(class writerfilter::ooxml::OOXMLFastContextHandler *,int,const class tools::SvRef<class writerfilter::ooxml::OOXMLValue> &,)

include/sfx2/basedlgs.hxx

@@ -134,7 +134,7 @@ protected:
     virtual ~SfxModelessDialogController() override;
 
 public:
-    virtual void            FillInfo(SfxChildWinInfo&) const;
+    void                    FillInfo(SfxChildWinInfo&) const;
     virtual void            Activate() {}
     void                    Initialize (SfxChildWinInfo const * pInfo);
     void                    Close();
@@ -235,7 +235,7 @@ public:
         const OUString& rUIXMLDescription = OUString("sfx/ui/singletabdialog.ui"),
         const OString& rID = OString("SingleTabDialog"));
 
-    virtual weld::Container* get_content_area() { return m_xContainer.get(); }
+    weld::Container* get_content_area() { return m_xContainer.get(); }
 
     virtual             ~SfxSingleTabDialogController() override;
 

include/sfx2/controlwrapper.hxx

@@ -212,8 +212,8 @@ public:
     explicit     ListBoxWrapper( ListBox& rListBox, const MapEntryType* pMap ) :
                             SingleControlWrapper< ListBox, ValueT >( rListBox ), MapperType( WRAPPER_LISTBOX_ENTRY_NOTFOUND, pMap ) {}
 
-    virtual ValueT      GetControlValue() const override;
-    virtual void        SetControlValue( ValueT nValue ) override;
+    ValueT       GetControlValue() const override;
+    void         SetControlValue( ValueT nValue ) override;
 };
 
 

include/sfx2/tabdlg.hxx

@@ -102,8 +102,6 @@ protected:
     virtual short               Ok();
     // Is deleted in Sfx!
     virtual SfxItemSet*         CreateInputItemSet( sal_uInt16 nId );
-    // Is not deleted in Sfx!
-    virtual void                RefreshInputSet();
     virtual void                PageCreated( sal_uInt16 nId, SfxTabPage &rPage );
 
     VclPtr<VclButtonBox>   m_pActionArea;

include/svtools/valueset.hxx

@@ -489,7 +489,7 @@ public:
     virtual void    StyleUpdated() override;
     virtual OUString RequestHelp(tools::Rectangle& rHelpRect) override;
 
-    virtual void    Select();
+    void            Select();
     virtual void    UserDraw( const UserDrawEvent& rUDEvt );
 
     OUString const & GetText() const { return maText; }

sc/source/ui/inc/condformatdlgentry.hxx

@@ -79,7 +79,7 @@ public:
 
     virtual bool EventNotify( NotifyEvent& rNEvt ) override;
 
-    virtual void SetPos(const ScAddress& rPos) { maPos = rPos; };
+    void SetPos(const ScAddress& rPos) { maPos = rPos; };
     bool IsSelected() const { return mbActive;}
     void SetIndex(sal_Int32 nIndex);
     void SetHeight();

sd/source/ui/animations/CustomAnimationList.hxx

@@ -99,7 +99,7 @@ protected:
     // drag & drop
     virtual DragDropMode NotifyStartDrag( TransferDataContainer& rData, SvTreeListEntry* pEntry ) override;
     virtual sal_Int8     AcceptDrop( const AcceptDropEvent& rEvt ) override;
-    virtual void         ReorderEffectsInUiDuringDragOver( SvTreeListEntry* pOverEntry);
+            void         ReorderEffectsInUiDuringDragOver( SvTreeListEntry* pOverEntry);
     virtual sal_Int8     ExecuteDrop( const ExecuteDropEvent& rEvt ) override;
     virtual void         DragFinished( sal_Int8 nDropAction ) override;
 

sfx2/source/dialog/tabdlg.cxx

@@ -872,20 +872,6 @@ SfxItemSet* SfxTabDialog::CreateInputItemSet( sal_uInt16 )
 }
 
 
-void SfxTabDialog::RefreshInputSet()
-
-/*  [Description]
-
-    Default implementation of the virtual Method.
-    This is called, when <SfxTabPage::DeactivatePage(SfxItemSet *)>
-    returns <DeactivateRC::RefreshSet>.
-*/
-
-{
-    SAL_INFO ( "sfx.dialog", "RefreshInputSet not implemented" );
-}
-
-
 IMPL_LINK_NOARG(SfxTabDialog, OkHdl, Button*, void)
 
 /*  [Description]
@@ -1259,7 +1245,6 @@ IMPL_LINK( SfxTabDialog, DeactivatePageHdl, TabControl *, pTabCtrl, bool )
 
     if ( nRet & DeactivateRC::RefreshSet )
     {
-        RefreshInputSet();
         // Flag all Pages as to be initialized as new
 
         for (auto const& elem : m_pImpl->aData)