Kaydet (Commit) 0b38b731 authored tarafından Justin Luth's avatar Justin Luth Kaydeden (comit) Andras Timar

misleading comment: not every sheet is examined

In fact, if there are no sheet-local names defined, then the loop
will not even be entered. Only the sheets that actually contain
the desired item will be iterated through.

Change-Id: I1fa94d8b9190f43b2896a002acdec18397225395
Reviewed-on: https://gerrit.libreoffice.org/54742Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarAndras Timar <andras.timar@collabora.com>
üst c9e092c3
......@@ -645,7 +645,7 @@ void XclExpNameManagerImpl::CreateUserNames()
if (!FindNamedExpIndex(SCTAB_GLOBAL, itr->second->GetIndex()))
CreateName(SCTAB_GLOBAL, *itr->second);
//look at every sheet for local range names
//look at sheets containing local range names
ScRangeName::TabNameCopyMap rLocalNames;
ScRangeName::TabNameCopyMap::iterator tabIt = rLocalNames.begin(), tabItEnd = rLocalNames.end();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment