Kaydet (Commit) 0623f3a8 authored tarafından Miklos Vajna's avatar Miklos Vajna Kaydeden (comit) Michael Meeks

git pre-commit hook: catch copy&pasted author identity

git log --author="Your"

confirms that this happens in practice.

Change-Id: I48633bc9154ebc66fc022938831057bdc3ff76b3
Reviewed-on: https://gerrit.libreoffice.org/47892Reviewed-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
Tested-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
üst 34d8710f
...@@ -109,6 +109,17 @@ sub check_whitespaces($) ...@@ -109,6 +109,17 @@ sub check_whitespaces($)
} }
} }
sub check_author()
{
my $author = `git var GIT_AUTHOR_IDENT`;
chomp $author;
if ($author =~ /^Your Name <you\@example.com>/)
{
print("ERROR: You have a suspicious author identity: '$author'\n");
exit(1);
}
}
sub check_style($) sub check_style($)
{ {
if (! -e "solenv/clang-format/ClangFormat.pm") if (! -e "solenv/clang-format/ClangFormat.pm")
...@@ -266,6 +277,9 @@ check_whitespaces( $against); ...@@ -266,6 +277,9 @@ check_whitespaces( $against);
# fix style in code # fix style in code
check_style($against); check_style($against);
# catch missing author info
check_author();
# all OK # all OK
exit( 0 ); exit( 0 );
# vi:set shiftwidth=4 expandtab: # vi:set shiftwidth=4 expandtab:
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment