• Mike Kaganski's avatar
    tdf#108580: integrate vc_redist.exe into MSI · 61b1d631
    Mike Kaganski yazdı
    ... in InstallUISequense.
    Use --with-vcredist-dir to point to a directory with vc_redist.x64.exe
    and/or vc_redist.x86.exe. Use --without-vcredist-dir (or
    --with-vcredist-dir=no) if you don't want to ship it as part of
    installer and want to silence the configure warning.
    VCRedist 2015 version 14.0.24215.1 is available at
    Since VisualStudio 2015, VC redist merge module that we used before
    started to work differently: it installs the UCRT only on WinXP,
    but not on later OSes (Vista to 8.1) which may lack the UCRT (Win10
    has it out of the box). The merge module only installs VCRuntime on
    those systems, which still leaves us with "api-ms-*.dll is missing"
    gives more information on VCRedist refactoring background.)
    Since commit 71d9a613, we use a
    workaround described at the page mentioned above as "App-local
    deployment of the Universal CRT". We just copy all UCRT DLLs to
    LibreOffice/program. This has a drawback though, that our UCRT
    is not updated by Windows Update, so users would rely on LibreOffice
    updates in case of some vulnerabilities in UCRT (and they could
    even not realize they have that problem).
    MS recommends to install UCRT using EXEs they provide from their
    site. The EXEs install both VCRuntimes and UCRTs, along with
    required patches, for all Windows versions (Windows XP through
    Windows 10, where they only install VCRuntimes); the installed
    libraries are managed by system's update mechanism. But those EXEs
    cannot be used in MSI custom actions inside InstallExecuteSequence,
    because they use MSI themselves.
    So this patch integrates the vc_redist.xXX.exe into MSI binary
    table, and uses custom action to run the EXE after ExecuteAction
    in InstallUISequence. This will show the user a VCRedist install
    window after the main LibreOffice installation finishes; no user
    interaction is required (except for one additional UAC request),
    and errors are ignored.
    Since this installation takes care of both VCRuntime and UCRT,
    we can ultimately drop both the app-local workaround, and
    vcredist merge module (so VCRuntime would also be updated by
    system). The former is done here: this reverts commit
    This approach has its drawback: if one wants to use unattended
    installation (without UI; one example is deployment using
    ActiveDirectory GPO), then InstallUISequence is not run, and so
    VCRedist isn't installed. In this case, one should install
    VCRedist separately. Supposedly this should not be huge problem,
    because this is the case for many existing applications that need
    separate VCRedist deployment in these scenarios, and unattended
    installation is advanced stuff that requires prepared user. A
    notice would be required in release notes and FAQ, though.
    Change-Id: Ia6a16be60af8a08f41ea7c3dbd457d8f89006006
    Reviewed-on: https://gerrit.libreoffice.org/46356Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
    Tested-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
CustomTarget_signing.mk 2.17 KB