• Tor Lillqvist's avatar
    Revert "loplugin:useuniqueptr in SwGrammarContact" · af8d2b51
    Tor Lillqvist yazdı
    This reverts commit 478d967e.
    
    Sadly the change caused a crash in Writer. Stack trace:
    
    > #0  0x00007fffc8b124cc in rtl::OUString::isEmpty() const (this=0x6666000000000000) at /ssd1/lo/fedora/include/rtl/ustring.hxx:646
    > #1  0x00007fffc95ccaa8 in SwWrongList::GetWrongPos(int) const (this=0x5bb5f60, nValue=0)
    >     at /ssd1/lo/fedora/sw/source/core/text/wrong.cxx:199
    > #2  0x00007fffc95cd0d2 in SwWrongList::Move(int, int) (this=0x5bb5f60, nPos=0, nDiff=1)
    >     at /ssd1/lo/fedora/sw/source/core/text/wrong.cxx:274
    > #3  0x00007fffc94caffd in SwGrammarMarkUp::MoveGrammar(int, int) (this=0x5bb5f60, nPos=0, nDiff=1)
    >     at /ssd1/lo/fedora/sw/source/core/text/SwGrammarMarkUp.cxx:41
    > #4  0x00007fffc95af393 in lcl_SetWrong(SwTextFrame&, SwTextNode const&, int, int, bool) (rFrame=..., rNode=..., nPos=0, nCnt=1, bMove=true)
    >     at /ssd1/lo/fedora/sw/source/core/text/txtfrm.cxx:1462
    > #5  0x00007fffc95ad0ba in SwTextFrame::SwClientNotify(SwModify const&, SfxHint const&) (this=0x62f3c50, rModify=..., rHint=...)
    >     at /ssd1/lo/fedora/sw/source/core/text/txtfrm.cxx:1676
    > #6  0x00007fffc8bd96b8 in SwModify::CallSwClientNotify(SfxHint const&) const (this=0x4cef450, rHint=...)
    >     at /ssd1/lo/fedora/sw/inc/calbck.hxx:444
    > #7  0x00007fffc8bd893e in SwModify::ModifyBroadcast(SfxPoolItem const*, SfxPoolItem const*) (this=0x4cef450,
    >     pOldValue=0x0, pNewValue=0x7ffffffed3a8) at /ssd1/lo/fedora/sw/inc/calbck.hxx:201
    > #8  0x00007fffc8bd65d1 in SwModify::NotifyClients(SfxPoolItem const*, SfxPoolItem const*) (this=0x4cef450, pOldValue=0x0, pNewValue=0x7ffffffed3a8) at /ssd1/lo/fedora/sw/source/core/attr/calbck.cxx:199
    > #9  0x00007fffc965ec9f in SwTextNode::InsertText(rtl::OUString const&, SwIndex const&, SwInsertFlags) (this=0x4cef450, rStr="s", rIdx=SwIndex (offset 1), nMode=SwInsertFlags::EMPTYEXPAND) at /ssd1/lo/fedora/sw/source/core/txtnode/ndtxt.cxx:1997
    > #10 0x00007fffc8ef97be in sw::DocumentContentOperationsManager::InsertString(SwPaM const&, rtl::OUString const&, SwInsertFlags) (this=0x4ca2ef0, rRg=SwPaM = {...}, rStr="s", nInsertMode=SwInsertFlags::EMPTYEXPAND)
    >     at /ssd1/lo/fedora/sw/source/core/doc/DocumentContentOperationsManager.cxx:2509
    > #11 0x00007fffc919bf7b in SwEditShell::Insert2(rtl::OUString const&, bool) (this=0x4d8eb90, rStr="s", bForceExpandHints=false)
    >     at /ssd1/lo/fedora/sw/source/core/edit/editsh.cxx:98
    > #12 0x00007fffca1d0cca in SwWrtShell::Insert(rtl::OUString const&) (this=0x4d8eb90, rStr="s")
    >     at /ssd1/lo/fedora/sw/source/uibase/wrtsh/wrtsh1.cxx:224
    > #13 0x00007fffc9e71220 in SwEditWin::FlushInBuffer() (this=0x4d7a3e0) at /ssd1/lo/fedora/sw/source/uibase/docvw/edtwin.cxx:989
    > #14 0x00007fffc9e7accc in SwEditWin::KeyInput(KeyEvent const&) (this=0x4d7a3e0, rKEvt=...)
    >     at /ssd1/lo/fedora/sw/source/uibase/docvw/edtwin.cxx:2620
    
    Noel said I should revert and push.
    
    Change-Id: I22d51bb3b5427af261cd4a1af19f9fa378891d27
    af8d2b51
SwGrammarContact.cxx 6.82 KB