• Miklos Vajna's avatar
    tdf#115574 sot: fix Excel -> Writer paste · 29d4ecf3
    Miklos Vajna yazdı
    Reported problem is that nothing happens for paste. Direct cause is that
    BITMAP is selected as the format, and Excel advertises BITMAP, but when
    we try to import that, it fails. There are 3 interesting commits in the
    recent history for this topic:
    
    - commit c47db038 (fdo#52547 SOT: Prefer
      embedding image data to embedding linked image., 2014-02-07) was a
      bugfix due to newer firefox
    - commit 538c13f3 (fdo#78801 fdo#52547
      Paste preference is image, then html, then text., 2014-05-28) was a
      regression fix from the previous fix
    - commit a96a7ce5 (fdo#81835 Don't
      prefer GDI Metafiles to RTF/HTML, 2014-08-05), was a regression fix
      from the previous fixes
    
    Going back to the original state shows that the Excel -> Writer use-case
    used to be RTF.
    
    Restore the old Excel -> Writer (RTF) behavior by:
    
    - going back to the original state, ignoring the enum class conversions
    - re-fix fdo#52547: prefer bitmap over html, but leave everything else
      unchanged
    - fdo#78801 needs no fix in this case
    - fdo#81835 needs no fix in this case
    - tdf#115574 selects RTF -> table shows up
    
    After all these complications, the actual fix is surprisingly simple.
    
    Change-Id: I2d728afa7d1dd7888fa43525366c197d806eea6c
    Reviewed-on: https://gerrit.libreoffice.org/52120Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
    Tested-by: 's avatarJenkins <ci@libreoffice.org>
    29d4ecf3
CppunitTest_sot_test_sot.mk 1.09 KB