• Noel Grandin's avatar
    crashtesting: ooo72057-1.doc · 036d8cb3
    Noel Grandin yazdı
    fallout from
        commit 65e41592
        pass SvStream around by std::unique_ptr
    
    The backtrace where it was was freeing the SvStream we need is below,
    the code seems dodgy because it is re-creating the underlying SvStream. Before
    65e41592, it just leaked the SvStream.
    
    0  SvStream::~SvStream()
        at tools/source/stream/stream.cxx:369
    1  SvFileStream::~SvFileStream()
        at tools/source/stream/strmunx.cxx:300
    2  SvFileStream::~SvFileStream()
        at tools/source/stream/strmunx.cxx:298
    3  std::default_delete<SvStream>::operator()(SvStream*) const
    4  std::unique_ptr<SvStream, std::default_delete<SvStream> >::reset(SvStream*)
    5  std::unique_ptr<SvStream, std::default_delete<SvStream> >::operator=(std::unique_ptr<SvStream, std::default_delete<SvStream> >&&)
    6  SfxMedium::GetMedium_Impl()
         at sfx2/source/doc/docfile.cxx:2603
    7  SfxMedium::GetInputStream()
        at sfx2/source/doc/docfile.cxx:3329
    8  ImportExcel8::ReadBasic()
        at sc/source/filter/excel/excimp8.cxx:391
    9  ImportExcel8::PostDocLoad()
        at sc/source/filter/excel/excimp8.cxx:425
    10 ImportExcel8::Read() (this=0x4727a10)
        at sc/source/filter/excel/read.cxx:1298
    11 ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT)
        at sc/source/filter/excel/excel.cxx:142
    
    Change-Id: I4fb769a7da71ef9a27ddef1581448efb3d303bde
    Reviewed-on: https://gerrit.libreoffice.org/57843
    Tested-by: Jenkins
    Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
    Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
    036d8cb3
docfile.cxx 145 KB