• Mike Kaganski's avatar
    tdf#115405, tdf#119910: don't check if UCRT is already installed · 18828273
    Mike Kaganski yazdı
    There appears to be common situation that a system has *some* UCRT libraries
    in System32, that were installed improperly (presumably by some applications
    using simple copy).In these cases, our installer would detect the presence of
    ucrtbase.dll, and not try to install UCRT on the system.
    
    Unfortunately, it seems that oftentimes such improper UCRT installations miss
    some parts of UCRT, which leads to LibreOffice failing to start with messages
    like "The program can't start because api-ms-win-crt-string-l1-1-0.dll is
    missing from your computer. Try reinstalling the program to fix this problem."
    (the missing component varies).
    
    This patch removes the check for UCRT presence. Installer will try to install
    UCRT on applicable systems unconditionally. Since the proper outcomes in case
    of already present UCRT are either WU_S_ALREADY_INSTALLED or WU_E_NOT_APPLICABLE
    and both are treated as success in inst_msu action (see InstallMSU in
    setup_native/source/win32/customactions/inst_msu/inst_msu.cxx), this should
    only make this part more robust, and not bring new problems (yes, I know that
    actually there will be new problems, as usual).
    
    Change-Id: I22a3d357014d31a8e492ff8a15bcb477eeb79735
    Reviewed-on: https://gerrit.libreoffice.org/60789
    Tested-by: Jenkins
    Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
    18828273
Signatur.idt 426 Bytes